public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts
Date: Thu, 31 Aug 2017 21:46:56 +0300	[thread overview]
Message-ID: <20170831184656.GQ4914@intel.com> (raw)
In-Reply-To: <1502823591-25310-1-git-send-email-manasi.d.navare@intel.com>

On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> This patch fixes the DP AUX CH timeouts observed during CI runs causing
> CI Failures on a specific PCI device. This issue was fixed previously
> by adding a quirk but looks like we need to increase this delay even more
> in order to get rid all the DP AUX CH timeouts.
> 
> Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
> DP AUX CH timeouts")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>

I pushed this to dinq. Let's hope the errors stay away this time. Thanks
for the patch.


> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 5ba8366..c4d8afa 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
>  	 * seems sufficient to avoid this problem.
>  	 */
>  	if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
> -		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
> +		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
>  		DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
>  			      vbt.t11_t12);
>  	}
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-31 18:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 18:59 [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts Manasi Navare
2017-08-15 19:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-16 19:35 ` [PATCH] " Manasi Navare
2017-08-16 21:19   ` Rodrigo Vivi
2017-08-16 22:54     ` Clint Taylor
2017-08-16 23:10       ` Manasi Navare
2017-08-31 18:46 ` Ville Syrjälä [this message]
2017-09-01  9:30   ` Saarinen, Jani
2017-09-05 11:56     ` Saarinen, Jani
2017-09-05 22:14       ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831184656.GQ4914@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    --cc=tomi.p.sarvela@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox