[PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Manasi Navare]

This patch fixes the DP AUX CH timeouts observed during CI runs causing
CI Failures on a specific PCI device. This issue was fixed previously
by adding a quirk but looks like we need to increase this delay even more
in order to get rid all the DP AUX CH timeouts.

Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
DP AUX CH timeouts")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Cc: Clinton Taylor <clinton.a.taylor@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5ba8366..c4d8afa 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
 	 * seems sufficient to avoid this problem.
 	 */
 	if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
-		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
+		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
 		DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
 			      vbt.t11_t12);
 	}
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Patchwork]

== Series Details ==

Series: drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts
URL   : https://patchwork.freedesktop.org/series/28824/
State : success

== Summary ==

Series 28824v1 drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts
https://patchwork.freedesktop.org/api/1.0/series/28824/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:442s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:437s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:356s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:555s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:520s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:522s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:516s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:603s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:438s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:418s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:412s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:493s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:477s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:477s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:583s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:591s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:522s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:457s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:467s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:482s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:441s
fi-skl-x1585l    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:479s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:546s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:410s

134bab7e0e7c147edb39a904d310ff88e3408442 drm-tip: 2017y-08m-15d-15h-48m-26s UTC integration manifest
af36fde8d560 drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5407/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Manasi Navare]

Hi Daniel/Clint,

Could you review this one, we need this patch to get pushed
to drm-tip so that we can see if SKL 6700hq is stable with this patch.
Thanks a lot in advanvce!

Regards
Manasi

On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> This patch fixes the DP AUX CH timeouts observed during CI runs causing
> CI Failures on a specific PCI device. This issue was fixed previously
> by adding a quirk but looks like we need to increase this delay even more
> in order to get rid all the DP AUX CH timeouts.
> 
> Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
> DP AUX CH timeouts")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 5ba8366..c4d8afa 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
>  	 * seems sufficient to avoid this problem.
>  	 */
>  	if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
> -		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
> +		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
>  		DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
>  			      vbt.t11_t12);
>  	}
> -- 
> 2.1.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Rodrigo Vivi]

It seems this quirk is randomly masking the real issue.

On Wed, Aug 16, 2017 at 12:35 PM, Manasi Navare
<manasi.d.navare@intel.com> wrote:
> Hi Daniel/Clint,
>
> Could you review this one, we need this patch to get pushed
> to drm-tip so that we can see if SKL 6700hq is stable with this patch.
> Thanks a lot in advanvce!
>
> Regards
> Manasi
>
> On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
>> This patch fixes the DP AUX CH timeouts observed during CI runs causing
>> CI Failures on a specific PCI device. This issue was fixed previously
>> by adding a quirk but looks like we need to increase this delay even more
>> in order to get rid all the DP AUX CH timeouts.
>>
>> Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
>> DP AUX CH timeouts")
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
>> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>> Cc: Clinton Taylor <clinton.a.taylor@intel.com>
>> Cc: Daniel Vetter <daniel.vetter@intel.com>
>> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 5ba8366..c4d8afa 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
>>        * seems sufficient to avoid this problem.
>>        */
>>       if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
>> -             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
>> +             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
>>               DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
>>                             vbt.t11_t12);
>>       }
>> --
>> 2.1.4
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Clint Taylor]

On 08/16/2017 02:19 PM, Rodrigo Vivi wrote:
> It seems this quirk is randomly masking the real issue.
It could be masking the real issue. The most likely cause of this issue 
is a slow power fall off to the panel when the PPS requests power-off. 
We would need physical access to the platform itself to confirm by 
measuring the power fall off with a scope. We could also instrument a 
Gen9 platform and confirm the panel power sequencer is working 
correctly. However that will not show why this particular tcon appears 
to no longer communicate after a reset.

-Clint



>
> On Wed, Aug 16, 2017 at 12:35 PM, Manasi Navare
> <manasi.d.navare@intel.com> wrote:
>> Hi Daniel/Clint,
>>
>> Could you review this one, we need this patch to get pushed
>> to drm-tip so that we can see if SKL 6700hq is stable with this patch.
>> Thanks a lot in advanvce!
>>
>> Regards
>> Manasi
>>
>> On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
>>> This patch fixes the DP AUX CH timeouts observed during CI runs causing
>>> CI Failures on a specific PCI device. This issue was fixed previously
>>> by adding a quirk but looks like we need to increase this delay even more
>>> in order to get rid all the DP AUX CH timeouts.
>>>
>>> Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
>>> DP AUX CH timeouts")
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
>>> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>>> Cc: Clinton Taylor <clinton.a.taylor@intel.com>
>>> Cc: Daniel Vetter <daniel.vetter@intel.com>
>>> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_dp.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>>> index 5ba8366..c4d8afa 100644
>>> --- a/drivers/gpu/drm/i915/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>>> @@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
>>>         * seems sufficient to avoid this problem.
>>>         */
>>>        if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
>>> -             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
>>> +             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
>>>                DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
>>>                              vbt.t11_t12);
>>>        }
>>> --
>>> 2.1.4
>>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Manasi Navare]

On Wed, Aug 16, 2017 at 03:54:35PM -0700, Clint Taylor wrote:
> 
> 
> On 08/16/2017 02:19 PM, Rodrigo Vivi wrote:
> >It seems this quirk is randomly masking the real issue.
> It could be masking the real issue. The most likely cause of this issue is a
> slow power fall off to the panel when the PPS requests power-off. We would
> need physical access to the platform itself to confirm by measuring the
> power fall off with a scope. We could also instrument a Gen9 platform and
> confirm the panel power sequencer is working correctly. However that will
> not show why this particular tcon appears to no longer communicate after a
> reset.
> 
> -Clint
> 
>

Yes I had actually added debug prints to check the status of the HPD pin
before the link training and it is 0. That means that the eDP panel power
never actually turned back on. But if we give enough time for this panel
power cycling then it turns the panel power correctly and issue is gone.
So I think increasing this delay is the fix for the issue on this specific
panel.

Regards
Manasi
 
> 
> >
> >On Wed, Aug 16, 2017 at 12:35 PM, Manasi Navare
> ><manasi.d.navare@intel.com> wrote:
> >>Hi Daniel/Clint,
> >>
> >>Could you review this one, we need this patch to get pushed
> >>to drm-tip so that we can see if SKL 6700hq is stable with this patch.
> >>Thanks a lot in advanvce!
> >>
> >>Regards
> >>Manasi
> >>
> >>On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> >>>This patch fixes the DP AUX CH timeouts observed during CI runs causing
> >>>CI Failures on a specific PCI device. This issue was fixed previously
> >>>by adding a quirk but looks like we need to increase this delay even more
> >>>in order to get rid all the DP AUX CH timeouts.
> >>>
> >>>Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
> >>>DP AUX CH timeouts")
> >>>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> >>>Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> >>>Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> >>>Cc: Daniel Vetter <daniel.vetter@intel.com>
> >>>Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> >>>---
> >>>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> >>>index 5ba8366..c4d8afa 100644
> >>>--- a/drivers/gpu/drm/i915/intel_dp.c
> >>>+++ b/drivers/gpu/drm/i915/intel_dp.c
> >>>@@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
> >>>        * seems sufficient to avoid this problem.
> >>>        */
> >>>       if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
> >>>-             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
> >>>+             vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
> >>>               DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
> >>>                             vbt.t11_t12);
> >>>       }
> >>>--
> >>>2.1.4
> >>>
> >>_______________________________________________
> >>Intel-gfx mailing list
> >>Intel-gfx@lists.freedesktop.org
> >>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> >
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Ville Syrjälä]

On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> This patch fixes the DP AUX CH timeouts observed during CI runs causing
> CI Failures on a specific PCI device. This issue was fixed previously
> by adding a quirk but looks like we need to increase this delay even more
> in order to get rid all the DP AUX CH timeouts.
> 
> Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to fix
> DP AUX CH timeouts")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>

I pushed this to dinq. Let's hope the errors stay away this time. Thanks
for the patch.


> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 5ba8366..c4d8afa 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5246,7 +5246,7 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,
>  	 * seems sufficient to avoid this problem.
>  	 */
>  	if (dev_priv->quirks & QUIRK_INCREASE_T12_DELAY) {
> -		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 800 * 10);
> +		vbt.t11_t12 = max_t(u16, vbt.t11_t12, 900 * 10);
>  		DRM_DEBUG_KMS("Increasing T12 panel delay as per the quirk to %d\n",
>  			      vbt.t11_t12);
>  	}
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Saarinen, Jani]

Hi,
> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Ville Syrjälä
> Sent: torstai 31. elokuuta 2017 21.47
> To: Navare, Manasi D <manasi.d.navare@intel.com>
> Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Vetter, Daniel
> <daniel.vetter@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to
> 900 ms to fix DP AUX CH timeouts
> 
> On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> > This patch fixes the DP AUX CH timeouts observed during CI runs
> > causing CI Failures on a specific PCI device. This issue was fixed
> > previously by adding a quirk but looks like we need to increase this
> > delay even more in order to get rid all the DP AUX CH timeouts.
> >
> > Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk to
> > fix DP AUX CH timeouts")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> 
> I pushed this to dinq. Let's hope the errors stay away this time. Thanks for
> the patch.
Well, apparently still failing: 
https://intel-gfx-ci.01.org/tree/drm-tip/fi-skl-6700hq.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3023/commits_short.log

> --
> Ville Syrjälä
> Intel OTC

Br,
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Saarinen, Jani]

Hi,

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Saarinen, Jani
> Sent: perjantai 1. syyskuuta 2017 12.30
> To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Navare, Manasi D
> <manasi.d.navare@intel.com>
> Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Vetter, Daniel
> <daniel.vetter@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to
> 900 ms to fix DP AUX CH timeouts
> 
> Hi,
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > Behalf Of Ville Syrjälä
> > Sent: torstai 31. elokuuta 2017 21.47
> > To: Navare, Manasi D <manasi.d.navare@intel.com>
> > Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Vetter, Daniel
> > <daniel.vetter@intel.com>; intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel
> > delay to
> > 900 ms to fix DP AUX CH timeouts
> >
> > On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> > > This patch fixes the DP AUX CH timeouts observed during CI runs
> > > causing CI Failures on a specific PCI device. This issue was fixed
> > > previously by adding a quirk but looks like we need to increase this
> > > delay even more in order to get rid all the DP AUX CH timeouts.
> > >
> > > Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk
> > > to fix DP AUX CH timeouts")
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > > Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> >
> > I pushed this to dinq. Let's hope the errors stay away this time.
> > Thanks for the patch.
> Well, apparently still failing:
> https://intel-gfx-ci.01.org/tree/drm-tip/fi-skl-6700hq.html
Taking a bit back, not anymore, any idea why now has been quite stable?

> 
> > --
> > Ville Syrjälä
> > Intel OTC
> 

Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

[Rodrigo Vivi]

On Tue, Sep 05, 2017 at 11:56:11AM +0000, Saarinen, Jani wrote:
> Hi,
> 
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> > Of Saarinen, Jani
> > Sent: perjantai 1. syyskuuta 2017 12.30
> > To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Navare, Manasi D
> > <manasi.d.navare@intel.com>
> > Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Vetter, Daniel
> > <daniel.vetter@intel.com>; intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to
> > 900 ms to fix DP AUX CH timeouts
> > 
> > Hi,
> > > -----Original Message-----
> > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > > Behalf Of Ville Syrjälä
> > > Sent: torstai 31. elokuuta 2017 21.47
> > > To: Navare, Manasi D <manasi.d.navare@intel.com>
> > > Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Vetter, Daniel
> > > <daniel.vetter@intel.com>; intel-gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel
> > > delay to
> > > 900 ms to fix DP AUX CH timeouts
> > >
> > > On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote:
> > > > This patch fixes the DP AUX CH timeouts observed during CI runs
> > > > causing CI Failures on a specific PCI device. This issue was fixed
> > > > previously by adding a quirk but looks like we need to increase this
> > > > delay even more in order to get rid all the DP AUX CH timeouts.
> > > >
> > > > Fixes: c99a259b4b5192ba ("drm/i915/edp: Add a T12 panel delay quirk
> > > > to fix DP AUX CH timeouts")
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101144
> > > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > > > Cc: Clinton Taylor <clinton.a.taylor@intel.com>
> > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > >
> > > I pushed this to dinq. Let's hope the errors stay away this time.
> > > Thanks for the patch.
> > Well, apparently still failing:
> > https://intel-gfx-ci.01.org/tree/drm-tip/fi-skl-6700hq.html
> Taking a bit back, not anymore, any idea why now has been quite stable?

Ville merged this patch last week.

> 
> > 
> > > --
> > > Ville Syrjälä
> > > Intel OTC
> > 
> 
> Jani Saarinen
> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
> 
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx