From: Ben Widawsky <ben@bwidawsk.net>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: Fix example comment of format modifier blob
Date: Thu, 31 Aug 2017 13:00:35 -0700 [thread overview]
Message-ID: <20170831200034.GA3393@mail.bwidawsk.net> (raw)
In-Reply-To: <20170831195215.13302-1-krisman@collabora.co.uk>
On 17-08-31 16:52:14, Gabriel Krisman Bertazi wrote:
>To represent formats 98-102, the supported formats mask must be
>0x7c00000000 and not 0x3c00000000.
>
>Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>---
> include/uapi/drm/drm_mode.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
>index 54fc38c3c3f1..34b6bb34b002 100644
>--- a/include/uapi/drm/drm_mode.h
>+++ b/include/uapi/drm/drm_mode.h
>@@ -749,9 +749,9 @@ struct drm_format_modifier {
> * If the number formats grew to 128, and formats 98-102 are
> * supported with the modifier:
> *
>- * 0x0000003c00000000 0000000000000000
>+ * 0x0000007c00000000 0000000000000000
> * ^
>- * |__offset = 64, formats = 0x3c00000000
>+ * |__offset = 64, formats = 0x7c00000000
> *
> */
> __u64 formats;
>--
>>> hex(0x1f << 98)
'0x7c000000000000000000000000'
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-31 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 19:52 [PATCH 1/2] drm: Fix example comment of format modifier blob Gabriel Krisman Bertazi
2017-08-31 19:52 ` [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap Gabriel Krisman Bertazi
2017-08-31 20:06 ` Ben Widawsky
2017-09-01 4:35 ` Gabriel Krisman Bertazi
2017-09-04 8:21 ` Daniel Vetter
2017-09-04 16:37 ` Ville Syrjälä
2017-09-05 7:36 ` Daniel Stone
2017-09-07 12:19 ` Ville Syrjälä
2017-09-22 5:25 ` Gabriel Krisman Bertazi
2017-09-22 11:54 ` Ville Syrjälä
2017-08-31 20:00 ` Ben Widawsky [this message]
2017-09-04 8:24 ` [PATCH 1/2] drm: Fix example comment of format modifier blob Daniel Vetter
2017-08-31 20:22 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-08-31 23:37 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831200034.GA3393@mail.bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krisman@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox