From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Date: Fri, 1 Sep 2017 16:43:29 +0300 [thread overview]
Message-ID: <20170901134329.GU4914@intel.com> (raw)
In-Reply-To: <1504252261-28964-2-git-send-email-mika.kahola@intel.com>
On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote:
> According to spec we should send SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for
> v3+ VBT's. Testing with VBT v3 the current implementation yields the
> following error message
>
> *ERROR* Video mode command 0x00000041 send failed.
>
> To get rid of this error message, let's limit SHUTDOWN only for VBT
> versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since
AFAIK there is no version 4 of the sequence block.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 2a0f5d3..b48b9b7 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -916,7 +916,7 @@ static void intel_dsi_disable(struct intel_encoder *encoder,
> * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing
> * has shown that the v3 sequence works for v2 VBTs too
> */
> - if (is_vid_mode(intel_dsi)) {
> + if (is_vid_mode(intel_dsi) && dev_priv->vbt.dsi.seq_version > 3) {
> /* Send Shutdown command to the panel in LP mode */
> for_each_dsi_port(port, intel_dsi->ports)
> dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-01 13:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 7:50 [PATCH 0/2] drm/i915/dsi: Fix error on DSI video mode command Mika Kahola
2017-09-01 7:51 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Mika Kahola
2017-09-01 13:43 ` Ville Syrjälä [this message]
2017-09-04 7:59 ` Mika Kahola
2017-09-04 15:04 ` Ville Syrjälä
2017-09-05 8:33 ` Mika Kahola
2017-09-05 9:27 ` Shankar, Uma
2017-09-05 9:44 ` [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command" Vidya Srinivas
2017-09-05 10:43 ` Mika Kahola
2017-09-13 8:05 ` Jani Nikula
2017-09-12 10:02 ` Chauhan, Madhav
2017-09-13 8:09 ` Jani Nikula
2017-09-13 8:13 ` Chauhan, Madhav
2017-09-05 13:16 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Ville Syrjälä
2017-09-05 14:55 ` Shankar, Uma
2017-09-05 15:10 ` Ville Syrjälä
2017-09-01 7:51 ` [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message Mika Kahola
2017-09-13 8:09 ` Jani Nikula
2017-09-01 8:08 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command Patchwork
2017-09-01 9:34 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-05 9:53 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2) Patchwork
2017-09-05 11:03 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901134329.GU4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox