From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
Date: Fri, 1 Sep 2017 18:21:19 +0300 [thread overview]
Message-ID: <20170901152119.GY4914@intel.com> (raw)
In-Reply-To: <20170901145729.21363-1-chris@chris-wilson.co.uk>
On Fri, Sep 01, 2017 at 03:57:28PM +0100, Chris Wilson wrote:
> Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
>
> Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 8a9d37ac16d4..67317b79b9e0 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -290,7 +290,7 @@ static int eb_create(struct i915_execbuffer *eb)
> * direct lookup.
> */
> do {
> - unsigned int flags;
> + gfp_t flags;
>
> /* While we can still reduce the allocation size, don't
> * raise a warning and allow the allocation to fail.
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-01 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
2017-09-01 15:05 ` Lionel Landwerlin
2017-09-01 15:21 ` Ville Syrjälä [this message]
2017-09-01 15:47 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Silence sparse by using gfp_t Patchwork
2017-09-04 6:50 ` [PATCH 1/2] " Joonas Lahtinen
2017-09-04 11:08 ` Chris Wilson
2017-09-18 13:19 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901152119.GY4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox