From: Gustavo Padovan <gustavo@padovan.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC PATCH 5/5] drm/atomic: Make async plane update checks work as intended.
Date: Sat, 2 Sep 2017 15:59:22 -0300 [thread overview]
Message-ID: <20170902185922.GA13103@jade> (raw)
In-Reply-To: <20170830124655.s3femp7ejnjk3vqp@phenom.ffwll.local>
2017-08-30 Daniel Vetter <daniel@ffwll.ch>:
> On Wed, Aug 30, 2017 at 02:17:52PM +0200, Maarten Lankhorst wrote:
> > By always keeping track of the last commit in plane_state, we know
> > whether there is an active update on the plane or not. With that
> > information we can reject the fast update, and force the slowpath
> > to be used as was originally intended.
> >
> > Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Makes sense, but I think like patch 1 it would be better to do this in a
> separate series. Which would then include a patch to move i915 over to the
> async plane support.
This patch makes sense to me and it is better than the fix I wrote but never
got around to send it out. I can pick in here locally, put the patches I
have here for the drivers on top of it and send to intel-gfx for CI.
Anyway, without the i915 change, this is
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-02 18:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 12:17 [PATCH 0/5] drm/atomic: Fix use-after-free with unbound connectors/planes Maarten Lankhorst
2017-08-30 12:17 ` [RFC PATCH 1/5] drm/i915: Always wait for flip_done Maarten Lankhorst
2017-08-30 12:43 ` Daniel Vetter
2017-08-30 12:54 ` Maarten Lankhorst
2017-08-30 13:40 ` Daniel Vetter
2017-08-31 15:18 ` Maarten Lankhorst
2017-09-04 7:30 ` Daniel Vetter
2017-09-04 7:55 ` Maarten Lankhorst
2017-09-04 11:18 ` [Intel-gfx] " Chris Wilson
2017-08-30 12:17 ` [PATCH 2/5] drm/atomic: Remove waits in drm_atomic_helper_commit_cleanup_done Maarten Lankhorst
2017-08-30 12:28 ` Daniel Vetter
2017-08-30 12:17 ` [PATCH 3/5] drm/atomic: Move drm_crtc_commit to drm_crtc_state, v2 Maarten Lankhorst
2017-08-30 13:09 ` Laurent Pinchart
2017-08-30 13:34 ` Maarten Lankhorst
2017-08-30 12:17 ` [PATCH 4/5] drm/atomic: Fix freeing connector/plane state too early by tracking commits, v2 Maarten Lankhorst
2017-08-30 12:40 ` Daniel Vetter
2017-08-30 12:46 ` [Intel-gfx] " Maarten Lankhorst
2017-08-30 14:10 ` Laurent Pinchart
2017-08-30 14:17 ` Daniel Vetter
2017-08-30 14:44 ` [Intel-gfx] " Laurent Pinchart
2017-08-30 12:17 ` [RFC PATCH 5/5] drm/atomic: Make async plane update checks work as intended Maarten Lankhorst
2017-08-30 12:46 ` Daniel Vetter
2017-08-30 12:53 ` Maarten Lankhorst
2017-08-30 13:43 ` Daniel Vetter
2017-09-02 18:59 ` Gustavo Padovan [this message]
2017-09-04 7:31 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170902185922.GA13103@jade \
--to=gustavo@padovan.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox