Re: [PATCH 1/2] drm: Fix example comment of format modifier blob

Daniel Vetter
2017-09-04T08:24:12Z

On Thu, Aug 31, 2017 at 01:00:35PM -0700, Ben Widawsky wrote:
> On 17-08-31 16:52:14, Gabriel Krisman Bertazi wrote:
> > To represent formats 98-102, the supported formats mask must be
> > 0x7c00000000 and not 0x3c00000000.
> >
> > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> > ---
> > include/uapi/drm/drm_mode.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> > index 54fc38c3c3f1..34b6bb34b002 100644
> > --- a/include/uapi/drm/drm_mode.h
> > +++ b/include/uapi/drm/drm_mode.h
> > @@ -749,9 +749,9 @@ struct drm_format_modifier {
> > * If the number formats grew to 128, and formats 98-102 are
> > * supported with the modifier:
> > *
> > - * 0x0000003c00000000 0000000000000000
> > + * 0x0000007c00000000 0000000000000000
> > * ^
> > - * |__offset = 64, formats = 0x3c00000000
> > + * |__offset = 64, formats = 0x7c00000000
> > *
> > */
> > __u64 formats;
> > --
>
> > > > hex(0x1f << 98)
> '0x7c000000000000000000000000'
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Applied to drm-misc-next, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation