Re: [PATCH v2] drm/i915: Speed up DMC firmware loading

David Weinehall
2017-09-04T19:09:24Z

On Mon, Sep 04, 2017 at 07:55:56PM +0100, Chris Wilson wrote:
> Quoting David Weinehall (2017-09-04 19:38:04)
> > v2: Per feedback from Chris & Ville there's no need to do the whole
> > forcewake dance, so lose that bit (Chris, Ville)
>
> > @@ -251,9 +253,20 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv)
> > return;
> > }
> >
> > + fw_domains = intel_uncore_forcewake_for_reg(dev_priv,
> > + CSR_PROGRAM(0),
> > + FW_REG_WRITE);
> > +
> > fw_size = dev_priv->csr.dmc_fw_size;
> > + assert_rpm_wakelock_held(dev_priv);
> > + spin_lock_irqsave(&dev_priv->uncore.lock, flags);
> > + intel_uncore_forcewake_get__locked(dev_priv, fw_domains);
>
> Still there!

Yeah, I missed the git add... Whooopsie; check v3.

Kind regards, David