public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)
Date: Wed, 6 Sep 2017 17:45:48 +0300	[thread overview]
Message-ID: <20170906144548.GT4914@intel.com> (raw)
In-Reply-To: <20170906143615.9541-1-chris@chris-wilson.co.uk>

On Wed, Sep 06, 2017 at 03:36:15PM +0100, Chris Wilson wrote:
> The early gen3 machines inherited the MI block and restrictions from
> gen2, and may only use physical addresses in conjunction with
> MI_STORE_DATA_IMM -- that makes it unusable for us from userspace, where
> we can only use virtual offsets.

Matches my docs.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_gt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index d5e8b557..b3f3b380 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -557,6 +557,9 @@ bool gem_can_store_dword(int fd, unsigned int engine)
>  	if (gen <= 2) /* requires physical addresses */
>  		return false;
>  
> +	if (gen == 3 && (info->is_grantsdale || info->is_alviso))
> +		return false; /* only supports physical addresses */
> +
>  	if (gen == 6 && (engine & ~(3<<13)) == I915_EXEC_BSD)
>  		return false; /* kills the machine! */
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-06 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 14:36 [PATCH igt] lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm) Chris Wilson
2017-09-06 14:45 ` Ville Syrjälä [this message]
2017-09-06 14:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-06 16:58 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170906144548.GT4914@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox