[PATCH igt] lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)

[PATCH igt] lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)

[Chris Wilson]

The early gen3 machines inherited the MI block and restrictions from
gen2, and may only use physical addresses in conjunction with
MI_STORE_DATA_IMM -- that makes it unusable for us from userspace, where
we can only use virtual offsets.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_gt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index d5e8b557..b3f3b380 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -557,6 +557,9 @@ bool gem_can_store_dword(int fd, unsigned int engine)
 	if (gen <= 2) /* requires physical addresses */
 		return false;
 
+	if (gen == 3 && (info->is_grantsdale || info->is_alviso))
+		return false; /* only supports physical addresses */
+
 	if (gen == 6 && (engine & ~(3<<13)) == I915_EXEC_BSD)
 		return false; /* kills the machine! */
 
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)

[Ville Syrjälä]

On Wed, Sep 06, 2017 at 03:36:15PM +0100, Chris Wilson wrote:
> The early gen3 machines inherited the MI block and restrictions from
> gen2, and may only use physical addresses in conjunction with
> MI_STORE_DATA_IMM -- that makes it unusable for us from userspace, where
> we can only use virtual offsets.

Matches my docs.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_gt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index d5e8b557..b3f3b380 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -557,6 +557,9 @@ bool gem_can_store_dword(int fd, unsigned int engine)
>  	if (gen <= 2) /* requires physical addresses */
>  		return false;
>  
> +	if (gen == 3 && (info->is_grantsdale || info->is_alviso))
> +		return false; /* only supports physical addresses */
> +
>  	if (gen == 6 && (engine & ~(3<<13)) == I915_EXEC_BSD)
>  		return false; /* kills the machine! */
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)

[Patchwork]

== Series Details ==

Series: lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)
URL   : https://patchwork.freedesktop.org/series/29889/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
918863f8e3e8f49235fd2e4a36e11f386c06c11c intel_display_poller: Fix truncation of a test name.

with latest DRM-Tip kernel build CI_DRM_3045
c18a85fe008e drm-tip: 2017y-09m-06d-13h-17m-59s UTC integration manifest

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:456s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:450s
fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0   fail:0   skip:64  time:367s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:558s
fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0   fail:0   skip:105 time:256s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:522s
fi-byt-j1900     total:289  pass:254  dwarn:1   dfail:0   fail:0   skip:34  time:529s
fi-byt-n2820     total:289  pass:250  dwarn:1   dfail:0   fail:0   skip:38  time:521s
fi-cfl-s         total:289  pass:249  dwarn:4   dfail:0   fail:0   skip:36  time:455s
fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0   fail:0   skip:59  time:443s
fi-glk-2a        total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:621s
fi-hsw-4770      total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:453s
fi-hsw-4770r     total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:430s
fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:430s
fi-ivb-3520m     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:510s
fi-ivb-3770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:478s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:509s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:597s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:598s
fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:532s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:541s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:520s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:449s
fi-skl-x1585l    total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:500s
fi-snb-2520m     total:289  pass:251  dwarn:0   dfail:0   fail:0   skip:38  time:568s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:1   skip:39  time:405s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_154/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: warning for lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)

[Patchwork]

== Series Details ==

Series: lib: Disable MI_STORE_DATA_IMM for gen3 (i915g and i915gm)
URL   : https://patchwork.freedesktop.org/series/29889/
State : warning

== Summary ==

Test perf:
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252 +1
Test kms_flip:
        Subgroup plain-flip-fb-recreate:
                fail       -> PASS       (shard-hsw) fdo#102504
Test kms_draw_crc:
        Subgroup draw-method-xrgb2101010-mmap-wc-xtiled:
                pass       -> SKIP       (shard-hsw)
Test kms_cursor_legacy:
        Subgroup cursor-vs-flip-varying-size:
                pass       -> SKIP       (shard-hsw)

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102504 https://bugs.freedesktop.org/show_bug.cgi?id=102504

shard-hsw        total:2265 pass:1232 dwarn:0   dfail:0   fail:15  skip:1018 time:9663s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_154/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx