From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/tools_test: Make sure l3_parity is supported
Date: Thu, 7 Sep 2017 09:49:42 +0300 [thread overview]
Message-ID: <20170907064942.4084-1-abdiel.janulgue@linux.intel.com> (raw)
Check support before executing test.
v2: Skip test only if intel_l3_parity tool tells us to skip. (Petri)
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
---
tests/tools_test.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/tools_test.c b/tests/tools_test.c
index ccd165d..ebd4a9d 100644
--- a/tests/tools_test.c
+++ b/tests/tools_test.c
@@ -89,7 +89,8 @@ igt_main
igt_system_cmd(exec_return,
"../tools/intel_l3_parity -r 0 -b 0 "
"-s 0 -e");
- igt_assert(exec_return == IGT_EXIT_SUCCESS);
+ igt_skip_on_f(exec_return == IGT_EXIT_SKIP,
+ "intel_l3_parity not supported\n");
igt_system_cmd(exec_return,
"../tools/intel_l3_parity -l | "
@@ -101,13 +102,14 @@ igt_main
&val);
igt_assert(val == 1);
} else {
- igt_fail(IGT_EXIT_FAILURE);
+ igt_skip("intel_l3_parity not supported\n");
}
igt_system_cmd(exec_return,
"../tools/intel_l3_parity -r 0 -b 0 "
"-s 0 -e");
- igt_assert(exec_return == IGT_EXIT_SUCCESS);
+ igt_skip_on_f(exec_return == IGT_EXIT_SKIP,
+ "intel_l3_parity not supported\n");
/* Check that we can clear remaps */
igt_system_cmd(exec_return,
@@ -119,7 +121,7 @@ igt_main
&val);
igt_assert(val == 1);
} else {
- igt_fail(IGT_EXIT_FAILURE);
+ igt_skip("intel_l3_parity not supported\n");
}
}
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-09-07 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 6:49 Abdiel Janulgue [this message]
2017-09-07 7:14 ` ✓ Fi.CI.BAT: success for tests/tools_test: Make sure l3_parity is supported Patchwork
2017-09-07 8:13 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-11 10:09 ` [PATCH i-g-t] " Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2017-09-13 9:24 Abdiel Janulgue
2017-09-13 10:10 ` Petri Latvala
2017-09-13 10:11 ` Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907064942.4084-1-abdiel.janulgue@linux.intel.com \
--to=abdiel.janulgue@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox