From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Apply the GTT write flush for all !llc machines
Date: Thu, 7 Sep 2017 21:50:13 +0300 [thread overview]
Message-ID: <20170907185013.GE4914@intel.com> (raw)
In-Reply-To: <20170907184520.5032-1-chris@chris-wilson.co.uk>
On Thu, Sep 07, 2017 at 07:45:20PM +0100, Chris Wilson wrote:
> We also see the delayed GTT write issue on i915g/i915gm, so let's
> presume that it is a universal problem for all !llc machines, and that we
> just haven't yet noticed on g33, gen4 and gen5 machines.
>
> v2: Use a register that exists on all platforms
>
> Testcase: igt/gem_mmap_gtt/coherency # i915gm
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102577
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 4dffebae5601..562c9510a7db 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -694,10 +694,10 @@ flush_write_domain(struct drm_i915_gem_object *obj, unsigned int flush_domains)
>
> switch (obj->base.write_domain) {
> case I915_GEM_DOMAIN_GTT:
> - if (INTEL_GEN(dev_priv) >= 6 && !HAS_LLC(dev_priv)) {
> + if (!HAS_LLC(dev_priv)) {
> intel_runtime_pm_get(dev_priv);
> spin_lock_irq(&dev_priv->uncore.lock);
> - POSTING_READ_FW(RING_ACTHD(dev_priv->engine[RCS]->mmio_base));
> + POSTING_READ_FW(RING_HEAD(dev_priv->engine[RCS]->mmio_base));
> spin_unlock_irq(&dev_priv->uncore.lock);
> intel_runtime_pm_put(dev_priv);
> }
> --
> 2.14.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-07 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 14:31 [PATCH] drm/i915: Apply the GTT write flush for all !llc machines Chris Wilson
2017-09-07 14:48 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-09-07 18:23 ` [PATCH] " Ville Syrjälä
2017-09-07 18:35 ` Chris Wilson
2017-09-07 18:47 ` Ville Syrjälä
2017-09-07 18:45 ` [PATCH v2] " Chris Wilson
2017-09-07 18:50 ` Ville Syrjälä [this message]
2017-09-07 20:46 ` Chris Wilson
2017-09-07 19:07 ` ✗ Fi.CI.BAT: failure for drm/i915: Apply the GTT write flush for all !llc machines (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907185013.GE4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox