From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Simplify i915_reg_read_ioctl
Date: Fri, 8 Sep 2017 15:24:13 +0300
Message-ID: <20170908122413.GG4914@intel.com>
References: <20170908092935.1278-1-joonas.lahtinen@linux.intel.com>
 <20170908092935.1278-2-joonas.lahtinen@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C17F96E285
 for <intel-gfx@lists.freedesktop.org>; Fri,  8 Sep 2017 12:24:18 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170908092935.1278-2-joonas.lahtinen@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBTZXAgMDgsIDIwMTcgYXQgMTI6Mjk6MzVQTSArMDMwMCwgSm9vbmFzIExhaHRpbmVu
IHdyb3RlOgo+IENvbnZlcnQgdG8gdXNlIHRoZSBmcmVzaGx5IGF2YWlsYWJsZSBtYWRlIElOVEVM
X0dFTl9NQVNLIGZvciBlYXNpZXIKPiBncmVwcGluZyBhbmQgaW1wcm92ZSBmdW5jdGlvbiByZWFk
YWJpbGl0eSBhbmQgY2xhcmlmeSB0aGUgVUFCSQo+IGRvY3VtZW50YXRpb24uCj4gCj4gTm8gZnVu
Y3Rpb25hbCBjaGFuZ2VzLgo+IAo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A
aW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K
PiBTaWduZWQtb2ZmLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5p
bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIHwg
ODEgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBpbmNsdWRlL3VhcGkv
ZHJtL2k5MTVfZHJtLmggICAgICAgICB8ICA2ICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ0IGlu
c2VydGlvbnMoKyksIDQzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vu
Y29yZS5jCj4gaW5kZXggMWIzOGViOTRkNDYxLi43NGYxMzVkMjQ3YTEgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+IEBAIC0xMjkyLDcyICsxMjkyLDcxIEBAIHZvaWQgaW50
ZWxfdW5jb3JlX2Zpbmkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaW50
ZWxfdW5jb3JlX2ZvcmNld2FrZV9yZXNldChkZXZfcHJpdiwgZmFsc2UpOwo+ICB9Cj4gIAo+IC0j
ZGVmaW5lIEdFTl9SQU5HRShsLCBoKSBHRU5NQVNLKChoKSAtIDEsIChsKSAtIDEpCj4gLQo+IC1z
dGF0aWMgY29uc3Qgc3RydWN0IHJlZ2lzdGVyX3doaXRlbGlzdCB7Cj4gLQlpOTE1X3JlZ190IG9m
ZnNldF9sZHcsIG9mZnNldF91ZHc7Cj4gLQl1aW50MzJfdCBzaXplOwo+IC0JLyogc3VwcG9ydGVk
IGdlbnMsIDB4MTAgZm9yIDQsIDB4MzAgZm9yIDQgYW5kIDUsIGV0Yy4gKi8KPiAtCXVpbnQzMl90
IGdlbl9iaXRtYXNrOwo+IC19IHdoaXRlbGlzdFtdID0gewo+IC0JeyAub2Zmc2V0X2xkdyA9IFJJ
TkdfVElNRVNUQU1QKFJFTkRFUl9SSU5HX0JBU0UpLAo+IC0JICAub2Zmc2V0X3VkdyA9IFJJTkdf
VElNRVNUQU1QX1VEVyhSRU5ERVJfUklOR19CQVNFKSwKPiAtCSAgLnNpemUgPSA4LCAuZ2VuX2Jp
dG1hc2sgPSBHRU5fUkFOR0UoNCwgMTApIH0sCj4gLX07Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qg
cmVnX3doaXRlbGlzdCB7Cj4gKwlpOTE1X3JlZ190IG9mZnNldF9sZHc7Cj4gKwlpOTE1X3JlZ190
IG9mZnNldF91ZHc7Cj4gKwl1bnNpZ25lZCBsb25nIGdlbl9tYXNrOwoKJ2xvbmcnIHNlZW1zIGxp
a2UgYSBiYWQgdHlwZSBmb3Igc29tZXRoaW5nIGxpa2UgdGhpcy4gQ2hhbmdlcyBzaXplIG9uIDMy
CnZzIDY0IGJpdC4gQWxzbyB3ZSBjb3VsZCBtYWtlIGRvIHdpdGggMTYgYml0cyBmb3Igbm93LCB0
aG91Z2ggd2l0aAp0aGUgc2luZ2xlIHdoaXRlbGlzdCBlbnRyeSB0aGlzIG9ubHkgaGFzIGEgc21h
bGwgaW1wYWN0LgoKPiArCXU4IHNpemU7Cj4gK30gcmVnX3JlYWRfd2hpdGVsaXN0W10gPSB7ewo+
ICsJLm9mZnNldF9sZHcgPSBSSU5HX1RJTUVTVEFNUChSRU5ERVJfUklOR19CQVNFKSwKPiArCS5v
ZmZzZXRfdWR3ID0gUklOR19USU1FU1RBTVBfVURXKFJFTkRFUl9SSU5HX0JBU0UpLAo+ICsJLmdl
bl9tYXNrID0gSU5URUxfR0VOX01BU0soNCwgMTApLAo+ICsJLnNpemUgPSA4Cj4gK319Owo+ICAK
PiAgaW50IGk5MTVfcmVnX3JlYWRfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJ
dm9pZCAqZGF0YSwgc3RydWN0IGRybV9maWxlICpmaWxlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVf
cmVnX3JlYWQgKnJlZyA9IGRhdGE7Cj4gLQlzdHJ1Y3QgcmVnaXN0ZXJfd2hpdGVsaXN0IGNvbnN0
ICplbnRyeSA9IHdoaXRlbGlzdDsKPiAtCXVuc2lnbmVkIHNpemU7Cj4gLQlpOTE1X3JlZ190IG9m
ZnNldF9sZHcsIG9mZnNldF91ZHc7Cj4gLQlpbnQgaSwgcmV0ID0gMDsKPiAtCj4gLQlmb3IgKGkg
PSAwOyBpIDwgQVJSQVlfU0laRSh3aGl0ZWxpc3QpOyBpKyssIGVudHJ5KyspIHsKPiAtCQlpZiAo
aTkxNV9tbWlvX3JlZ19vZmZzZXQoZW50cnktPm9mZnNldF9sZHcpID09IChyZWctPm9mZnNldCAm
IC1lbnRyeS0+c2l6ZSkgJiYKPiAtCQkgICAgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW5fbWFz
ayAmIGVudHJ5LT5nZW5fYml0bWFzaykpCj4gKwlzdHJ1Y3QgcmVnX3doaXRlbGlzdCBjb25zdCAq
ZW50cnk7Cj4gKwl1bnNpZ25lZCBmbGFnczsKPiArCWludCByZW1haW47Cj4gKwlpbnQgcmV0ID0g
MDsKPiArCj4gKwllbnRyeSA9IHJlZ19yZWFkX3doaXRlbGlzdDsKPiArCXJlbWFpbiA9IEFSUkFZ
X1NJWkUocmVnX3JlYWRfd2hpdGVsaXN0KTsKPiArCXdoaWxlIChyZW1haW4pIHsKPiArCQlpZiAo
SU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbl9tYXNrICYgZW50cnktPmdlbl9tYXNrICYmCj4gKwkJ
ICAgIGk5MTVfbW1pb19yZWdfb2Zmc2V0KGVudHJ5LT5vZmZzZXRfbGR3KSA9PQo+ICsJCQkgICAg
KHJlZy0+b2Zmc2V0ICYgLWVudHJ5LT5zaXplKSkKPiAgCQkJYnJlYWs7Cj4gKwkJZW50cnkrKzsK
PiArCQlyZW1haW4tLTsKPiAgCX0KPiAgCj4gLQlpZiAoaSA9PSBBUlJBWV9TSVpFKHdoaXRlbGlz
dCkpCj4gKwlpZiAoIXJlbWFpbikKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQkvKiBXZSB1
c2UgdGhlIGxvdyBiaXRzIHRvIGVuY29kZSBleHRyYSBmbGFncyBhcyB0aGUgcmVnaXN0ZXIgc2hv
dWxkCj4gLQkgKiBiZSBuYXR1cmFsbHkgYWxpZ25lZCAoYW5kIHRob3NlIHRoYXQgYXJlIG5vdCBz
byBhbGlnbmVkIG1lcmVseQo+IC0JICogbGltaXQgdGhlIGF2YWlsYWJsZSBmbGFncyBmb3IgdGhh
dCByZWdpc3RlcikuCj4gLQkgKi8KPiAtCW9mZnNldF9sZHcgPSBlbnRyeS0+b2Zmc2V0X2xkdzsK
PiAtCW9mZnNldF91ZHcgPSBlbnRyeS0+b2Zmc2V0X3VkdzsKPiAtCXNpemUgPSBlbnRyeS0+c2l6
ZTsKPiAtCXNpemUgfD0gcmVnLT5vZmZzZXQgXiBpOTE1X21taW9fcmVnX29mZnNldChvZmZzZXRf
bGR3KTsKPiArCUdFTV9CVUdfT04oaHdlaWdodDgoZW50cnktPnNpemUpICE9IDEpOwo+ICsJR0VN
X0JVR19PTihlbnRyeS0+c2l6ZSA+IDgpOwo+ICAKPiAtCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRl
dl9wcml2KTsKPiArCWZsYWdzID0gcmVnLT5vZmZzZXQgJiB+aTkxNV9tbWlvX3JlZ19vZmZzZXQo
ZW50cnktPm9mZnNldF9sZHcpOwo+ICAKPiAtCXN3aXRjaCAoc2l6ZSkgewo+IC0JY2FzZSA4IHwg
MToKPiAtCQlyZWctPnZhbCA9IEk5MTVfUkVBRDY0XzJ4MzIob2Zmc2V0X2xkdywgb2Zmc2V0X3Vk
dyk7Cj4gLQkJYnJlYWs7Cj4gKwlpbnRlbF9ydW50aW1lX3BtX2dldChkZXZfcHJpdik7Cj4gKwlz
d2l0Y2ggKGVudHJ5LT5zaXplKSB7Cj4gIAljYXNlIDg6Cj4gLQkJcmVnLT52YWwgPSBJOTE1X1JF
QUQ2NChvZmZzZXRfbGR3KTsKPiArCQlpZiAoZmxhZ3MgJiBJOTE1X1JFR19SRUFEXzhCX1dBKQo+
ICsJCQlyZWctPnZhbCA9IEk5MTVfUkVBRDY0XzJ4MzIoZW50cnktPm9mZnNldF9sZHcsCj4gKwkJ
CQkJCSAgICBlbnRyeS0+b2Zmc2V0X3Vkdyk7Cj4gKwkJZWxzZQo+ICsJCQlyZWctPnZhbCA9IEk5
MTVfUkVBRDY0KGVudHJ5LT5vZmZzZXRfbGR3KTsKPiAgCQlicmVhazsKPiAgCWNhc2UgNDoKPiAt
CQlyZWctPnZhbCA9IEk5MTVfUkVBRChvZmZzZXRfbGR3KTsKPiArCQlyZWctPnZhbCA9IEk5MTVf
UkVBRChlbnRyeS0+b2Zmc2V0X2xkdyk7Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIDI6Cj4gLQkJcmVn
LT52YWwgPSBJOTE1X1JFQUQxNihvZmZzZXRfbGR3KTsKPiArCQlyZWctPnZhbCA9IEk5MTVfUkVB
RDE2KGVudHJ5LT5vZmZzZXRfbGR3KTsKPiAgCQlicmVhazsKPiAgCWNhc2UgMToKPiAtCQlyZWct
PnZhbCA9IEk5MTVfUkVBRDgob2Zmc2V0X2xkdyk7Cj4gKwkJcmVnLT52YWwgPSBJOTE1X1JFQUQ4
KGVudHJ5LT5vZmZzZXRfbGR3KTsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gIAkJcmV0ID0g
LUVJTlZBTDsKPiAtCQlnb3RvIG91dDsKPiArCQlicmVhazsKPiAgCX0KPiAtCj4gLW91dDoKPiAg
CWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiArCj4gIAlyZXR1cm4gcmV0Owo+ICB9
Cj4gIAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvZHJtL2k5MTVfZHJtLmggYi9pbmNsdWRl
L3VhcGkvZHJtL2k5MTVfZHJtLmgKPiBpbmRleCBkOGQxMGQ5MzI3NTkuLmI0NTA1ZDU1OTkwZCAx
MDA2NDQKPiAtLS0gYS9pbmNsdWRlL3VhcGkvZHJtL2k5MTVfZHJtLmgKPiArKysgYi9pbmNsdWRl
L3VhcGkvZHJtL2k5MTVfZHJtLmgKPiBAQCAtMTMwOCwxNCArMTMwOCwxNiBAQCBzdHJ1Y3QgZHJt
X2k5MTVfcmVnX3JlYWQgewo+ICAJICogYmUgc3BlY2lmaWVkCj4gIAkgKi8KPiAgCV9fdTY0IG9m
ZnNldDsKPiArI2RlZmluZSBJOTE1X1JFR19SRUFEXzhCX1dBIEJJVCgwKQo+ICsKPiAgCV9fdTY0
IHZhbDsgLyogUmV0dXJuIHZhbHVlICovCj4gIH07Cj4gIC8qIEtub3duIHJlZ2lzdGVyczoKPiAg
ICoKPiAgICogUmVuZGVyIGVuZ2luZSB0aW1lc3RhbXAgLSAweDIzNTggKyA2NGJpdCAtIGdlbjcr
Cj4gICAqIC0gTm90ZSB0aGlzIHJlZ2lzdGVyIHJldHVybnMgYW4gaW52YWxpZCB2YWx1ZSBpZiB1
c2luZyB0aGUgZGVmYXVsdAo+IC0gKiAgIHNpbmdsZSBpbnN0cnVjdGlvbiA4Ynl0ZSByZWFkLCBp
biBvcmRlciB0byB3b3JrYXJvdW5kIHRoYXQgdXNlCj4gLSAqICAgb2Zmc2V0ICgweDI1MzggfCAx
KSBpbnN0ZWFkLgo+ICsgKiAgIHNpbmdsZSBpbnN0cnVjdGlvbiA4Ynl0ZSByZWFkLCBpbiBvcmRl
ciB0byB3b3JrYXJvdW5kIHRoYXQgcGFzcwo+ICsgKiAgIGZsYWcgSTkxNV9SRUdfUkVBRF84Ql9X
QSBpbiBvZmZzZXQgZmllbGQuCj4gICAqCj4gICAqLwo+ICAKPiAtLSAKPiAyLjEzLjUKPiAKPiBf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm
eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApW
aWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=