From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, rodrigo.vivi@intel.com
Subject: [maintainer-tools PATCH 2/5] dim: use git format-patch style for *** REMINDERS ***
Date: Fri, 8 Sep 2017 16:29:58 +0300 [thread overview]
Message-ID: <20170908133001.31224-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20170908133001.31224-1-jani.nikula@intel.com>
git format-patch adds *** SUBJECT HERE *** and similar to remind about
things that need to be filled in. Follow suit.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
dim | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/dim b/dim
index 6d889bd6a04d..248d12f3a8a4 100755
--- a/dim
+++ b/dim
@@ -887,9 +887,7 @@ function dim_backmerge
cat > $patch_file <<-HERE
Merge $upstream into $branch
- <Explain here why you've done the backmerge, e.g. which patches
- or which driver pull request you need to be able to merge
- \$feature_work from \$author.>
+ *** DETAILED BACKMERGE RATIONALE HERE ***
HERE
@@ -1426,7 +1424,7 @@ function prep_pull_mail_overview
local obj
if [ "$#" = "0" ]; then
- echo "*** insert pull request overview here ***"
+ echo "*** PULL REQUEST OVERVIEW HERE ***"
else
for tag in "$@"; do
obj=$(git rev-parse $tag)
@@ -1566,7 +1564,7 @@ function dim_update_next_continue
if [[ "$(git cat-file -t $obj)" == "tag" ]] ; then
git cat-file -p $obj | tail -n+6 >> $req_file
else
- echo "<tag doesn't contain a changelog overview, fix this>" >> $req_file
+ echo "*** CHANGELOG OVERVIEW HERE ***" >> $req_file
fi
cat >> $req_file <<-HERE
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-08 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 13:29 [maintainer-tools PATCH 1/5] dim: stop adding Daniel's signed-off-by to driver date updates Jani Nikula
2017-09-08 13:29 ` Jani Nikula [this message]
2017-09-08 13:29 ` [maintainer-tools PATCH 3/5] dim: remove defaults from pull mail hello/signature Jani Nikula
2017-09-08 23:52 ` Vivi, Rodrigo
2017-09-11 8:50 ` Jani Nikula
2017-09-08 13:30 ` [maintainer-tools PATCH 4/5] dim: reuse pull request signature for drm-intel-testing mails Jani Nikula
2017-09-08 13:30 ` [maintainer-tools PATCH 5/5] dim: update pull and test request recipients Jani Nikula
2017-09-08 13:55 ` Sean Paul
2017-09-11 8:48 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908133001.31224-2-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox