public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Harry Wentland <harry.wentland@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/dp/mst: Sideband message transaction to power up/down nodes
Date: Mon, 11 Sep 2017 16:33:01 +0300	[thread overview]
Message-ID: <20170911133301.GM4914@intel.com> (raw)
In-Reply-To: <20170907001458.9399-1-dhinakaran.pandiyan@intel.com>

On Wed, Sep 06, 2017 at 05:14:58PM -0700, Dhinakaran Pandiyan wrote:
> The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions allow
> the source to reqest any node in a mst path or a whole path to be
> powered down or up. This allows drivers to target a specific sink in the
> MST topology, an improvement over just power managing the imediate
> downstream device. Secondly, since the request-reply protocol waits for an
> ACK, we can be sure that a downstream sink has enough time to respond to a
> power up/down request.

I was a bit worried how this handles multiple streams going through
the same MST device, but looks like the spec has accounted for this
by having the device skip the D3 if any active streams are present.

I guess that also means we have to do this after we've turned off the
stream, assuming we want things actually reach D3. Looks like that does
match our current order of things.

Pushed this one to drm-misc-next. Thanks for the patch and review.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-09-11 13:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06  1:26 [PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes Dhinakaran Pandiyan
2017-09-06  1:26 ` [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms Dhinakaran Pandiyan
2017-09-07  5:51   ` Stefan Assmann
2017-09-12 16:11   ` Ville Syrjälä
2017-09-12 16:17     ` Ville Syrjälä
2017-09-12 19:08       ` Pandiyan, Dhinakaran
2017-09-12 20:11         ` Pandiyan, Dhinakaran
2017-09-13  7:32           ` Maarten Lankhorst
2017-09-13 10:37             ` [Intel-gfx] " Ville Syrjälä
2017-09-13 10:46               ` Maarten Lankhorst
2017-09-13 11:48                 ` Ville Syrjälä
2017-09-13 11:55                   ` Maarten Lankhorst
2017-09-13 13:52                     ` Ville Syrjälä
2017-09-06  1:46 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/dp/mst: Sideband message transaction to power up/down nodes Patchwork
2017-09-06 15:40 ` [PATCH 1/2] " Lyude Paul
2017-09-06 16:36   ` Pandiyan, Dhinakaran
2017-09-07  0:14   ` [PATCH v2] " Dhinakaran Pandiyan
2017-09-07 18:04     ` Lyude Paul
2017-09-07 18:54       ` [Intel-gfx] " Pandiyan, Dhinakaran
2017-09-11 13:33     ` Ville Syrjälä [this message]
2017-09-11 19:10       ` Pandiyan, Dhinakaran
2017-09-07  0:35 ` ✗ Fi.CI.BAT: failure for series starting with [v2] drm/dp/mst: Sideband message transaction to power up/down nodes (rev2) Patchwork
2017-09-07  5:49 ` [PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes Stefan Assmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911133301.GM4914@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox