From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms Date: Tue, 12 Sep 2017 19:11:32 +0300 Message-ID: <20170912161132.GY4914@intel.com> References: <20170906012634.3975-1-dhinakaran.pandiyan@intel.com> <20170906012634.3975-2-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170906012634.3975-2-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDUsIDIwMTcgYXQgMDY6MjY6MzRQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBVc2UgdGhlIFBPV0VSX0RPV05fUEhZIGFuZCBQT1dFUl9VUF9QSFkgc2lk ZWJhbmQgbWVzc2FnZSB0cmFzYWN0aW9ucyB0bwo+IHNldCBwb3dlciBzdGF0ZXMgZm9yIGRvd25z dHJlYW0gc2lua3MuIEFwYXJ0IGZyb20gZ2l2aW5nIHVzIHRoZSBhYmlsaXR5Cj4gdG8gc2V0IHBv d2VyIHN0YXRlIGZvciBpbmRpdmlkdWFsIHNpbmtzLCB0aGlzIGZpeGVzIHRoZSBiZWxvdyB0ZXN0 IGZvcgo+IG1lCj4gCj4gJCB4cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0IERQLTItMi04IC0t b2ZmCj4gJCB4cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0IERQLTItMi0xIC0tb2ZmCj4gJCB4 cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0IERQLTItMi04IC0tYXV0byAjQmxhY2sgc2NyZWVu Cj4gJCB4cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0IERQLTItMi0xIC0tYXV0bwo+IAo+IENj OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBM eXVkZSA8bHl1ZGVAcmVkaGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGRpLmMgICAgfCA2ICsrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcF9tc3QuYyB8IDggKysrKy0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBp bmRleCAxZGEzYmIyY2M0YjQuLjhhZWJhY2MwYWEzMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RkaS5jCj4gQEAgLTIxNjEsNyArMjE2MSw4IEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVf ZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCWludGVsX3ByZXBh cmVfZHBfZGRpX2J1ZmZlcnMoZW5jb2Rlcik7Cj4gIAo+ICAJaW50ZWxfZGRpX2luaXRfZHBfYnVm X3JlZyhlbmNvZGVyKTsKPiAtCWludGVsX2RwX3NpbmtfZHBtcyhpbnRlbF9kcCwgRFJNX01PREVf RFBNU19PTik7Cj4gKwlpZiAoIWxpbmtfbXN0KQo+ICsJCWludGVsX2RwX3NpbmtfZHBtcyhpbnRl bF9kcCwgRFJNX01PREVfRFBNU19PTik7Cj4gIAlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGlu dGVsX2RwKTsKPiAgCWlmIChwb3J0ICE9IFBPUlRfQSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49 IDkpCj4gIAkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiBAQCAtMjI0MCw3 ICsyMjQxLDggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3Bvc3RfZGlzYWJsZShzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciwKPiAgCWlmICh0eXBlID09IElOVEVMX09VVFBVVF9E UCB8fCB0eXBlID09IElOVEVMX09VVFBVVF9FRFApIHsKPiAgCQlzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKGVuY29kZXIpOwo+ICAKPiAtCQlpbnRlbF9kcF9zaW5r X2RwbXMoaW50ZWxfZHAsIERSTV9NT0RFX0RQTVNfT0ZGKTsKPiArCQlpZiAob2xkX2NydGNfc3Rh dGUgJiYgb2xkX2Nvbm5fc3RhdGUpCj4gKwkJCWludGVsX2RwX3NpbmtfZHBtcyhpbnRlbF9kcCwg RFJNX01PREVfRFBNU19PRkYpOwoKSSB3b3VsZCBtYWtlIHRoYXQKIWludGVsX2NydGNfaGFzX3R5 cGUoRFBfTVNUKQoKPiAgCX0KPiAgCj4gIAl2YWwgPSBJOTE1X1JFQUQoRERJX0JVRl9DVEwocG9y dCkpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gaW5kZXggOGUzYWFkMGVhNjBi Li44MWU2MzcyNGUyNGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBfbXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+IEBA IC0xNjcsMTIgKzE2NywxMSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tc3RfcG9zdF9kaXNhYmxlX2Rw KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJaW50ZWxfZHAtPmFjdGl2ZV9tc3Rf bGlua3MtLTsKPiAgCj4gIAlpbnRlbF9tc3QtPmNvbm5lY3RvciA9IE5VTEw7Cj4gLQlpZiAoaW50 ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgPT0gMCkgewo+ICsJaWYgKGludGVsX2RwLT5hY3RpdmVf bXN0X2xpbmtzID09IDApCj4gIAkJaW50ZWxfZGlnX3BvcnQtPmJhc2UucG9zdF9kaXNhYmxlKCZp bnRlbF9kaWdfcG9ydC0+YmFzZSwKPiAgCQkJCQkJICBOVUxMLCBOVUxMKTsKPiAtCj4gLQkJaW50 ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4gLQl9Cj4gKwlk cm1fZHBfc2VuZF9wb3dlcl91cGRvd25fcGh5KCZpbnRlbF9kcC0+bXN0X21nciwgY29ubmVjdG9y LT5wb3J0LAo+ICsJCQkJICAgICBmYWxzZSk7CgpPbmUgdGhpbmcgdGhhdCBib3RoZXJzIG1lIGhl cmUgaXMgd2hldGhlciB3ZSdsbCBzdGFydCBnZXR0aW5nIGJvZ3VzIGxpbmsKdHJhaW5pbmcgcmVx dWVzdHMgZHVyaW5nIHNodXRkb3duIHNpbmNlIHdlJ2xsIGRvIHRoZSBEMyBvbmx5IGFmdGVyIHRo ZQpzdHJlYW0gaGFzIGJlZW4gc3RvcHBlZC4gSWYgeW91J2xsIGxvb2sgYXQgY29tbWl0IDc2MTgx MzhkOGI0MAooImRybS9pOTE1L2RkaTogQXZvaWQgbG9uZyBkZWxheXMgZHVyaW5nIHN5c3RlbSBz dXNwZW5kIC8gZURQCmRpc2FibGluZyIpIEltcmUgZXhwbGljaXRseSBtb3ZlZCB0aGUgRDMgZWFy bGllciBmb3IgU1NUIHRvIGF2b2lkIHRoaXMuCgpIbW0uIEFjdHVhbGx5IGJ5IHRoZSB0aW1lIHdl IGNhbGwgbXN0X3Bvc3RfZGlzYWJsZSgpIHdlIHNob3VsZCBoYXZlCmRlYWxsb2NhdGVkIHRoZSBW QyBldGMuIHNvIHRoZSBjdXJyZW50IHN0cmVhbSBzaG91bGQgYmUgYWxyZWFkeQp0ZXJtaW5hdGVk IGF0IHRoYXQgcG9pbnQuIFNvIEkgdGhpbmsgd2Ugc2hvdWxkIGJlIGFibGUgdG8gZG8gdGhlClBI WV9QT1dFUl9ET1dOIGJlZm9yZSB3ZSBzaHV0IGRvd24gdGhlIGxpbmssIGp1c3QgbGlrZSB3ZSBk byBmb3IgU1NULgoKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfbXN0X3ByZV9lbmFibGVf ZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gQEAgLTE5Nyw2ICsxOTYsNyBAQCBz dGF0aWMgdm9pZCBpbnRlbF9tc3RfcHJlX2VuYWJsZV9kcChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlciwKPiAgCj4gIAlEUk1fREVCVUdfS01TKCIlZFxuIiwgaW50ZWxfZHAtPmFjdGl2ZV9t c3RfbGlua3MpOwo+ICAKPiArCWRybV9kcF9zZW5kX3Bvd2VyX3VwZG93bl9waHkoJmludGVsX2Rw LT5tc3RfbWdyLCBjb25uZWN0b3ItPnBvcnQsIHRydWUpOwo+ICAJaWYgKGludGVsX2RwLT5hY3Rp dmVfbXN0X2xpbmtzID09IDApCj4gIAkJaW50ZWxfZGlnX3BvcnQtPmJhc2UucHJlX2VuYWJsZSgm aW50ZWxfZGlnX3BvcnQtPmJhc2UsCj4gIAkJCQkJCXBpcGVfY29uZmlnLCBOVUxMKTsKPiAtLSAK PiAyLjExLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=