From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Name the IPS_PCODE_CONTROL bit
Date: Tue, 12 Sep 2017 19:41:03 +0300 [thread overview]
Message-ID: <20170912164103.GA4914@intel.com> (raw)
In-Reply-To: <150523386911.15081.16533690969147138463@mail.alporthouse.com>
On Tue, Sep 12, 2017 at 05:31:09PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-09-12 16:34:11)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Give a name to the bit which tells pcode to control IPS.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 1 +
> > drivers/gpu/drm/i915/intel_display.c | 3 ++-
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index f9f9fcc833c5..91d5a8cbe79d 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -7974,6 +7974,7 @@ enum {
> > #define GEN6_PCODE_WRITE_D_COMP 0x11
> > #define HSW_PCODE_DE_WRITE_FREQ_REQ 0x17
> > #define DISPLAY_IPS_CONTROL 0x19
>
> /* See also IPS_CTL */
Seems like a decent idea.
> ?
>
> > +#define IPS_PCODE_CONTROL (1 << 30)
> > #define HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL 0x1A
> > #define GEN9_PCODE_SAGV_CONTROL 0x21
> > #define GEN9_SAGV_DISABLE 0x0
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 0871807850a9..524217d6292e 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -4956,7 +4956,8 @@ void hsw_enable_ips(struct intel_crtc *crtc)
> > assert_plane_enabled(dev_priv, crtc->plane);
> > if (IS_BROADWELL(dev_priv)) {
> > mutex_lock(&dev_priv->rps.hw_lock);
> > - WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0xc0000000));
> > + WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL,
> > + IPS_ENABLE | IPS_PCODE_CONTROL));
>
> Numbers match up, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-12 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:34 [PATCH 1/2] drm/i915: Nuke some bogus tabs from the pcode defines Ville Syrjala
2017-09-12 15:34 ` [PATCH 2/2] drm/i915: Name the IPS_PCODE_CONTROL bit Ville Syrjala
2017-09-12 16:31 ` Chris Wilson
2017-09-12 16:41 ` Ville Syrjälä [this message]
2017-09-12 16:16 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Nuke some bogus tabs from the pcode defines Patchwork
2017-09-12 16:29 ` [PATCH 1/2] " Chris Wilson
2017-09-12 21:15 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912164103.GA4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox