From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915: dspaddr_offset doesn't need to be more than local variable Date: Tue, 12 Sep 2017 20:48:03 +0300 Message-ID: <20170912174803.GC4914@intel.com> References: <1505207980-18439-1-git-send-email-juhapekka.heikkila@gmail.com> <1505207980-18439-2-git-send-email-juhapekka.heikkila@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E3E36E6F6 for ; Tue, 12 Sep 2017 17:48:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1505207980-18439-2-git-send-email-juhapekka.heikkila@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Juha-Pekka Heikkila Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTIsIDIwMTcgYXQgMTI6MTk6MzhQTSArMDMwMCwgSnVoYS1QZWtrYSBIZWlr a2lsYSB3cm90ZToKPiBNb3ZlIHUzMiBkc3BhZGRyX29mZnNldCBmcm9tIHN0cnVjdCBpbnRlbF9j cnRjIG1lbWJlciBpbnRvIGxvY2FsCj4gdmFyaWFibGUgaW4gaTl4eF91cGRhdGVfcHJpbWFyeV9w bGFuZSgpCgpZb3UgZmFpbCB0byB1cGRhdGUgdGhlIHNrbCBmdW5jdGlvbiwgc28gdGhpcyB3b24n dCBidWlsZC4gUGxlYXNlIG1ha2UKc3VyZSBlYWNoIHN0ZXAgaW4gdGhlIHNlcmllcyBidWlsZHMg KGFuZCBpZGVhbGx5IGFsc28gd29ya3MpLiBUaGF0IHdheQpwZW9wbGUgY2FuIGFjdHVhbGx5IGJp c2VjdCB0aHJvdWdoIHRoZSBzZXJpZXMuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEp1aGEtUGVra2Eg SGVpa2tpbGEgPGp1aGFwZWtrYS5oZWlra2lsYUBnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDExICsrKysrKy0tLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAxIC0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA2 IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IDA4NzE4MDcuLjBkZDBlMmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTMzMDcsMTMgKzMzMDcsMTQgQEAgc3RhdGljIHZvaWQg aTl4eF91cGRhdGVfcHJpbWFyeV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnByaW1hcnksCj4g IAlpbnQgeCA9IHBsYW5lX3N0YXRlLT5tYWluLng7Cj4gIAlpbnQgeSA9IHBsYW5lX3N0YXRlLT5t YWluLnk7Cj4gIAl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ICsJdTMyIGRzcGFkZHJfb2Zmc2V0 Owo+ICAKPiAgCWxpbmVhcl9vZmZzZXQgPSBpbnRlbF9mYl94eV90b19saW5lYXIoeCwgeSwgcGxh bmVfc3RhdGUsIDApOwo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDQpCj4gLQkJ Y3J0Yy0+ZHNwYWRkcl9vZmZzZXQgPSBwbGFuZV9zdGF0ZS0+bWFpbi5vZmZzZXQ7Cj4gKwkJZHNw YWRkcl9vZmZzZXQgPSBwbGFuZV9zdGF0ZS0+bWFpbi5vZmZzZXQ7Cj4gIAllbHNlCj4gLQkJY3J0 Yy0+ZHNwYWRkcl9vZmZzZXQgPSBsaW5lYXJfb2Zmc2V0Owo+ICsJCWRzcGFkZHJfb2Zmc2V0ID0g bGluZWFyX29mZnNldDsKPiAgCj4gIAljcnRjLT5hZGp1c3RlZF94ID0geDsKPiAgCWNydGMtPmFk anVzdGVkX3kgPSB5Owo+IEBAIC0zMzQyLDE4ICszMzQzLDE4IEBAIHN0YXRpYyB2b2lkIGk5eHhf dXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwcmltYXJ5LAo+ICAJaWYg KElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiAgCQlJ OTE1X1dSSVRFX0ZXKERTUFNVUkYocGxhbmUpLAo+ICAJCQkgICAgICBpbnRlbF9wbGFuZV9nZ3R0 X29mZnNldChwbGFuZV9zdGF0ZSkgKwo+IC0JCQkgICAgICBjcnRjLT5kc3BhZGRyX29mZnNldCk7 Cj4gKwkJCSAgICAgIGRzcGFkZHJfb2Zmc2V0KTsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUE9GRlNF VChwbGFuZSksICh5IDw8IDE2KSB8IHgpOwo+ICAJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3By aXYpID49IDQpIHsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUFNVUkYocGxhbmUpLAo+ICAJCQkgICAg ICBpbnRlbF9wbGFuZV9nZ3R0X29mZnNldChwbGFuZV9zdGF0ZSkgKwo+IC0JCQkgICAgICBjcnRj LT5kc3BhZGRyX29mZnNldCk7Cj4gKwkJCSAgICAgIGRzcGFkZHJfb2Zmc2V0KTsKPiAgCQlJOTE1 X1dSSVRFX0ZXKERTUFRJTEVPRkYocGxhbmUpLCAoeSA8PCAxNikgfCB4KTsKPiAgCQlJOTE1X1dS SVRFX0ZXKERTUExJTk9GRihwbGFuZSksIGxpbmVhcl9vZmZzZXQpOwo+ICAJfSBlbHNlIHsKPiAg CQlJOTE1X1dSSVRFX0ZXKERTUEFERFIocGxhbmUpLAo+ICAJCQkgICAgICBpbnRlbF9wbGFuZV9n Z3R0X29mZnNldChwbGFuZV9zdGF0ZSkgKwo+IC0JCQkgICAgICBjcnRjLT5kc3BhZGRyX29mZnNl dCk7Cj4gKwkJCSAgICAgIGRzcGFkZHJfb2Zmc2V0KTsKPiAgCX0KPiAgCVBPU1RJTkdfUkVBRF9G VyhyZWcpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDMwNzgwNzYuLmQ1 OGNkMTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC04MDYsNyArODA2LDYg QEAgc3RydWN0IGludGVsX2NydGMgewo+ICAJLyogRGlzcGxheSBzdXJmYWNlIGJhc2UgYWRkcmVz cyBhZGp1c3RlbWVudCBmb3IgcGFnZWZsaXBzLiBOb3RlIHRoYXQgb24KPiAgCSAqIGdlbjQrIHRo aXMgb25seSBhZGp1c3RzIHVwIHRvIGEgdGlsZSwgb2Zmc2V0cyB3aXRoaW4gYSB0aWxlIGFyZQo+ ICAJICogaGFuZGxlZCBpbiB0aGUgaHcgaXRzZWxmICh3aXRoIHRoZSBUSUxFT0ZGIHJlZ2lzdGVy KS4gKi8KPiAtCXUzMiBkc3BhZGRyX29mZnNldDsKPiAgCWludCBhZGp1c3RlZF94Owo+ICAJaW50 IGFkanVzdGVkX3k7Cj4gIAo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK