From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/9] drm/i915/dp: Avoid more dpcd transactions after resume failure
Date: Wed, 13 Sep 2017 16:24:10 +0300 [thread overview]
Message-ID: <20170913132410.GK4914@intel.com> (raw)
In-Reply-To: <20170912235730.3492-4-dhinakaran.pandiyan@intel.com>
On Tue, Sep 12, 2017 at 04:57:25PM -0700, Dhinakaran Pandiyan wrote:
> drm_dp_mst_topology_mgr_resume() fails if there are dpcd failures, so
> there's no need to try that again in _check_mst_status()
That commit message somehow doesn't seem to match this patch. You're not
removing anything from _check_mst_status() here.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 98e7b96ca826..b3d95cb7546b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -6224,12 +6224,16 @@ void intel_dp_mst_resume(struct drm_device *dev)
> for (i = 0; i < I915_MAX_PORTS; i++) {
> struct intel_digital_port *intel_dig_port = dev_priv->hotplug.irq_port[i];
> int ret;
> + struct intel_dp *intel_dp = &intel_dig_port->dp;
>
> - if (!intel_dig_port || !intel_dig_port->dp.can_mst)
> + if (!intel_dig_port || !intel_dp->can_mst)
> continue;
>
> - ret = drm_dp_mst_topology_mgr_resume(&intel_dig_port->dp.mst_mgr);
> - if (ret)
> - intel_dp_check_mst_status(&intel_dig_port->dp);
> + ret = drm_dp_mst_topology_mgr_resume(&intel_dp->mst_mgr);
> + if (ret) {
> + intel_dp->is_mst = false;
> + drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, intel_dp->is_mst);
> + drm_kms_helper_hotplug_event(dev);
> + }
> }
> }
> --
> 2.11.0
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 13:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 23:57 [PATCH 1/9] drm/i915/mst: Debug log connector name in destroy_connector() Dhinakaran Pandiyan
2017-09-12 23:57 ` [PATCH 2/9] drm/i915/mst: Print active mst links after update Dhinakaran Pandiyan
2017-09-14 20:58 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 3/9] drm/i915/dp: Fix buffer size for sink_irq_esi read Dhinakaran Pandiyan
2017-09-14 21:10 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 4/9] drm/i915/dp: Avoid more dpcd transactions after resume failure Dhinakaran Pandiyan
2017-09-13 13:24 ` Ville Syrjälä [this message]
2017-09-13 20:21 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Dhinakaran Pandiyan
2017-09-13 9:32 ` Jani Nikula
2017-09-13 20:13 ` Pandiyan, Dhinakaran
2017-09-13 13:31 ` Ville Syrjälä
2017-09-13 20:33 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 6/9] drm/i915/dp: Handle check_mst_status() failure in one place Dhinakaran Pandiyan
2017-09-14 21:32 ` Ausmus, James
2017-09-14 21:52 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 7/9] drm/i915/dp: Avoid double-printing esi regs Dhinakaran Pandiyan
2017-09-14 20:42 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 8/9] drm/i915/dp: Protect link training with connection mutex Dhinakaran Pandiyan
2017-09-14 22:26 ` Ausmus, James
2017-09-15 18:16 ` Pandiyan, Dhinakaran
2017-09-15 18:38 ` Manasi Navare
2017-09-15 18:57 ` Ausmus, James
2017-09-15 10:10 ` Ville Syrjälä
2017-09-18 21:50 ` Pandiyan, Dhinakaran
2017-09-19 12:42 ` Ville Syrjälä
2017-09-19 19:21 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 9/9] drm/i915/dp: Remove redundant can_mst checks in intel_dp_configure_mst() Dhinakaran Pandiyan
2017-09-14 22:36 ` Ausmus, James
2017-09-15 18:29 ` Pandiyan, Dhinakaran
2017-09-13 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/9] drm/i915/mst: Debug log connector name in destroy_connector() Patchwork
2017-09-14 0:20 ` [PATCH 1/9] " Ausmus, James
2017-09-14 19:22 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913132410.GK4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox