From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Date: Wed, 13 Sep 2017 16:31:57 +0300 Message-ID: <20170913133157.GL4914@intel.com> References: <20170912235730.3492-1-dhinakaran.pandiyan@intel.com> <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AA506E0F0 for ; Wed, 13 Sep 2017 13:32:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTIsIDIwMTcgYXQgMDQ6NTc6MjZQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBUaGVyZSBpcyBqdXN0IG9ubHkgb25lIGNhbGxlciBub3csIHdoaWNoIGFs cmVhZHkgY2hlY2tzIGZvcgo+IGludGVsX2RwLT5pc19tc3QuIFNvLCByZW1vdmUgdGhpcyBhbmQg Zml4IHNvbWUgYnJhY2VzIHdoaWxlIGF0IGl0LgoKSG1tLiBTbyB0aGlzIGRlcGVuZHMgb24gdGhl IHN1YnRsZSBkZXRhaWwgdGhhdApkcm1fZHBfbXN0X3RvcG9sb2d5X21ncl9yZXN1bWUoKSB3aWxs ICJmYWlsIiBpZiBkaWRuJ3QgZW5hYmxlIG1zdApwcmlvciB0byBjYWxsaW5nIGl0LiBUaGF0IGZh Y3QgaXNuJ3Qgb2J2aW91cyBhdCBhbGwsIHNvIEkgd291bGQKc3VnZ2VzdCBub3RpbmcgdGhhdCBp biB0aGUgY29tbWl0IG1lc3NhZ2UgYXQgbGVhc3QgKG1heWJlIHdlIHNob3VsZApldmVuIGhhdmUg YSBjb21tZW50IGluIHRoZSBjb2RlPykKCkknbSBhc3N1bWluZyB0aGVyZSBhcmUgbm90IG90aGVy IGNoYW5nZXMgYmV5b25kIGp1c3QgZHJvcHBpbmcgdGhlCnRvcCBsZXZlbCAnaWYgKG1zdCkgeyB9 JyB0aGluZz8gVGhpcyBpcyBvbmUgcmVhc29uIEkgcHJlZmVyIGZsYXQgY29kZS4KSWYgdGhlIGZ1 bmN0aW9uIGhhZCBiZWVuIGZsYXQgdG8gYmVnaW4gd2l0aCB0aGUgZGlmZiB3b3VsZCBoYXZlCmFj dHVhbGx5IHR1cm5lZCBvdXQgbGVnaWJsZS4gSUlSQyBJIGV2ZW4gcG9zdGVkIGEgZmxhdHRlbmlu ZyBwYXRjaCBhdApzb21lIHBvaW50IGJ1dCBJIGd1ZXNzIGl0IGRpZG4ndCBnbyBpbi4gSSB3b3Vs ZCBzdWdnZXN0IHRoYXQgeW91IHRha2UKdGhlIG9wcG9ydHVuaXR5IHRvIGZsYXR0ZW4gb3V0IHRo ZSByZXN0IG9mIHRoaXMgZnVuY3Rpb24gd2hpbGUgeW91CmluIHRoZSBuZWlnaGJvdXJob29kLgoK PiAKPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRp eWFuQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8 IDg1ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiBpbmRleCBiM2Q5NWNiNzU0NmIuLjNmMmNhMTBjY2JjZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC00MTkyLDU3ICs0MTkyLDU2IEBAIHN0YXRpYyBpbnQK PiAgaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ ICB7Cj4gIAlib29sIGJyZXQ7Cj4gKwl1OCBlc2lbRFBfRFBSWF9FU0lfTEVOXSA9IHsgMCB9Owo+ ICsJaW50IHJldCA9IDA7Cj4gKwlpbnQgcmV0cnk7Cj4gKwlib29sIGhhbmRsZWQ7Cj4gIAo+IC0J aWYgKGludGVsX2RwLT5pc19tc3QpIHsKPiAtCQl1OCBlc2lbRFBfRFBSWF9FU0lfTEVOXSA9IHsg MCB9Owo+IC0JCWludCByZXQgPSAwOwo+IC0JCWludCByZXRyeTsKPiAtCQlib29sIGhhbmRsZWQ7 Cj4gLQkJYnJldCA9IGludGVsX2RwX2dldF9zaW5rX2lycV9lc2koaW50ZWxfZHAsIGVzaSk7Cj4g KwlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRlbF9kcCwgZXNpKTsKPiAgZ29f YWdhaW46Cj4gLQkJaWYgKGJyZXQgPT0gdHJ1ZSkgewo+IC0KPiAtCQkJLyogY2hlY2sgbGluayBz dGF0dXMgLSBlc2lbMTBdID0gMHgyMDBjICovCj4gLQkJCWlmIChpbnRlbF9kcC0+YWN0aXZlX21z dF9saW5rcyAmJgo+IC0JCQkgICAgIWRybV9kcF9jaGFubmVsX2VxX29rKCZlc2lbMTBdLCBpbnRl bF9kcC0+bGFuZV9jb3VudCkpIHsKPiAtCQkJCURSTV9ERUJVR19LTVMoImNoYW5uZWwgRVEgbm90 IG9rLCByZXRyYWluaW5nXG4iKTsKPiAtCQkJCWludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oaW50 ZWxfZHApOwo+IC0JCQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiAtCQkJ fQo+ICsJaWYgKGJyZXQgPT0gdHJ1ZSkgewo+ICsKPiArCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAt IGVzaVsxMF0gPSAweDIwMGMgKi8KPiArCQlpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3Mg JiYKPiArCQkgICAgIWRybV9kcF9jaGFubmVsX2VxX29rKCZlc2lbMTBdLCBpbnRlbF9kcC0+bGFu ZV9jb3VudCkpIHsKPiArCQkJRFJNX0RFQlVHX0tNUygiY2hhbm5lbCBFUSBub3Qgb2ssIHJldHJh aW5pbmdcbiIpOwo+ICsJCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVsX2RwKTsKPiAr CQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiArCQl9Cj4gIAo+IC0JCQlE Uk1fREVCVUdfS01TKCJnb3QgZXNpICUzcGhcbiIsIGVzaSk7Cj4gLQkJCXJldCA9IGRybV9kcF9t c3RfaHBkX2lycSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGVzaSwgJmhhbmRsZWQpOwo+IC0KPiAtCQkJ aWYgKGhhbmRsZWQpIHsKPiAtCQkJCWZvciAocmV0cnkgPSAwOyByZXRyeSA8IDM7IHJldHJ5Kysp IHsKPiAtCQkJCQlpbnQgd3JldDsKPiAtCQkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUoJmlu dGVsX2RwLT5hdXgsCj4gLQkJCQkJCQkJIERQX1NJTktfQ09VTlRfRVNJKzEsCj4gLQkJCQkJCQkJ ICZlc2lbMV0sIDMpOwo+IC0JCQkJCWlmICh3cmV0ID09IDMpIHsKPiAtCQkJCQkJYnJlYWs7Cj4g LQkJCQkJfQo+IC0JCQkJfQo+ICsJCURSTV9ERUJVR19LTVMoImdvdCBlc2kgJTNwaFxuIiwgZXNp KTsKPiArCQlyZXQgPSBkcm1fZHBfbXN0X2hwZF9pcnEoJmludGVsX2RwLT5tc3RfbWdyLCBlc2ks ICZoYW5kbGVkKTsKPiAgCj4gLQkJCQlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShp bnRlbF9kcCwgZXNpKTsKPiAtCQkJCWlmIChicmV0ID09IHRydWUpIHsKPiAtCQkJCQlEUk1fREVC VUdfS01TKCJnb3QgZXNpMiAlM3BoXG4iLCBlc2kpOwo+IC0JCQkJCWdvdG8gZ29fYWdhaW47Cj4g LQkJCQl9Cj4gLQkJCX0gZWxzZQo+IC0JCQkJcmV0ID0gMDsKPiArCQlpZiAoaGFuZGxlZCkgewo+ ICsJCQlmb3IgKHJldHJ5ID0gMDsgcmV0cnkgPCAzOyByZXRyeSsrKSB7Cj4gKwkJCQlpbnQgd3Jl dDsKPiAgCj4gLQkJCXJldHVybiByZXQ7Cj4gKwkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUo JmludGVsX2RwLT5hdXgsCj4gKwkJCQkJCQkgRFBfU0lOS19DT1VOVF9FU0krMSwKPiArCQkJCQkJ CSAmZXNpWzFdLCAzKTsKPiArCQkJCWlmICh3cmV0ID09IDMpCj4gKwkJCQkJYnJlYWs7Cj4gKwkJ CX0KPiArCj4gKwkJCWJyZXQgPSBpbnRlbF9kcF9nZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBl c2kpOwo+ICsJCQlpZiAoYnJldCA9PSB0cnVlKSB7Cj4gKwkJCQlEUk1fREVCVUdfS01TKCJnb3Qg ZXNpMiAlM3BoXG4iLCBlc2kpOwo+ICsJCQkJZ290byBnb19hZ2FpbjsKPiArCQkJfQo+ICAJCX0g ZWxzZSB7Cj4gLQkJCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0g ZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+IC0JCQlEUk1fREVCVUdfS01TKCJmYWlsZWQgdG8g Z2V0IEVTSSAtIGRldmljZSBtYXkgaGF2ZSBmYWlsZWRcbiIpOwo+IC0JCQlpbnRlbF9kcC0+aXNf bXN0ID0gZmFsc2U7Cj4gLQkJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVs X2RwLT5tc3RfbWdyLCBpbnRlbF9kcC0+aXNfbXN0KTsKPiAtCQkJLyogc2VuZCBhIGhvdHBsdWcg ZXZlbnQgKi8KPiAtCQkJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChpbnRlbF9kaWdfcG9y dC0+YmFzZS5iYXNlLmRldik7Cj4gKwkJCXJldCA9IDA7Cj4gIAkJfQo+ICsJfSBlbHNlIHsKPiAr CQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19w b3J0KGludGVsX2RwKTsKPiArCj4gKwkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGdldCBFU0kg LSBkZXZpY2UgbWF5IGhhdmUgZmFpbGVkXG4iKTsKPiArCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFs c2U7Cj4gKwkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9t Z3IsCj4gKwkJCQkJCWludGVsX2RwLT5pc19tc3QpOwo+ICsJCWRybV9rbXNfaGVscGVyX2hvdHBs dWdfZXZlbnQoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ICsJCXJldCA9IC1FSU5W QUw7Cj4gIAl9Cj4gLQlyZXR1cm4gLUVJTlZBTDsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkCj4gLS0gCj4gMi4xMS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9U QwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK