From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit Date: Wed, 13 Sep 2017 17:03:16 +0300 Message-ID: <20170913140316.GO4914@intel.com> References: <20170913092554.22976-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ECFD6E0D1 for ; Wed, 13 Sep 2017 14:03:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170913092554.22976-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMTMsIDIwMTcgYXQgMTE6MjU6NTRBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQ29tbWl0IGI0NGQ1YzBjMTA1YSAoImRybS9pOTE1OiBBbHdheXMgd2FpdCBm b3IgZmxpcF9kb25lLCB2Mi4iKSByZW1vdmVkCj4gdGhlIGNhbGwgdG8gd2FpdF9mb3JfdmJsYW5r cyBhbmQgcmVwbGFjZWQgaXQgd2l0aCBmbGlwX2RvbmUuCj4gCj4gVW5mb3J0dW5hdGVseSBsZWdh Y3lfY3Vyc29yX3VwZGF0ZSB3YXMgdW5zZXQgdG9vIGxhdGUsIGFuZCB0aGUKPiByZXBsYWNlbWVu dCBjYWxsIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIHdhcwo+IGEgbm9v cC4gTWFrZSBzdXJlIHRoYXQgaXRzIHVuc2V0IGJlZm9yZSBzZXR1cF9jb21taXQoKSBpcwo+IGNh bGxlZCB0byBmaXggdGhpcyBpc3N1ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmto b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IEZpeGVzOiBiNDRkNWMw YzEwNWEgKCJkcm0vaTkxNTogQWx3YXlzIHdhaXQgZm9yIGZsaXBfZG9uZSwgdjIuIikKPiBCdWd6 aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjc1 Cj4gVGVzdGNhc2U6IGttc19jdXJzb3JfY3JjCj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRl bC5jb20+Cj4gUmVwb3J0ZWQtYnk6IE1hcnRhIEzDtmZzdGVkdCA8bWFydGEubG9mc3RlZHRAaW50 ZWwuY29tPgo+IENjOiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDQgKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNl cnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gaW5kZXggYmE3NmIyZGI5MzljLi5jMWRhNDhkNzdjOGUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyNDEyLDIzICsxMjQxMiwxNCBAQCBzdGF0 aWMgaW50IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgewo+ ICAJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPSB0b19pbnRlbF9hdG9t aWNfc3RhdGUoc3RhdGUpOwo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g dG9faTkxNShkZXYpOwo+IC0JaW50IHJldCA9IDA7Cj4gLQo+IC0JcmV0ID0gZHJtX2F0b21pY19o ZWxwZXJfc2V0dXBfY29tbWl0KHN0YXRlLCBub25ibG9jayk7Cj4gLQlpZiAocmV0KQo+IC0JCXJl dHVybiByZXQ7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlOwo+ICsJ c3RydWN0IGRybV9jcnRjICpjcnRjOwoKSSdkIHByZWZlciB0byBzZWUgaW50ZWxfIHR5cGVzLgoK PiArCWludCBpLCByZXQgPSAwOwo+ICAKPiAgCWRybV9hdG9taWNfc3RhdGVfZ2V0KHN0YXRlKTsK PiAgCWk5MTVfc3dfZmVuY2VfaW5pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSwKPiAgCQkJ ICAgaW50ZWxfYXRvbWljX2NvbW1pdF9yZWFkeSk7Cj4gIAo+IC0JcmV0ID0gaW50ZWxfYXRvbWlj X3ByZXBhcmVfY29tbWl0KGRldiwgc3RhdGUpOwo+IC0JaWYgKHJldCkgewo+IC0JCURSTV9ERUJV R19BVE9NSUMoIlByZXBhcmluZyBzdGF0ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiAtCQlp OTE1X3N3X2ZlbmNlX2NvbW1pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4gLQkJcmV0 dXJuIHJldDsKPiAtCX0KPiAtCj4gIAkvKgo+ICAJICogVGhlIGludGVsX2xlZ2FjeV9jdXJzb3Jf dXBkYXRlKCkgZmFzdCBwYXRoIHRha2VzIGNhcmUKPiAgCSAqIG9mIGF2b2lkaW5nIHRoZSB2Ymxh bmsgd2FpdHMgZm9yIHNpbXBsZSBjdXJzb3IKPiBAQCAtMTI0MzcsMTkgKzEyNDI4LDMyIEBAIHN0 YXRpYyBpbnQgaW50ZWxfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJ ICogdXBkYXRlcyBoYXBwZW4gZHVyaW5nIHRoZSBjb3JyZWN0IGZyYW1lcy4gR2VuOSsgaGF2ZQo+ ICAJICogZG91YmxlIGJ1ZmZlcmVkIHdhdGVybWFya3MgYW5kIHNvIHNob3VsZG4ndCBuZWVkIHRo aXMuCj4gIAkgKgo+IC0JICogRG8gdGhpcyBhZnRlciBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9j b21taXQoKSBhbmQKPiAtCSAqIGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdCgpIGJlY2F1c2Ug d2Ugc3RpbGwgd2FudAo+IC0JICogdG8gc2tpcCB0aGUgZmxpcCBhbmQgZmIgY2xlYW51cCB3YWl0 cy4gQWx0aG91Z2ggdGhhdAo+IC0JICogZG9lcyByaXNrIHlhbmtpbmcgdGhlIG1hcHBpbmcgZnJv bSB1bmRlciB0aGUgZGlzcGxheQo+IC0JICogZW5naW5lLgo+ICsJICogVW5zZXQgc3RhdGUtPmxl Z2FjeV9jdXJzb3JfdXBkYXRlIGJlZm9yZSB0aGUgY2FsbCB0bwo+ICsJICogZHJtX2F0b21pY19o ZWxwZXJfc2V0dXBfY29tbWl0KCkgYmVjYXVzZSBvdGhlcndpc2UKPiArCSAqIGRybV9hdG9taWNf aGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGlzIGEgbm9vcCBhbmQKPiArCSAqIHdlIGdldCBG SUZPIHVuZGVycnVucyBiZWNhdXNlIHdlIGRpZG4ndCB3YWl0Cj4gKwkgKiBmb3IgdmJsYW5rLgo+ ICAJICoKPiAgCSAqIEZJWE1FIGRvaW5nIHdhdGVybWFya3MgYW5kIGZiIGNsZWFudXAgZnJvbSBh IHZibGFuayB3b3JrZXIKPiAgCSAqIChhc3N1bWluZyB3ZSBoYWQgYW55KSB3b3VsZCBzb2x2ZSB0 aGVzZSBwcm9ibGVtcy4KPiAgCSAqLwo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+ IC0JCXN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSA9IGZhbHNlOwo+ICsJaWYgKElOVEVMX0dF TihkZXZfcHJpdikgPCA5ICYmIHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSkgewo+ICsJCWZv cl9lYWNoX25ld19jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBuZXdfY3J0Y19zdGF0ZSwgaSkK PiArCQkJaWYgKHRvX2ludGVsX2NydGNfc3RhdGUobmV3X2NydGNfc3RhdGUpLT53bS5uZWVkX3Bv c3R2YmxfdXBkYXRlKQo+ICsJCQkJc3RhdGUtPmxlZ2FjeV9jdXJzb3JfdXBkYXRlID0gZmFsc2U7 Cj4gKwl9CgpIbW0uIEkgZG9uJ3QgdGhpbmsgd2UgY2FuIHJlbHkgb24gbmVlZF9wb3N0dmJsX3Vw ZGF0ZSBhdCB0aGlzIHBvaW50LgpQcmUtZzR4IGNvZGUgd29uJ3Qgc2V0IGl0LiBXZSBhbHJlYWR5 IG1hZGUgdGhlIGRlY2lzaW9uIHRvIG5vdCB1c2UgdGhlCmZhc3QgcGF0aCwgc28gZXhwbGljaXRs eSBzZXR0aW5nIGxlZ2FjeV9jdXJzb3JfdXBkYXRlPWZhbHNlIHNob3VsZCBzdGlsbApiZSBmaW5l LCBubz8KCj4gKwo+ICsJcmV0ID0gaW50ZWxfYXRvbWljX3ByZXBhcmVfY29tbWl0KGRldiwgc3Rh dGUpOwo+ICsJaWYgKHJldCkgewo+ICsJCURSTV9ERUJVR19BVE9NSUMoIlByZXBhcmluZyBzdGF0 ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiArCQlpOTE1X3N3X2ZlbmNlX2NvbW1pdCgmaW50 ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwly ZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RhdGUsIG5vbmJsb2NrKTsKPiAr CWlmICghcmV0KQo+ICsJCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3N3YXBfc3RhdGUoc3RhdGUs IHRydWUpOwo+ICAKPiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3N3YXBfc3RhdGUoc3RhdGUs IHRydWUpOwo+ICAJaWYgKHJldCkgewo+ICAJCWk5MTVfc3dfZmVuY2VfY29tbWl0KCZpbnRlbF9z dGF0ZS0+Y29tbWl0X3JlYWR5KTsKPiAgCj4gLS0gCj4gMi4xNC4xCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK