From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/8] drm/i915: Pass crtc state to i9xx_enable_pll()
Date: Wed, 13 Sep 2017 18:20:48 +0300 [thread overview]
Message-ID: <20170913152048.GS4914@intel.com> (raw)
In-Reply-To: <150531370634.4880.11626998659778560642@mail.alporthouse.com>
On Wed, Sep 13, 2017 at 03:41:46PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-09-13 15:08:56)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Pass the crtc state to i9xx_enable_pll() and use it rather than
> > crtc->config.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> (mutters something about consistency in crtc_state vs pipe_config)
Yeah, that's a PITA. I'm thinking we'll try to take care of that
with coccinelle or sed once the non-trivial cases are sorted.
Also looks like I missed i9xx_set_pll_dividers(). I'll have to fix that
one up as well to get the gmch DPLL code cleaned up.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 14:08 [PATCH 0/8] drm/i915: Some DPLL crtc->state/config cleanups etc Ville Syrjala
2017-09-13 14:08 ` [PATCH 1/8] drm/i915: Set output_types to EDP for vlv/chv DPLL forcing Ville Syrjala
2017-09-13 14:08 ` [PATCH 2/8] drm/i915: Parametrize CBR_DPLLBMD_PIPE defines Ville Syrjala
2017-09-13 14:38 ` Chris Wilson
2017-09-13 14:08 ` [PATCH 3/8] drm/i915: Eliminate crtc->config from VLV/CHV DPLL functions Ville Syrjala
2017-09-13 14:40 ` Chris Wilson
2017-09-13 15:18 ` Ville Syrjälä
2017-09-13 14:08 ` [PATCH 4/8] drm/i915: Pass crtc state to i9xx_enable_pll() Ville Syrjala
2017-09-13 14:41 ` Chris Wilson
2017-09-13 15:20 ` Ville Syrjälä [this message]
2017-09-13 14:08 ` [PATCH 5/8] drm/i915: Nuke the bogus kernel doc for i9xx_disable_pll() Ville Syrjala
2017-09-13 14:42 ` Chris Wilson
2017-09-13 14:08 ` [PATCH 6/8] drm/i915: Add for_each_oldnew_intel_crtc_in_state() Ville Syrjala
2017-09-13 14:08 ` [PATCH 7/8] drm/i915: Shrink active_crtcs and active_pipes_changed to u8 Ville Syrjala
2017-09-13 14:49 ` Chris Wilson
2017-09-13 16:30 ` Ville Syrjälä
2017-09-13 14:09 ` [PATCH 8/8] drm/i915: Eliminate crtc->state usage from DVO pipe tracking Ville Syrjala
2017-09-13 14:51 ` Chris Wilson
2017-09-13 14:37 ` ✓ Fi.CI.BAT: success for drm/i915: Some DPLL crtc->state/config cleanups etc Patchwork
2017-09-14 1:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-10 15:47 ` [PATCH 0/8] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913152048.GS4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox