public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ville Syrjala <ville.syrjala@intel.com>
Subject: Re: [PATCH v2 1/5] drm/i915: Rename lvds_use_ssc modparam to panel_use_ssc
Date: Thu, 14 Sep 2017 15:25:09 +0300	[thread overview]
Message-ID: <20170914122509.GX4914@intel.com> (raw)
In-Reply-To: <20170914115413.2620-2-michal.wajdeczko@intel.com>

On Thu, Sep 14, 2017 at 11:54:09AM +0000, Michal Wajdeczko wrote:
> This modparam affects not only LVDS but also eDP panels. Additionally
> with this rename we will keep modparam and i915_params field name in sync.
> This patch will unblock us with further improvements around params defs.
> 
> Suggested-by: Ville Syrjala <ville.syrjala@intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Ville Syrjala <ville.syrjala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

Let's see if we get any bug reports from this ;)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 8ab003d..221f7d4 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -105,8 +105,8 @@ MODULE_PARM_DESC(lvds_channel_mode,
>  	 "Specify LVDS channel mode "
>  	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");
>  
> -module_param_named_unsafe(lvds_use_ssc, i915.panel_use_ssc, int, 0600);
> -MODULE_PARM_DESC(lvds_use_ssc,
> +module_param_named_unsafe(panel_use_ssc, i915.panel_use_ssc, int, 0600);
> +MODULE_PARM_DESC(panel_use_ssc,
>  	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
>  	"(default: auto from VBT)");
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-14 12:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14 11:54 [PATCH v2 0/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 1/5] drm/i915: Rename lvds_use_ssc modparam to panel_use_ssc Michal Wajdeczko
2017-09-14 12:25   ` Ville Syrjälä [this message]
2017-09-14 11:54 ` [PATCH v2 2/5] drm/i915: Introduce custom variant of module_param_named macro Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 3/5] drm/i915: Extend private i915_param_named macro with description Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 4/5] drm/i915: Wrap access to module params into macro Michal Wajdeczko
2017-09-14 13:10   ` Jani Nikula
2017-09-14 14:03     ` Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 5/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 12:13 ` ✓ Fi.CI.BAT: success for drm/i915: Rename global i915 to i915_params (rev2) Patchwork
2017-09-14 13:21 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170914122509.GX4914@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox