From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Zhi Wang <zhi.a.wang@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Ben Widawsky <benjamin.widawsky@intel.com>,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()
Date: Thu, 14 Sep 2017 10:36:49 -0700 [thread overview]
Message-ID: <20170914173649.dxgwjmsgqr6fm2u4@intel.com> (raw)
In-Reply-To: <1505409850-6468-1-git-send-email-zhi.a.wang@intel.com>
well, I wouldn't call this as a typo.
This is a logic fix and deserves a better subject a proper
commit message an also fixes tag:
Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
On Thu, Sep 14, 2017 at 05:24:09PM +0000, Zhi Wang wrote:
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 729ebaf..37cd086 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
> };
>
> /* Cache attribute has to be matched. */
> - if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
> + if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
> return 0;
>
> score |= CA_MATCH;
> --
> 2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-14 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 17:24 [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() Zhi Wang
2017-09-14 17:24 ` [PATCH 2/2] drm/i915: add lockdep_assert_held in i915_ppat_{get, put} Zhi Wang
2017-09-14 18:39 ` Chris Wilson
2017-09-15 6:09 ` Joonas Lahtinen
2017-09-14 17:36 ` Rodrigo Vivi [this message]
2017-09-14 17:51 ` [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() Wang, Zhi A
2017-09-18 13:08 ` Joonas Lahtinen
2017-09-18 13:14 ` Wang, Zhi A
2017-09-14 18:41 ` Chris Wilson
2017-09-15 3:03 ` Wang, Zhi A
2017-09-15 5:01 ` Widawsky, Benjamin
2017-09-15 5:08 ` Wang, Zhi A
2017-09-14 17:42 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-09-14 23:51 ` ✗ Fi.CI.IGT: warning " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-09-14 17:21 [PATCH 1/2] " Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914173649.dxgwjmsgqr6fm2u4@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox