From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 1/2] drm: handle override and firmware EDID at drm_do_get_edid() level Date: Fri, 15 Sep 2017 15:08:42 +0300 Message-ID: <20170915120842.GP4914@intel.com> References: <1e8a710bcac46e5136c1a7b430074893c81f364a.1505203831.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1e8a710bcac46e5136c1a7b430074893c81f364a.1505203831.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTIsIDIwMTcgYXQgMTE6MTk6MjZBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gSGFuZGxlIGRlYnVnZnMgb3ZlcnJpZGUgZWRpZCBhbmQgZmlybXdhcmUgZWRpZCBhdCB0 aGUgbG93IGxldmVsIHRvCj4gdHJhbnNwYXJlbnRseSBhbmQgY29tcGxldGVseSByZXBsYWNlIHRo ZSByZWFsIGVkaWQuIFByZXZpb3VzbHksIHdlCj4gcHJhY3RpY2FsbHkgb25seSB1c2VkIHRoZSBt b2RlcyBmcm9tIHRoZSBvdmVycmlkZSBFRElELCBhbmQgbm9uZSBvZiB0aGUKPiBvdGhlciBkYXRh LCBzdWNoIGFzIGF1ZGlvIHBhcmFtZXRlcnMuCj4gCj4gVGhpcyBjaGFuZ2UgYWxzbyBwcmV2ZW50 cyBhY3R1YWwgRURJRCByZWFkcyB3aGVuIHRoZSBFRElEIGlzIHRvIGJlCj4gb3ZlcnJpZGRlbiwg YnV0IHJldGFpbnMgdGhlIEREQyBwcm9iZS4gVGhpcyBpcyB1c2VmdWwgaWYgdGhlIHJlYXNvbiBm b3IKPiBwcmVmZXJyaW5nIG92ZXJyaWRlIEVESUQgYXJlIHByb2JsZW1zIHdpdGggcmVhZGluZyB0 aGUgZGF0YSwgb3IKPiBjb3JydXB0aW9uIG9mIHRoZSBkYXRhLgo+IAo+IE1vdmUgZmlybXdhcmUg RURJRCBsb2FkaW5nIGZyb20gaGVscGVyIHRvIGNvcmUsIGFzIHRoZSBmdW5jdGlvbmFsaXR5Cj4g bW92ZXMgdG8gbG93ZXIgbGV2ZWwgYXMgd2VsbC4gVGhpcyB3aWxsIHJlc3VsdCBpbiBhIGNoYW5n ZSBvZiBtb2R1bGUKPiBwYXJhbWV0ZXIgZnJvbSBkcm1fa21zX2hlbHBlci5lZGlkX2Zpcm13YXJl IHRvIGRybS5lZGlkX2Zpcm13YXJlLCB3aGljaAo+IGFyZ3VhYmx5IG1ha2VzIG1vcmUgc2Vuc2Ug YW55d2F5Lgo+IAo+IFNvbWUgZnV0dXJlIHdvcmsgcmVtYWlucyByZWxhdGVkIHRvIG92ZXJyaWRl IGFuZCBmaXJtd2FyZSBFRElECj4gdmFsaWRhdGlvbi4gTGlrZSBiZWZvcmUsIG5vIHZhbGlkYXRp b24gaXMgZG9uZSBmb3Igb3ZlcnJpZGUgRURJRC4gVGhlCj4gZmlybXdhcmUgRURJRCBpcyB2YWxp ZGF0ZWQgc2VwYXJhdGVseSBpbiB0aGUgbG9hZGVyLiBTb21lIHVuaWZpY2F0aW9uCj4gYW5kIGRl ZHVwbGljYXRpb24gd291bGQgYmUgaW4gb3JkZXIsIHRvIHZhbGlkYXRlIGFsbCBvZiB0aGVtIGF0 IHRoZQo+IGRybV9kb19nZXRfZWRpZCgpIGxldmVsLCBsaWtlICJyZWFsIiBFRElEcy4KPiAKPiB2 MjogbW92ZSBmaXJtd2FyZSBsb2FkaW5nIHRvIGNvcmUKPiAKPiB2MzogcmViYXNlLCBjb21taXQg bWVzc2FnZSByZWZyZXNoCj4gCj4gQ2M6IEFiZGllbCBKYW51bGd1ZSA8YWJkaWVsLmphbnVsZ3Vl QGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZnds bC5jaD4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoK UmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+CnN0aWxsIGhvbGRzCgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2FkbWluLWd1aWRlL2tlcm5l bC1wYXJhbWV0ZXJzLnR4dCB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9LY29uZmlnICAgICAg ICAgICAgICAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL01ha2VmaWxlICAg ICAgICAgICAgICAgICAgICAgICAgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu YyAgICAgICAgICAgICAgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jICAgICAgICAgICAgICB8IDE5ICstLS0tLS0tLS0tLS0t LS0tLS0KPiAgNSBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9hZG1pbi1ndWlkZS9rZXJuZWwtcGFy YW1ldGVycy50eHQgYi9Eb2N1bWVudGF0aW9uL2FkbWluLWd1aWRlL2tlcm5lbC1wYXJhbWV0ZXJz LnR4dAo+IGluZGV4IGQ5YzE3MWNlNDE5MC4uOWIzOTNjMjk5NTNmIDEwMDY0NAo+IC0tLSBhL0Rv Y3VtZW50YXRpb24vYWRtaW4tZ3VpZGUva2VybmVsLXBhcmFtZXRlcnMudHh0Cj4gKysrIGIvRG9j dW1lbnRhdGlvbi9hZG1pbi1ndWlkZS9rZXJuZWwtcGFyYW1ldGVycy50eHQKPiBAQCAtODU0LDcg Kzg1NCw3IEBACj4gIAkJCVRoZSBmaWx0ZXIgY2FuIGJlIGRpc2FibGVkIG9yIGNoYW5nZWQgdG8g YW5vdGhlcgo+ICAJCQlkcml2ZXIgbGF0ZXIgdXNpbmcgc3lzZnMuCj4gIAo+IC0JZHJtX2ttc19o ZWxwZXIuZWRpZF9maXJtd2FyZT1bPGNvbm5lY3Rvcj46XTxmaWxlPlssWzxjb25uZWN0b3I+Ol08 ZmlsZT5dCj4gKwlkcm0uZWRpZF9maXJtd2FyZT1bPGNvbm5lY3Rvcj46XTxmaWxlPlssWzxjb25u ZWN0b3I+Ol08ZmlsZT5dCj4gIAkJCUJyb2tlbiBtb25pdG9ycywgZ3JhcGhpYyBhZGFwdGVycywg S1ZNcyBhbmQgRURJRGxlc3MKPiAgCQkJcGFuZWxzIG1heSBzZW5kIG5vIG9yIGluY29ycmVjdCBF RElEIGRhdGEgc2V0cy4KPiAgCQkJVGhpcyBwYXJhbWV0ZXIgYWxsb3dzIHRvIHNwZWNpZnkgYW4g RURJRCBkYXRhIHNldHMKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL0tjb25maWcgYi9k cml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+IGluZGV4IGM1ZTFhODQwOTI4NS4uYzlmMDlmYzI5OGJi IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL0tjb25maWcKPiBAQCAtMTEwLDcgKzExMCw3IEBAIGNvbmZpZyBEUk1fRkJERVZfT1ZF UkFMTE9DCj4gIAo+ICBjb25maWcgRFJNX0xPQURfRURJRF9GSVJNV0FSRQo+ICAJYm9vbCAiQWxs b3cgdG8gc3BlY2lmeSBhbiBFRElEIGRhdGEgc2V0IGluc3RlYWQgb2YgcHJvYmluZyBmb3IgaXQi Cj4gLQlkZXBlbmRzIG9uIERSTV9LTVNfSEVMUEVSCj4gKwlkZXBlbmRzIG9uIERSTQo+ICAJaGVs cAo+ICAJICBTYXkgWSBoZXJlLCBpZiB5b3Ugd2FudCB0byB1c2UgRURJRCBkYXRhIHRvIGJlIGxv YWRlZCBmcm9tIHRoZQo+ICAJICAvbGliL2Zpcm13YXJlIGRpcmVjdG9yeSBvciBvbmUgb2YgdGhl IHByb3ZpZGVkIGJ1aWx0LWluCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9NYWtlZmls ZSBiL2RyaXZlcnMvZ3B1L2RybS9NYWtlZmlsZQo+IGluZGV4IGRmOTIzMTE5YWMzNi4uMGVlMTg0 ZjU2YTYwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9NYWtlZmlsZQo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9NYWtlZmlsZQo+IEBAIC0yOCw2ICsyOCw3IEBAIGRybS0kKENPTkZJR19E Uk1fUEFORUwpICs9IGRybV9wYW5lbC5vCj4gIGRybS0kKENPTkZJR19PRikgKz0gZHJtX29mLm8K PiAgZHJtLSQoQ09ORklHX0FHUCkgKz0gZHJtX2FncHN1cHBvcnQubwo+ICBkcm0tJChDT05GSUdf REVCVUdfRlMpICs9IGRybV9kZWJ1Z2ZzLm8gZHJtX2RlYnVnZnNfY3JjLm8KPiArZHJtLSQoQ09O RklHX0RSTV9MT0FEX0VESURfRklSTVdBUkUpICs9IGRybV9lZGlkX2xvYWQubwo+ICAKPiAgZHJt X2ttc19oZWxwZXIteSA6PSBkcm1fY3J0Y19oZWxwZXIubyBkcm1fZHBfaGVscGVyLm8gZHJtX3By b2JlX2hlbHBlci5vIFwKPiAgCQlkcm1fcGxhbmVfaGVscGVyLm8gZHJtX2RwX21zdF90b3BvbG9n eS5vIGRybV9hdG9taWNfaGVscGVyLm8gXAo+IEBAIC0zNiw3ICszNyw2IEBAIGRybV9rbXNfaGVs cGVyLXkgOj0gZHJtX2NydGNfaGVscGVyLm8gZHJtX2RwX2hlbHBlci5vIGRybV9wcm9iZV9oZWxw ZXIubyBcCj4gIAkJZHJtX3NjZGNfaGVscGVyLm8gZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIu bwo+ICAKPiAgZHJtX2ttc19oZWxwZXItJChDT05GSUdfRFJNX1BBTkVMX0JSSURHRSkgKz0gYnJp ZGdlL3BhbmVsLm8KPiAtZHJtX2ttc19oZWxwZXItJChDT05GSUdfRFJNX0xPQURfRURJRF9GSVJN V0FSRSkgKz0gZHJtX2VkaWRfbG9hZC5vCj4gIGRybV9rbXNfaGVscGVyLSQoQ09ORklHX0RSTV9G QkRFVl9FTVVMQVRJT04pICs9IGRybV9mYl9oZWxwZXIubwo+ICBkcm1fa21zX2hlbHBlci0kKENP TkZJR19EUk1fS01TX0NNQV9IRUxQRVIpICs9IGRybV9mYl9jbWFfaGVscGVyLm8KPiAgZHJtX2tt c19oZWxwZXItJChDT05GSUdfRFJNX0RQX0FVWF9DSEFSREVWKSArPSBkcm1fZHBfYXV4X2Rldi5v Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9lZGlkLmMKPiBpbmRleCA2YmI2MzM3YmU5MjAuLjAwZGRhYmZiZjk4MCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZWRpZC5jCj4gQEAgLTE1MzMsNiArMTUzMywxMCBAQCBzdGF0aWMgdm9pZCBjb25uZWN0 b3JfYmFkX2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgICogbGV2ZWws IGRyaXZlcnMgbXVzdCBtYWtlIGFsbCByZWFzb25hYmxlIGVmZm9ydHMgdG8gZXhwb3NlIGl0IGFz IGFuIEkyQwo+ICAgKiBhZGFwdGVyIGFuZCB1c2UgZHJtX2dldF9lZGlkKCkgaW5zdGVhZCBvZiBh YnVzaW5nIHRoaXMgZnVuY3Rpb24uCj4gICAqCj4gKyAqIFRoZSBFRElEIG1heSBiZSBvdmVycmlk ZGVuIHVzaW5nIGRlYnVnZnMgb3ZlcnJpZGVfZWRpZCBvciBmaXJtYXJlIEVESUQKPiArICogKGRy bV9sb2FkX2VkaWRfZmlybXdhcmUoKSBhbmQgZHJtLmVkaWRfZmlybXdhcmUgcGFyYW1ldGVyKSwg aW4gdGhpcyBwcmlvcml0eQo+ICsgKiBvcmRlci4gSGF2aW5nIGVpdGhlciBvZiB0aGVtIGJ5cGFz c2VzIGFjdHVhbCBFRElEIHJlYWRzLgo+ICsgKgo+ICAgKiBSZXR1cm46IFBvaW50ZXIgdG8gdmFs aWQgRURJRCBvciBOVUxMIGlmIHdlIGNvdWxkbid0IGZpbmQgYW55Lgo+ICAgKi8KPiAgc3RydWN0 IGVkaWQgKmRybV9kb19nZXRfZWRpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ IEBAIC0xNTQyLDYgKzE1NDYsMTcgQEAgc3RydWN0IGVkaWQgKmRybV9kb19nZXRfZWRpZChzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICB7Cj4gIAlpbnQgaSwgaiA9IDAsIHZhbGlk X2V4dGVuc2lvbnMgPSAwOwo+ICAJdTggKmVkaWQsICpuZXc7Cj4gKwlzdHJ1Y3QgZWRpZCAqb3Zl cnJpZGUgPSBOVUxMOwo+ICsKPiArCWlmIChjb25uZWN0b3ItPm92ZXJyaWRlX2VkaWQpCj4gKwkJ b3ZlcnJpZGUgPSBkcm1fZWRpZF9kdXBsaWNhdGUoKGNvbnN0IHN0cnVjdCBlZGlkICopCj4gKwkJ CQkJICAgICAgY29ubmVjdG9yLT5lZGlkX2Jsb2JfcHRyLT5kYXRhKTsKPiArCj4gKwlpZiAoIW92 ZXJyaWRlKQo+ICsJCW92ZXJyaWRlID0gZHJtX2xvYWRfZWRpZF9maXJtd2FyZShjb25uZWN0b3Ip Owo+ICsKPiArCWlmICghSVNfRVJSX09SX05VTEwob3ZlcnJpZGUpKQo+ICsJCXJldHVybiBvdmVy cmlkZTsKPiAgCj4gIAlpZiAoKGVkaWQgPSBrbWFsbG9jKEVESURfTEVOR1RILCBHRlBfS0VSTkVM KSkgPT0gTlVMTCkKPiAgCQlyZXR1cm4gTlVMTDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wcm9iZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVy LmMKPiBpbmRleCA5MDQ5NjZjZGUzMmIuLjU4NDBhYWJiZjI0ZSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9wcm9iZV9oZWxwZXIuYwo+IEBAIC0zNTMsOCArMzUzLDYgQEAgRVhQT1JUX1NZTUJPTChkcm1f aGVscGVyX3Byb2JlX2RldGVjdCk7Cj4gICAqICAgIGRybV9tb2RlX3Byb2JlZF9hZGQoKS4gTmV3 IG1vZGVzIHN0YXJ0IHRoZWlyIGxpZmUgd2l0aCBzdGF0dXMgYXMgT0suCj4gICAqICAgIE1vZGVz IGFyZSBhZGRlZCBmcm9tIGEgc2luZ2xlIHNvdXJjZSB1c2luZyB0aGUgZm9sbG93aW5nIHByaW9y aXR5IG9yZGVyLgo+ICAgKgo+IC0gKiAgICAtIGRlYnVnZnMgJ292ZXJyaWRlX2VkaWQnICh1c2Vk IGZvciB0ZXN0aW5nIG9ubHkpCj4gLSAqICAgIC0gZmlybXdhcmUgRURJRCAoZHJtX2xvYWRfZWRp ZF9maXJtd2FyZSgpKQo+ICAgKiAgICAtICZkcm1fY29ubmVjdG9yX2hlbHBlcl9mdW5jcy5nZXRf bW9kZXMgdmZ1bmMKPiAgICogICAgLSBpZiB0aGUgY29ubmVjdG9yIHN0YXR1cyBpcyBjb25uZWN0 b3Jfc3RhdHVzX2Nvbm5lY3RlZCwgc3RhbmRhcmQKPiAgICogICAgICBWRVNBIERNVCBtb2RlcyB1 cCB0byAxMDI0eDc2OCBhcmUgYXV0b21hdGljYWxseSBhZGRlZAo+IEBAIC00ODMsMjIgKzQ4MSw3 IEBAIGludCBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlnb3RvIHBydW5lOwo+ICAJfQo+ICAKPiAtCWlm IChjb25uZWN0b3ItPm92ZXJyaWRlX2VkaWQpIHsKPiAtCQlzdHJ1Y3QgZWRpZCAqZWRpZCA9IChz dHJ1Y3QgZWRpZCAqKSBjb25uZWN0b3ItPmVkaWRfYmxvYl9wdHItPmRhdGE7Cj4gLQo+IC0JCWNv dW50ID0gZHJtX2FkZF9lZGlkX21vZGVzKGNvbm5lY3RvciwgZWRpZCk7Cj4gLQkJZHJtX2VkaWRf dG9fZWxkKGNvbm5lY3RvciwgZWRpZCk7Cj4gLQl9IGVsc2Ugewo+IC0JCXN0cnVjdCBlZGlkICpl ZGlkID0gZHJtX2xvYWRfZWRpZF9maXJtd2FyZShjb25uZWN0b3IpOwo+IC0JCWlmICghSVNfRVJS X09SX05VTEwoZWRpZCkpIHsKPiAtCQkJZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3By b3BlcnR5KGNvbm5lY3RvciwgZWRpZCk7Cj4gLQkJCWNvdW50ID0gZHJtX2FkZF9lZGlkX21vZGVz KGNvbm5lY3RvciwgZWRpZCk7Cj4gLQkJCWRybV9lZGlkX3RvX2VsZChjb25uZWN0b3IsIGVkaWQp Owo+IC0JCQlrZnJlZShlZGlkKTsKPiAtCQl9Cj4gLQkJaWYgKGNvdW50ID09IDApCj4gLQkJCWNv dW50ID0gKCpjb25uZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29ubmVjdG9yKTsKPiAtCX0KPiAr CWNvdW50ID0gKCpjb25uZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29ubmVjdG9yKTsKPiAgCj4g IAlpZiAoY291bnQgPT0gMCAmJiBjb25uZWN0b3ItPnN0YXR1cyA9PSBjb25uZWN0b3Jfc3RhdHVz X2Nvbm5lY3RlZCkKPiAgCQljb3VudCA9IGRybV9hZGRfbW9kZXNfbm9lZGlkKGNvbm5lY3Rvciwg MTAyNCwgNzY4KTsKPiAtLSAKPiAyLjExLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RD Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=