From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: Intel GFX discussion <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/6] meson: Install libigt.so
Date: Fri, 15 Sep 2017 16:17:43 +0300 [thread overview]
Message-ID: <20170915131743.GR4914@intel.com> (raw)
In-Reply-To: <20170915115604.6sfkzdszmmhnhvf4@platvala-desk.ger.corp.intel.com>
On Fri, Sep 15, 2017 at 02:56:04PM +0300, Petri Latvala wrote:
> On Thu, Sep 14, 2017 at 05:20:47PM -0700, Jordan Justen wrote:
> > On 2017-09-14 12:13:08, Ville Syrjälä wrote:
> > > I don't actually know what the plan is w.r.t. installing the lib, so
> > > I'll leave this one for someone else to ack/nack.
>
> The plan is to install the lib.
>
> The concerns with installing the lib are that we should keep support
> for running the IGT binaries without and with installing. That means:
>
> - Setting things up so that the runtime linker can find the installed
> .so for installed executables, and builddir-.so for
> builddir-executables.
>
> - Making sure the linked .so originates from the same build as the
> executable, using some better error message than just corrupting the
> call stack. Nailing down an ABI for libigt.so is impossible.
>
> With that said: Meson build system in general, and the existence of
> the .so in particular is for experimental users who know they get to
> keep both pieces when things break. And installing the .so is anyway
> something to be done sooner or later.
>
> Acked-by: Petri Latvala <petri.latvala@intel.com>
Cool. I've pushed the three patches from this series, and my own series
(with the whitespace fixed) to master. Thanks for the patches and
reviews.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-15 13:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 1:10 [PATCH 1/6] intel_aubdump: Rename intel_aubdump.so to libintel_aubdump.so Jordan Justen
2017-09-14 1:10 ` [PATCH 2/6] meson: Install libigt.so Jordan Justen
2017-09-14 19:13 ` Ville Syrjälä
2017-09-15 0:20 ` Jordan Justen
2017-09-15 11:56 ` Petri Latvala
2017-09-15 13:17 ` Ville Syrjälä [this message]
2017-09-14 1:10 ` [PATCH 3/6] meson: Install libintel_aubdump.so Jordan Justen
2017-09-14 1:10 ` [PATCH 4/6] intel_aubdump.in: Set executable permissions (for meson build) Jordan Justen
2017-09-14 19:06 ` Ville Syrjälä
2017-09-14 1:10 ` [PATCH 5/6] meson: Process intel_aubdump.in into intel_aubdump Jordan Justen
2017-09-14 19:10 ` Ville Syrjälä
2017-09-14 1:11 ` [PATCH 6/6] intel_aubdump: Add --no-exec command option Jordan Justen
2017-09-14 1:23 ` Jordan Justen
2017-09-14 11:46 ` [PATCH 1/6] intel_aubdump: Rename intel_aubdump.so to libintel_aubdump.so Petri Latvala
2017-09-14 17:53 ` Jordan Justen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915131743.GR4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox