From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector Date: Fri, 15 Sep 2017 21:09:40 +0300 Message-ID: <20170915180940.GU4914@intel.com> References: <20170914195935.2408-1-james.ausmus@intel.com> <20170915174909.18695-1-james.ausmus@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 363FB6EC97 for ; Fri, 15 Sep 2017 18:09:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170915174909.18695-1-james.ausmus@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: James Ausmus Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMTUsIDIwMTcgYXQgMTA6NDk6MDlBTSAtMDcwMCwgSmFtZXMgQXVzbXVzIHdy b3RlOgo+IE1ha2UgaW50ZWxfZHBfYWRkX21zdF9jb25uZWN0b3IgaGFuZGxlIGVycm9yIHJldHVy bnMgZnJvbSB0aGUgZHJtXyBjYWxscy4KPiBBZGQgaW50ZWxfY29ubmVjdG9yX2ZyZWUgdG8gc3Vw cG9ydCBjbGVhbnVwIG9uIHRoZSBlcnJvciBwYXRoLgo+IAo+IHYyOiBSZW5hbWUgbmV3IGZ1bmN0 aW9uIHRvIGF2b2lkIGNvbmZ1c2lvbiwgYW5kIHNpbXBsaWZ5IGVycm9yCj4gcGF0aHMgKFZpbGxl KQo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbWVzIEF1c211cyA8amFtZXMuYXVzbXVzQGludGVsLmNv bT4KPiAtLS0KPiAKPiBOb3RlIHRoYXQgdGhpcyBwYXRjaCBpcyBjb21waWxlL2Jvb3QgdGVzdGVk IG9ubHkgb24gbm9uLU1TVCwgYXMgSQo+IGN1cnJlbnRseSBkb24ndCBoYXZlIE1TVC1lbmFibGVk IEhXLgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMCArKysr KysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jICB8IDIzICsrKysr KysrKysrKysrKysrKystLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAg ICB8ICAxICsKPiAgMyBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA4NTk5ZTQy NWFiYjEuLmUzYjFhNmVhZDRmYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiBAQCAtNjE0Niw2ICs2MTQ2LDE2IEBAIHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVs X2Nvbm5lY3Rvcl9hbGxvYyh2b2lkKQo+ICAJcmV0dXJuIGNvbm5lY3RvcjsKPiAgfQo+ICAKPiAr LyoKPiArICogRnJlZSB0aGUgYml0cyBhbGxvY2F0ZWQgYnkgaW50ZWxfY29ubmVjdG9yX2FsbG9j Lgo+ICsgKiBUeXBlLXNwZWNpZmljIGNvbm5lY3RvciBjbGVhbnVwIHNob3VsZCBiZSBkb25lIHBy aW9yIHRvIHRoaXMuCj4gKyAqLwo+ICt2b2lkIGludGVsX2Nvbm5lY3Rvcl9mcmVlKHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiArewo+ICsJa2ZyZWUodG9faW50ZWxfZGlnaXRh bF9jb25uZWN0b3Jfc3RhdGUoY29ubmVjdG9yLT5iYXNlLnN0YXRlKSk7Cj4gKwlrZnJlZShjb25u ZWN0b3IpOwo+ICt9Cj4gKwo+ICAvKiBTaW1wbGUgY29ubmVjdG9yLT5nZXRfaHdfc3RhdGUgaW1w bGVtZW50YXRpb24gZm9yIGVuY29kZXJzIHRoYXQgc3VwcG9ydCBvbmx5Cj4gICAqIG9uZSBjb25u ZWN0b3IgYW5kIG5vIGNsb25pbmcgYW5kIGhlbmNlIHRoZSBlbmNvZGVyIHN0YXRlIGRldGVybWlu ZXMgdGhlIHN0YXRlCj4gICAqIG9mIHRoZSBjb25uZWN0b3IuICovCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHBfbXN0LmMKPiBpbmRleCA4ZTNhYWQwZWE2MGIuLjZlNDQ0N2NiYmUwZSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gQEAgLTQ1MSwxNCArNDUxLDE4IEBAIHN0 YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqaW50ZWxfZHBfYWRkX21zdF9jb25uZWN0b3Ioc3Ry dWN0IGRybV9kcF9tc3RfdG9wb2xvCj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxf ZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRl bF9jb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+IC0JaW50 IGk7Cj4gKwlpbnQgaSwgcmV0Owo+ICAKPiAgCWludGVsX2Nvbm5lY3RvciA9IGludGVsX2Nvbm5l Y3Rvcl9hbGxvYygpOwo+ICAJaWYgKCFpbnRlbF9jb25uZWN0b3IpCj4gIAkJcmV0dXJuIE5VTEw7 Cj4gIAo+ICAJY29ubmVjdG9yID0gJmludGVsX2Nvbm5lY3Rvci0+YmFzZTsKPiAtCWRybV9jb25u ZWN0b3JfaW5pdChkZXYsIGNvbm5lY3RvciwgJmludGVsX2RwX21zdF9jb25uZWN0b3JfZnVuY3Ms IERSTV9NT0RFX0NPTk5FQ1RPUl9EaXNwbGF5UG9ydCk7Cj4gKwlyZXQgPSBkcm1fY29ubmVjdG9y X2luaXQoZGV2LCBjb25uZWN0b3IsICZpbnRlbF9kcF9tc3RfY29ubmVjdG9yX2Z1bmNzLAo+ICsJ CQkJIERSTV9NT0RFX0NPTk5FQ1RPUl9EaXNwbGF5UG9ydCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdv dG8gb3V0X2luaXQ7Cj4gKwo+ICAJZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfYWRkKGNvbm5lY3Rvciwg JmludGVsX2RwX21zdF9jb25uZWN0b3JfaGVscGVyX2Z1bmNzKTsKPiAgCj4gIAlpbnRlbF9jb25u ZWN0b3ItPmdldF9od19zdGF0ZSA9IGludGVsX2RwX21zdF9nZXRfaHdfc3RhdGU7Cj4gQEAgLTQ2 NiwxNCArNDcwLDI1IEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqaW50ZWxfZHBfYWRk X21zdF9jb25uZWN0b3Ioc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvCj4gIAlpbnRlbF9jb25uZWN0 b3ItPnBvcnQgPSBwb3J0Owo+ICAKPiAgCWZvciAoaSA9IFBJUEVfQTsgaSA8PSBQSVBFX0M7IGkr KykgewoKQlRXIGEgZm9sbG93dXAgcGF0Y2ggdG8gc3dpdGNoIHRoZXNlIG1zdF9lbmNvZGVyc1td IGxvb3BzIG92ZXIKdG8gZm9yX2VhY2hfcGlwZSgpIG1pZ2h0IGJlIG5pY2UuCgo+IC0JCWRybV9t b2RlX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2RlcigmaW50ZWxfY29ubmVjdG9yLT5iYXNlLAo+ICsJ CXJldCA9IGRybV9tb2RlX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2RlcigmaW50ZWxfY29ubmVjdG9y LT5iYXNlLAo+ICAJCQkJCQkgICZpbnRlbF9kcC0+bXN0X2VuY29kZXJzW2ldLT5iYXNlLmJhc2Up OwoKUGxlYXNlIHJlaW5kZW50IGFwcHJvcHJpYXRlbHkuCgo+ICsJCWlmIChyZXQpCj4gKwkJCWdv dG8gb3V0X2Nvbm47Cj4gIAl9Cj4gIAo+ICAJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJmNv bm5lY3Rvci0+YmFzZSwgZGV2LT5tb2RlX2NvbmZpZy5wYXRoX3Byb3BlcnR5LCAwKTsKPiAgCWRy bV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZjb25uZWN0b3ItPmJhc2UsIGRldi0+bW9kZV9jb25m aWcudGlsZV9wcm9wZXJ0eSwgMCk7Cj4gIAo+IC0JZHJtX21vZGVfY29ubmVjdG9yX3NldF9wYXRo X3Byb3BlcnR5KGNvbm5lY3RvciwgcGF0aHByb3ApOwo+ICsJcmV0ID0gZHJtX21vZGVfY29ubmVj dG9yX3NldF9wYXRoX3Byb3BlcnR5KGNvbm5lY3RvciwgcGF0aHByb3ApOwo+ICsJaWYgKHJldCA9 PSAwKQo+ICsJCXJldHVybiBjb25uZWN0b3I7CgppZiAocmV0KQoJZ290byAuLi47CgpyZXR1cm4g Y29ubmVjdG9yOwoKaXMgbW9yZSBpZGlvbWF0aWMuCgo+ICsKPiArb3V0X2Nvbm46Cj4gKwlkcm1f Y29ubmVjdG9yX2NsZWFudXAoY29ubmVjdG9yKTsKPiArb3V0X2luaXQ6Cj4gKwlpbnRlbF9jb25u ZWN0b3JfZnJlZShpbnRlbF9jb25uZWN0b3IpOwoKSG1tLiBJIG1pZ2h0IGNhbGwgdGhlc2Ugb3V0 X2NsZWFudXAgYW5kIG91dF9mcmVlLiBCdXQgSSBndWVzcyB3ZSBoYXZlIG5vCmNvbnNpc3RlbnQg c3R5bGUgd2hlbiBpdCBjb21lcyB0byBnb3RvIGxhYmVzLiBTbyBmZWVsIGZyZWUgdG8gaWdub3Jl IG1lLgoKPiArCWNvbm5lY3RvciA9IE5VTEw7Cj4gKwo+ICAJcmV0dXJuIGNvbm5lY3RvcjsKCkp1 c3QgcmV0dXJuIE5VTEwuCgo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5k ZXggMzA3ODA3NjcyODk2Li4yYTVjZWU0MzAyZjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+IEBAIC0xMzU4LDYgKzEzNTgsNyBAQCB2b2lkIGludGVsX3Bwc191bmxvY2tfcmVnc193 YShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGludGVsX2VuY29k ZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+ICBpbnQgaW50ZWxfY29u bmVjdG9yX2luaXQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqKTsKPiAgc3RydWN0IGludGVsX2Nv bm5lY3RvciAqaW50ZWxfY29ubmVjdG9yX2FsbG9jKHZvaWQpOwo+ICt2b2lkIGludGVsX2Nvbm5l Y3Rvcl9mcmVlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gIGJvb2wgaW50 ZWxfY29ubmVjdG9yX2dldF9od19zdGF0ZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0 b3IpOwo+ICB2b2lkIGludGVsX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2RlcihzdHJ1Y3QgaW50ZWxf Y29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkgICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIpOwo+IC0tIAo+IDIuMTQuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==