Re: [PATCH 02/29] drm/i915: Shrink bxt_ddi_buf_trans

Jani Nikula
2017-09-18T18:54:17Z

On Mon, 18 Sep 2017, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> All the values we put into the BXT buf_trans tables fit into 8 bits.
> So switch over to u8 from the u32 we use currently.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/intel_ddi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 797008033089..5c709985904e 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -301,10 +301,10 @@ static const struct ddi_buf_trans skl_y_ddi_translations_hdmi[] = {
> };
>
> struct bxt_ddi_buf_trans {
> - u32 margin; /* swing value */
> - u32 scale; /* scale value */
> - u32 enable; /* scale enable */
> - u32 deemphasis;
> + u8 margin; /* swing value */
> + u8 scale; /* scale value */
> + u8 enable; /* scale enable */
> + u8 deemphasis;
> bool default_index; /* true if the entry represents default value */
> };

--
Jani Nikula, Intel Open Source Technology Center