Re: [PATCH 09/29] drm/i915: Remove useless eDP check from intel_ddi_pre_enable_dp()

Jani Nikula
2017-09-18T18:56:29Z

On Mon, 18 Sep 2017, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_edp_panel_on() will itself do the is_edp() check, so the caller
> doesn't have to bother. Pre-DDI code doesn't bother, so let's follow the
> same approach for DDI.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index c38cbdc87545..a3e579ee9962 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2161,8 +2161,8 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
>
> intel_dp_set_link_params(intel_dp, link_rate, lane_count,
> link_mst);
> - if (encoder->type == INTEL_OUTPUT_EDP)
> - intel_edp_panel_on(intel_dp);
> +
> + intel_edp_panel_on(intel_dp);
>
> intel_ddi_clk_select(encoder, pll);

--
Jani Nikula, Intel Open Source Technology Center