From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: add backwards compatibility support for drm_kms_helper.edid_firmware Date: Mon, 18 Sep 2017 22:29:17 +0300 Message-ID: <20170918192917.GG4914@intel.com> References: <20170915121521.GQ4914@intel.com> <20170918182003.22238-1-jani.nikula@intel.com> <20170918182003.22238-2-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170918182003.22238-2-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Abdiel Janulgue , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBTZXAgMTgsIDIwMTcgYXQgMDk6MjA6MDNQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gQWRkIGRybV9rbXNfaGVscGVyLmVkaWRfZmlybXdhcmUgbW9kdWxlIHBhcmFtZXRlciB3 aXRoIHBhcmFtIG9wcyBob29rcwo+IHRvIHNldCBkcm0uZWRpZF9maXJtd2FyZSBpbnN0ZWFkLCBm b3IgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBBYmRpZWwgSmFudWxn dWUgPGFiZGllbC5qYW51bGd1ZUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkX2xvYWQu YyAgICAgICAgIHwgMTYgKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2tt c19oZWxwZXJfY29tbW9uLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGlu Y2x1ZGUvZHJtL2RybV9lZGlkLmggICAgICAgICAgICAgICAgICB8ICAyICsrCj4gIDMgZmlsZXMg Y2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2VkaWRfbG9hZC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkX2xvYWQuYwo+IGlu ZGV4IDFjMDQ5NWFjZjM0MS4uYTQ5MTUwOTlhYWE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZWRpZF9sb2FkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWRfbG9h ZC5jCj4gQEAgLTMxLDYgKzMxLDIyIEBAIG1vZHVsZV9wYXJhbV9zdHJpbmcoZWRpZF9maXJtd2Fy ZSwgZWRpZF9maXJtd2FyZSwgc2l6ZW9mKGVkaWRfZmlybXdhcmUpLCAwNjQ0KTsKPiAgTU9EVUxF X1BBUk1fREVTQyhlZGlkX2Zpcm13YXJlLCAiRG8gbm90IHByb2JlIG1vbml0b3IsIHVzZSBzcGVj aWZpZWQgRURJRCBibG9iICIKPiAgCSJmcm9tIGJ1aWx0LWluIGRhdGEgb3IgL2xpYi9maXJtd2Fy ZSBpbnN0ZWFkLiAiKTsKPiAgCj4gKy8qIFVzZSBvbmx5IGZvciBiYWNrd2FyZCBjb21wYXRpYmls aXR5IHdpdGggZHJtX2ttc19oZWxwZXIuZWRpZF9maXJtd2FyZSAqLwo+ICtpbnQgX19kcm1fc2V0 X2VkaWRfZmlybXdhcmVfcGF0aChjb25zdCBjaGFyICpwYXRoKQo+ICt7Cj4gKwlzY25wcmludGYo ZWRpZF9maXJtd2FyZSwgc2l6ZW9mKGVkaWRfZmlybXdhcmUpLCAiJXMiLCBwYXRoKTsKPiArCj4g KwlyZXR1cm4gMDsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKF9fZHJtX3NldF9lZGlkX2Zpcm13YXJl X3BhdGgpOwo+ICsKPiArLyogVXNlIG9ubHkgZm9yIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgd2l0 aCBkcm1fa21zX2hlbHBlci5lZGlkX2Zpcm13YXJlICovCj4gK2ludCBfX2RybV9nZXRfZWRpZF9m aXJtd2FyZV9wYXRoKGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZnNpemUpCj4gK3sKPiArCXJldHVybiBz Y25wcmludGYoYnVmLCBidWZzaXplLCAiJXMiLCBlZGlkX2Zpcm13YXJlKTsKCkkgZ3Vlc3MgdGhl c2UgY291bGQganVzdCB1c2Ugc3RybGNweSgpIG9yIHNvbWV0aGluZy4KCj4gK30KPiArRVhQT1JU X1NZTUJPTChfX2RybV9nZXRfZWRpZF9maXJtd2FyZV9wYXRoKTsKPiArCj4gICNkZWZpbmUgR0VO RVJJQ19FRElEUyA2Cj4gIHN0YXRpYyBjb25zdCBjaGFyICogY29uc3QgZ2VuZXJpY19lZGlkX25h bWVbR0VORVJJQ19FRElEU10gPSB7Cj4gIAkiZWRpZC84MDB4NjAwLmJpbiIsCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fa21zX2hlbHBlcl9jb21tb24uYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fa21zX2hlbHBlcl9jb21tb24uYwo+IGluZGV4IDZlMzVhNTZhNjEwMi4uNTA1MWMz YWE0ZDVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fa21zX2hlbHBlcl9jb21t b24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fa21zX2hlbHBlcl9jb21tb24uYwo+IEBA IC0yNiw2ICsyNiw3IEBACj4gICAqLwo+ICAKPiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ ICsjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiAgCj4gICNpbmNsdWRlICJkcm1fY3J0Y19oZWxwZXJf aW50ZXJuYWwuaCIKPiAgCj4gQEAgLTMzLDYgKzM0LDMzIEBAIE1PRFVMRV9BVVRIT1IoIkRhdmlk IEFpcmxpZSwgSmVzc2UgQmFybmVzIik7Cj4gIE1PRFVMRV9ERVNDUklQVElPTigiRFJNIEtNUyBo ZWxwZXIiKTsKPiAgTU9EVUxFX0xJQ0VOU0UoIkdQTCBhbmQgYWRkaXRpb25hbCByaWdodHMiKTsK PiAgCj4gKyNpZiBJU19FTkFCTEVEKENPTkZJR19EUk1fTE9BRF9FRElEX0ZJUk1XQVJFKQo+ICsK PiArLyogQmFja3dhcmQgY29tcGF0aWJpbGl0eSBmb3IgZHJtX2ttc19oZWxwZXIuZWRpZF9maXJt d2FyZSAqLwo+ICtzdGF0aWMgaW50IGVkaWRfZmlybXdhcmVfc2V0KGNvbnN0IGNoYXIgKnZhbCwg Y29uc3Qgc3RydWN0IGtlcm5lbF9wYXJhbSAqa3ApCj4gK3sKPiArCURSTV9OT1RFKCJkcm1fa21z X2Zpcm13YXJlLmVkaWRfZmlybXdhcmUgaXMgZGVwcmVjYXRlZCwgcGxlYXNlIHVzZSBkcm0uZWRp ZF9maXJtd2FyZSBpbnRlYWQuXG4iKTsKPiArCj4gKwlyZXR1cm4gX19kcm1fc2V0X2VkaWRfZmly bXdhcmVfcGF0aCh2YWwpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGVkaWRfZmlybXdhcmVfZ2V0 KGNoYXIgKmJ1ZmZlciwgY29uc3Qgc3RydWN0IGtlcm5lbF9wYXJhbSAqa3ApCj4gK3sKPiArCXJl dHVybiBfX2RybV9nZXRfZWRpZF9maXJtd2FyZV9wYXRoKGJ1ZmZlciwgUEFHRV9TSVpFKTsKPiAr fQo+ICsKPiArY29uc3Qgc3RydWN0IGtlcm5lbF9wYXJhbV9vcHMgZWRpZF9maXJtd2FyZV9vcHMg PSB7Cj4gKwkuc2V0ID0gZWRpZF9maXJtd2FyZV9zZXQsCj4gKwkuZ2V0ID0gZWRpZF9maXJtd2Fy ZV9nZXQsCj4gK307Cj4gKwo+ICttb2R1bGVfcGFyYW1fY2IoZWRpZF9maXJtd2FyZSwgJmVkaWRf ZmlybXdhcmVfb3BzLCBOVUxMLCAwNjQ0KTsKCkRvIHdlIHdhbnQgdGhlIF9fcGFybV9jaGVjayB0 aGluZyBoZXJlPyBMb29rcyBsaWtlIGl0J3MganVzdCBzb21lIGtpbmQgb2YKY29tcGlsZSB0aW1l IHR5cGUgY2hlY2sgdGhvdWdoIHNvIG5vdCBjcml0aWNhbCBieSBhbnkgbWVhbnMuCgpPdGhlcndp c2UgbG9va3MgdGVjaG5pY2FsbHkgY29ycmVjdCBzbwpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gK19fTU9EVUxFX1BBUk1fVFlQ RShlZGlkX2Zpcm13YXJlLCAiY2hhcnAiKTsKPiArTU9EVUxFX1BBUk1fREVTQyhlZGlkX2Zpcm13 YXJlLAo+ICsJCSAiREVQUkVDQVRFRC4gVXNlIGRybS5lZGlkX2Zpcm13YXJlIG1vZHVsZSBwYXJh bWV0ZXIgaW5zdGVhZC4iKTsKPiArCj4gKyNlbmRpZgo+ICsKPiAgc3RhdGljIGludCBfX2luaXQg ZHJtX2ttc19oZWxwZXJfaW5pdCh2b2lkKQo+ICB7Cj4gIAlpbnQgcmV0Owo+IGRpZmYgLS1naXQg YS9pbmNsdWRlL2RybS9kcm1fZWRpZC5oIGIvaW5jbHVkZS9kcm0vZHJtX2VkaWQuaAo+IGluZGV4 IDFlMTkwOGE2YjFkNi4uNmYzNTkwOWI4YWRkIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2Ry bV9lZGlkLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fZWRpZC5oCj4gQEAgLTM0MSw2ICszNDEs OCBAQCBpbnQgZHJtX2F2X3N5bmNfZGVsYXkoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiAgCj4gICNpZmRlZiBDT05GSUdfRFJNX0xPQURfRURJRF9GSVJNV0FSRQo+ICBzdHJ1Y3Qg ZWRpZCAqZHJtX2xvYWRfZWRpZF9maXJtd2FyZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yKTsKPiAraW50IF9fZHJtX3NldF9lZGlkX2Zpcm13YXJlX3BhdGgoY29uc3QgY2hhciAqcGF0 aCk7Cj4gK2ludCBfX2RybV9nZXRfZWRpZF9maXJtd2FyZV9wYXRoKGNoYXIgKmJ1Ziwgc2l6ZV90 IGJ1ZnNpemUpOwo+ICAjZWxzZQo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBlZGlkICoKPiAgZHJt X2xvYWRfZWRpZF9maXJtd2FyZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+IC0t IAo+IDIuMTEuMAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==