Re: [PATCH v4 1/3] drm/i915/gvt: Add gvt_debug in i915_params for GVT-g log classification

[Shuo Liu <shuo.a.liu@intel.com>]

On Tue 19.Sep'17 at 12:11:28 +0300, Joonas Lahtinen wrote:
>The title should begin with "drm/i915:" not "drm/i915/gvt:".
My fault. Will correct it.
>
>On Tue, 2017-09-19 at 15:54 +0800, Shuo Liu wrote:
>
>Commit message is always needed.
OK, will add it.
>
>> Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
>
><SNIP>
>
>> @@ -65,6 +65,7 @@ struct i915_params i915 __read_mostly = {
>>  	.inject_load_failure = 0,
>>  	.enable_dpcd_backlight = false,
>>  	.enable_gvt = false,
>> +	.debug_gvt = 0,
>
>Let's try to keep the struct ordered.
What's the order? I see it's different with struct definition.
>
>> @@ -257,3 +258,15 @@ struct i915_params i915 __read_mostly = {
>>  module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
>>  MODULE_PARM_DESC(enable_gvt,
>>  	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
>> +
>> +module_param_named(debug_gvt, i915.debug_gvt, int, 0600);
>> +MODULE_PARM_DESC(debug_gvt, "Enable GVT-g debug output, where each bit enables a category.\n"
>> +		"\t\tBit 0 (0x01) will enable CORE messages (GVT-g core message)\n"
>> +		"\t\tBit 1 (0x02) will enable IRQ messages (GVT-g interrupt message)\n"
>> +		"\t\tBit 2 (0x04) will enable MM messages (GVT-g memory management message)\n"
>> +		"\t\tBit 3 (0x08) will enable MMIO messages (GVT-g MMIO message)\n"
>> +		"\t\tBit 4 (0x10) will enable DPY messages (GVT-g display message)\n"
>> +		"\t\tBit 5 (0x20) will enable EL messages (GVT-g execlist message)\n"
>> +		"\t\tBit 6 (0x40) will enable SCHED messages (GVT-g schedule message)\n"
>> +		"\t\tBit 7 (0x80) will enable RENDER messages (GVT-g render message)\n"
>> +		"\t\tBit 8 (0x100) will enable CMD messages (GVT-g command message)");
>
>s/message/code/ for the description in braces, like the drm
>counterpart. Or change them to be just "GVT-g core", "GVT-g
>scheduling", "GVT-g commands" etc.
Will change to "code".
>
>One tab indent is enough like mostly used in the file.
OK.

Thanks.
Shuo
>
>Regards, Joonas
>-- 
>Joonas Lahtinen
>Open Source Technology Center
>Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx