From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Marta Lofstedt <marta.lofstedt@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/kms_rotation_crc : Remove flip tests for sprite plane
Date: Tue, 19 Sep 2017 16:01:42 +0300 [thread overview]
Message-ID: <20170919130142.GP4914@intel.com> (raw)
In-Reply-To: <20170919123121.5628-1-marta.lofstedt@intel.com>
On Tue, Sep 19, 2017 at 03:31:21PM +0300, Marta Lofstedt wrote:
> The kms_rotation_crc@sprite-rotation-*-flip subtests, would need
> display engine blending to be setup inorder to work in the same
> manner as the respective tests for the primary plane.
Hmm. I don't see anything really blending related in there. It's
just using regular old XRGB framebuffers which means blending will
be off.
>
> Since, it is not the objective of the kms_rotation_crc to test our
> display blend capabilities, these subtests should be removed.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102691
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
> tests/kms_rotation_crc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 21e264ad..064d4293 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -647,9 +647,6 @@ igt_main
> { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_90, 0 },
> { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_180, 0 },
> { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_270, 0 },
> - { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_90, 1 },
> - { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_180, 1 },
> - { DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_270, 1 },
You didn't actually remove all of them.
> { DRM_PLANE_TYPE_CURSOR, IGT_ROTATION_180, 0 },
> { 0, 0, 0}
> };
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-19 13:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 12:31 [PATCH i-g-t] igt/kms_rotation_crc : Remove flip tests for sprite plane Marta Lofstedt
2017-09-19 13:01 ` Ville Syrjälä [this message]
2017-09-19 13:04 ` Lofstedt, Marta
2017-09-19 13:13 ` Ville Syrjälä
2017-09-19 13:16 ` Lofstedt, Marta
2017-09-19 13:52 ` Tvrtko Ursulin
2017-09-19 14:30 ` Ville Syrjälä
2017-09-20 11:33 ` Lofstedt, Marta
2017-09-20 11:40 ` [PATCH i-g-t] igt/kms_rotation_crc : Fix " Maarten Lankhorst
2017-09-21 6:38 ` Maarten Lankhorst
2017-09-21 11:21 ` Lofstedt, Marta
2017-09-20 0:16 ` ✗ Fi.CI.BAT: failure for igt/kms_rotation_crc : Remove " Patchwork
2017-09-21 7:05 ` ✓ Fi.CI.BAT: success for igt/kms_rotation_crc : Remove flip tests for sprite plane (rev3) Patchwork
2017-09-21 8:06 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919130142.GP4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=marta.lofstedt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox