Re: [PATCH i-g-t] igt/kms_rotation_crc : Remove flip tests for sprite plane

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Sep 19, 2017 at 04:01:42PM +0300, Ville Syrjälä wrote:
> On Tue, Sep 19, 2017 at 03:31:21PM +0300, Marta Lofstedt wrote:
> > The kms_rotation_crc@sprite-rotation-*-flip subtests, would need
> > display engine blending to be setup inorder to work in the same
> > manner as the respective tests for the primary plane.
> 
> Hmm. I don't see anything really blending related in there. It's
> just using regular old XRGB framebuffers which means blending will
> be off.

OK. So the actual problem is that the test calls drmModePageFlip()
expecting it to magically do something for the sprite plane.
drmModePageFlip() by definition only operates on the primary plane of
the crtc. So the fix looks correct (ie. get rid of the "flip" tests for
the sprite planes) but the commit message is incorrect. This also
explains why you only had to remove the tests with flip==1 and didn't
have to remove the flip==0 tests.

> 
> > 
> > Since, it is not the objective of the kms_rotation_crc to test our
> > display blend capabilities, these subtests should be removed.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102691
> > 
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > ---
> >  tests/kms_rotation_crc.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > index 21e264ad..064d4293 100644
> > --- a/tests/kms_rotation_crc.c
> > +++ b/tests/kms_rotation_crc.c
> > @@ -647,9 +647,6 @@ igt_main
> >  		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_90, 0 },
> >  		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_180, 0 },
> >  		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_270, 0 },
> > -		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_90, 1 },
> > -		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_180, 1 },
> > -		{ DRM_PLANE_TYPE_OVERLAY, IGT_ROTATION_270, 1 },
> 
> You didn't actually remove all of them.
> 
> >  		{ DRM_PLANE_TYPE_CURSOR, IGT_ROTATION_180, 0 },
> >  		{ 0, 0, 0}
> >  	};
> > -- 
> > 2.11.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel OTC

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx