From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v3. Date: Tue, 19 Sep 2017 16:38:08 +0300 Message-ID: <20170919133808.GT4914@intel.com> References: <20170919121419.13708-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 128706E138 for ; Tue, 19 Sep 2017 13:38:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170919121419.13708-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTksIDIwMTcgYXQgMDI6MTQ6MThQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQ29tbWl0IGI0NGQ1YzBjMTA1YSAoImRybS9pOTE1OiBBbHdheXMgd2FpdCBm b3IgZmxpcF9kb25lLCB2Mi4iKSByZW1vdmVkCj4gdGhlIGNhbGwgdG8gd2FpdF9mb3JfdmJsYW5r cyBhbmQgcmVwbGFjZWQgaXQgd2l0aCBmbGlwX2RvbmUuCj4gCj4gVW5mb3J0dW5hdGVseSBsZWdh Y3lfY3Vyc29yX3VwZGF0ZSB3YXMgdW5zZXQgdG9vIGxhdGUsIGFuZCB0aGUKPiByZXBsYWNlbWVu dCBjYWxsIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIHdhcwo+IGEgbm9v cC4gTWFrZSBzdXJlIHRoYXQgaXRzIHVuc2V0IGJlZm9yZSBzZXR1cF9jb21taXQoKSBpcwo+IGNh bGxlZCB0byBmaXggdGhpcyBpc3N1ZS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gRm9yY2Ug dmJsYW5rIHdhaXQgZm9yIHdhdGVybWFya3Mgbm90IHlldCBjb252ZXJ0ZWQgdG8gYXRvbWljIHRv by4gKFZpbGxlKQo+IC0gVXNlIGZvcl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmls bGUpCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAtIE1vdmUgdGhlIG9wdGltaXphdGlvbiB0byBhIHNl cGFyYXRlIGNvbW1pdC4gKFZpbGxlKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hv cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gRml4ZXM6IGI0NGQ1YzBj MTA1YSAoImRybS9pOTE1OiBBbHdheXMgd2FpdCBmb3IgZmxpcF9kb25lLCB2Mi4iKQo+IEJ1Z3pp bGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NzUK PiBUZXN0Y2FzZToga21zX2N1cnNvcl9jcmMKPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4KPiBSZXBvcnRlZC1ieTogTWFydGEgTMO2ZnN0ZWR0IDxtYXJ0YS5sb2ZzdGVkdEBpbnRl bC5jb20+Cj4gQ2M6IE1hcnRhIEzDtmZzdGVkdCA8bWFydGEubG9mc3RlZHRAaW50ZWwuY29tPgo+ IFRlc3RlZC1ieTogTWFydGEgTMO2ZnN0ZWR0IDxtYXJ0YS5sb2ZzdGVkdEBpbnRlbC5jb20+Cj4g Q2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDMzICsrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygr KSwgMTcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IGluZGV4IDg1OTllNDI1YWJiMS4uYTg1Y2ExOWEwYzQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMjUxNywyMSArMTI1MTcsMTAgQEAgc3RhdGljIGludCBp bnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gIAlpbnQgcmV0ID0gMDsK PiAgCj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RhdGUsIG5vbmJs b2NrKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4gIAlkcm1fYXRvbWljX3N0 YXRlX2dldChzdGF0ZSk7Cj4gIAlpOTE1X3N3X2ZlbmNlX2luaXQoJmludGVsX3N0YXRlLT5jb21t aXRfcmVhZHksCj4gIAkJCSAgIGludGVsX2F0b21pY19jb21taXRfcmVhZHkpOwo+ICAKPiAtCXJl dCA9IGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdChkZXYsIHN0YXRlKTsKPiAtCWlmIChyZXQp IHsKPiAtCQlEUk1fREVCVUdfQVRPTUlDKCJQcmVwYXJpbmcgc3RhdGUgZmFpbGVkIHdpdGggJWlc biIsIHJldCk7Cj4gLQkJaTkxNV9zd19mZW5jZV9jb21taXQoJmludGVsX3N0YXRlLT5jb21taXRf cmVhZHkpOwo+IC0JCXJldHVybiByZXQ7Cj4gLQl9Cj4gLQo+ICAJLyoKPiAgCSAqIFRoZSBpbnRl bF9sZWdhY3lfY3Vyc29yX3VwZGF0ZSgpIGZhc3QgcGF0aCB0YWtlcyBjYXJlCj4gIAkgKiBvZiBh dm9pZGluZyB0aGUgdmJsYW5rIHdhaXRzIGZvciBzaW1wbGUgY3Vyc29yCj4gQEAgLTEyNTQwLDEx ICsxMjUyOSwxMSBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCSAqIHVwZGF0ZXMgaGFwcGVuIGR1cmluZyB0aGUgY29ycmVjdCBmcmFt ZXMuIEdlbjkrIGhhdmUKPiAgCSAqIGRvdWJsZSBidWZmZXJlZCB3YXRlcm1hcmtzIGFuZCBzbyBz aG91bGRuJ3QgbmVlZCB0aGlzLgo+ICAJICoKPiAtCSAqIERvIHRoaXMgYWZ0ZXIgZHJtX2F0b21p Y19oZWxwZXJfc2V0dXBfY29tbWl0KCkgYW5kCj4gLQkgKiBpbnRlbF9hdG9taWNfcHJlcGFyZV9j b21taXQoKSBiZWNhdXNlIHdlIHN0aWxsIHdhbnQKPiAtCSAqIHRvIHNraXAgdGhlIGZsaXAgYW5k IGZiIGNsZWFudXAgd2FpdHMuIEFsdGhvdWdoIHRoYXQKPiAtCSAqIGRvZXMgcmlzayB5YW5raW5n IHRoZSBtYXBwaW5nIGZyb20gdW5kZXIgdGhlIGRpc3BsYXkKPiAtCSAqIGVuZ2luZS4KPiArCSAq IFVuc2V0IHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSBiZWZvcmUgdGhlIGNhbGwgdG8KPiAr CSAqIGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCgpIGJlY2F1c2Ugb3RoZXJ3aXNlCj4g KwkgKiBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoKSBpcyBhIG5vb3AgYW5k Cj4gKwkgKiB3ZSBnZXQgRklGTyB1bmRlcnJ1bnMgYmVjYXVzZSB3ZSBkaWRuJ3Qgd2FpdAo+ICsJ ICogZm9yIHZibGFuay4KPiAgCSAqCj4gIAkgKiBGSVhNRSBkb2luZyB3YXRlcm1hcmtzIGFuZCBm YiBjbGVhbnVwIGZyb20gYSB2Ymxhbmsgd29ya2VyCj4gIAkgKiAoYXNzdW1pbmcgd2UgaGFkIGFu eSkgd291bGQgc29sdmUgdGhlc2UgcHJvYmxlbXMuCj4gQEAgLTEyNTUyLDcgKzEyNTQxLDE3IEBA IHN0YXRpYyBpbnQgaW50ZWxfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+ICAJCXN0YXRlLT5sZWdhY3lfY3Vyc29y X3VwZGF0ZSA9IGZhbHNlOwo+ICAKPiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3N3YXBfc3Rh dGUoc3RhdGUsIHRydWUpOwo+ICsJcmV0ID0gaW50ZWxfYXRvbWljX3ByZXBhcmVfY29tbWl0KGRl diwgc3RhdGUpOwo+ICsJaWYgKHJldCkgewo+ICsJCURSTV9ERUJVR19BVE9NSUMoIlByZXBhcmlu ZyBzdGF0ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiArCQlpOTE1X3N3X2ZlbmNlX2NvbW1p dCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiAr Cj4gKwlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RhdGUsIG5vbmJsb2Nr KTsKCkhtbS4gT25lIHRoaW5nIEkgbm90aWNlZCBoZXJlLiBQcmV2aW91c2x5IGlmIHRoaXMgZmFp bGVkIHdlIGp1c3QgY2FsbGVkCmk5MTVfc3dfZmVuY2VfY29tbWl0KCkuIE5vdyB3ZSB3aWxsIGFs c28gY2FsbApkcm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcygpLiBJcyB0aGF0IGdvaW5n IHRvIGJlIGEgcHJvYmxlbT8KCj4gKwlpZiAoIXJldCkKPiArCQlyZXQgPSBkcm1fYXRvbWljX2hl bHBlcl9zd2FwX3N0YXRlKHN0YXRlLCB0cnVlKTsKPiArCj4gIAlpZiAocmV0KSB7Cj4gIAkJaTkx NV9zd19mZW5jZV9jb21taXQoJmludGVsX3N0YXRlLT5jb21taXRfcmVhZHkpOwo+ICAKPiAtLSAK PiAyLjE0LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=