From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v3. Date: Tue, 19 Sep 2017 17:15:53 +0300 Message-ID: <20170919141553.GV4914@intel.com> References: <20170919121419.13708-1-maarten.lankhorst@linux.intel.com> <20170919133808.GT4914@intel.com> <549b6da0-a49d-a124-f309-4dee2e34fec3@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E6F4A6E5A7 for ; Tue, 19 Sep 2017 14:16:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <549b6da0-a49d-a124-f309-4dee2e34fec3@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTksIDIwMTcgYXQgMDM6NTA6NDdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTktMDktMTcgb20gMTU6Mzggc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUdWUsIFNlcCAxOSwgMjAxNyBhdCAwMjoxNDoxOFBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBDb21taXQgYjQ0ZDVjMGMxMDVhICgiZHJtL2k5MTU6IEFsd2F5 cyB3YWl0IGZvciBmbGlwX2RvbmUsIHYyLiIpIHJlbW92ZWQKPiA+PiB0aGUgY2FsbCB0byB3YWl0 X2Zvcl92YmxhbmtzIGFuZCByZXBsYWNlZCBpdCB3aXRoIGZsaXBfZG9uZS4KPiA+Pgo+ID4+IFVu Zm9ydHVuYXRlbHkgbGVnYWN5X2N1cnNvcl91cGRhdGUgd2FzIHVuc2V0IHRvbyBsYXRlLCBhbmQg dGhlCj4gPj4gcmVwbGFjZW1lbnQgY2FsbCBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlw X2RvbmUoKSB3YXMKPiA+PiBhIG5vb3AuIE1ha2Ugc3VyZSB0aGF0IGl0cyB1bnNldCBiZWZvcmUg c2V0dXBfY29tbWl0KCkgaXMKPiA+PiBjYWxsZWQgdG8gZml4IHRoaXMgaXNzdWUuCj4gPj4KPiA+ PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4+IC0gRm9yY2UgdmJsYW5rIHdhaXQgZm9yIHdhdGVybWFy a3Mgbm90IHlldCBjb252ZXJ0ZWQgdG8gYXRvbWljIHRvby4gKFZpbGxlKQo+ID4+IC0gVXNlIGZv cl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmlsbGUpCj4gPj4gQ2hhbmdlcyBzaW5j ZSB2MjoKPiA+PiAtIE1vdmUgdGhlIG9wdGltaXphdGlvbiB0byBhIHNlcGFyYXRlIGNvbW1pdC4g KFZpbGxlKQo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiBGaXhlczogYjQ0ZDVjMGMxMDVhICgi ZHJtL2k5MTU6IEFsd2F5cyB3YWl0IGZvciBmbGlwX2RvbmUsIHYyLiIpCj4gPj4gQnVnemlsbGE6 IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjY3NQo+ID4+ IFRlc3RjYXNlOiBrbXNfY3Vyc29yX2NyYwo+ID4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+ID4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXgu aW50ZWwuY29tPgo+ID4+IFJlcG9ydGVkLWJ5OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0 ZWR0QGludGVsLmNvbT4KPiA+PiBDYzogTWFydGEgTMO2ZnN0ZWR0IDxtYXJ0YS5sb2ZzdGVkdEBp bnRlbC5jb20+Cj4gPj4gVGVzdGVkLWJ5OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0 QGludGVsLmNvbT4KPiA+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgMzMgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmls ZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBpbmRleCA4NTk5ZTQyNWFiYjEuLmE4 NWNhMTlhMGM0NSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+PiBAQCAtMTI1MTcsMjEgKzEyNTE3LDEwIEBAIHN0YXRpYyBpbnQgaW50ZWxfYXRvbWljX2Nv bW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ID4+ICAJaW50IHJldCA9IDA7Cj4gPj4gIAo+ ID4+IC0JcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc2V0dXBfY29tbWl0KHN0YXRlLCBub25ibG9j ayk7Cj4gPj4gLQlpZiAocmV0KQo+ID4+IC0JCXJldHVybiByZXQ7Cj4gPj4gLQo+ID4+ICAJZHJt X2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOwo+ID4+ICAJaTkxNV9zd19mZW5jZV9pbml0KCZpbnRl bF9zdGF0ZS0+Y29tbWl0X3JlYWR5LAo+ID4+ICAJCQkgICBpbnRlbF9hdG9taWNfY29tbWl0X3Jl YWR5KTsKPiA+PiAgCj4gPj4gLQlyZXQgPSBpbnRlbF9hdG9taWNfcHJlcGFyZV9jb21taXQoZGV2 LCBzdGF0ZSk7Cj4gPj4gLQlpZiAocmV0KSB7Cj4gPj4gLQkJRFJNX0RFQlVHX0FUT01JQygiUHJl cGFyaW5nIHN0YXRlIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+ID4+IC0JCWk5MTVfc3dfZmVu Y2VfY29tbWl0KCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5KTsKPiA+PiAtCQlyZXR1cm4gcmV0 Owo+ID4+IC0JfQo+ID4+IC0KPiA+PiAgCS8qCj4gPj4gIAkgKiBUaGUgaW50ZWxfbGVnYWN5X2N1 cnNvcl91cGRhdGUoKSBmYXN0IHBhdGggdGFrZXMgY2FyZQo+ID4+ICAJICogb2YgYXZvaWRpbmcg dGhlIHZibGFuayB3YWl0cyBmb3Igc2ltcGxlIGN1cnNvcgo+ID4+IEBAIC0xMjU0MCwxMSArMTI1 MjksMTEgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gPj4gIAkgKiB1cGRhdGVzIGhhcHBlbiBkdXJpbmcgdGhlIGNvcnJlY3QgZnJhbWVz LiBHZW45KyBoYXZlCj4gPj4gIAkgKiBkb3VibGUgYnVmZmVyZWQgd2F0ZXJtYXJrcyBhbmQgc28g c2hvdWxkbid0IG5lZWQgdGhpcy4KPiA+PiAgCSAqCj4gPj4gLQkgKiBEbyB0aGlzIGFmdGVyIGRy bV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCgpIGFuZAo+ID4+IC0JICogaW50ZWxfYXRvbWlj X3ByZXBhcmVfY29tbWl0KCkgYmVjYXVzZSB3ZSBzdGlsbCB3YW50Cj4gPj4gLQkgKiB0byBza2lw IHRoZSBmbGlwIGFuZCBmYiBjbGVhbnVwIHdhaXRzLiBBbHRob3VnaCB0aGF0Cj4gPj4gLQkgKiBk b2VzIHJpc2sgeWFua2luZyB0aGUgbWFwcGluZyBmcm9tIHVuZGVyIHRoZSBkaXNwbGF5Cj4gPj4g LQkgKiBlbmdpbmUuCj4gPj4gKwkgKiBVbnNldCBzdGF0ZS0+bGVnYWN5X2N1cnNvcl91cGRhdGUg YmVmb3JlIHRoZSBjYWxsIHRvCj4gPj4gKwkgKiBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21t aXQoKSBiZWNhdXNlIG90aGVyd2lzZQo+ID4+ICsJICogZHJtX2F0b21pY19oZWxwZXJfd2FpdF9m b3JfZmxpcF9kb25lKCkgaXMgYSBub29wIGFuZAo+ID4+ICsJICogd2UgZ2V0IEZJRk8gdW5kZXJy dW5zIGJlY2F1c2Ugd2UgZGlkbid0IHdhaXQKPiA+PiArCSAqIGZvciB2YmxhbmsuCj4gPj4gIAkg Kgo+ID4+ICAJICogRklYTUUgZG9pbmcgd2F0ZXJtYXJrcyBhbmQgZmIgY2xlYW51cCBmcm9tIGEg dmJsYW5rIHdvcmtlcgo+ID4+ICAJICogKGFzc3VtaW5nIHdlIGhhZCBhbnkpIHdvdWxkIHNvbHZl IHRoZXNlIHByb2JsZW1zLgo+ID4+IEBAIC0xMjU1Miw3ICsxMjU0MSwxNyBAQCBzdGF0aWMgaW50 IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiAgCWlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpIDwgOSkKPiA+PiAgCQlzdGF0ZS0+bGVnYWN5X2N1cnNvcl91cGRh dGUgPSBmYWxzZTsKPiA+PiAgCj4gPj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9zd2FwX3N0 YXRlKHN0YXRlLCB0cnVlKTsKPiA+PiArCXJldCA9IGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1p dChkZXYsIHN0YXRlKTsKPiA+PiArCWlmIChyZXQpIHsKPiA+PiArCQlEUk1fREVCVUdfQVRPTUlD KCJQcmVwYXJpbmcgc3RhdGUgZmFpbGVkIHdpdGggJWlcbiIsIHJldCk7Cj4gPj4gKwkJaTkxNV9z d19mZW5jZV9jb21taXQoJmludGVsX3N0YXRlLT5jb21taXRfcmVhZHkpOwo+ID4+ICsJCXJldHVy biByZXQ7Cj4gPj4gKwl9Cj4gPj4gKwo+ID4+ICsJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc2V0 dXBfY29tbWl0KHN0YXRlLCBub25ibG9jayk7Cj4gPiBIbW0uIE9uZSB0aGluZyBJIG5vdGljZWQg aGVyZS4gUHJldmlvdXNseSBpZiB0aGlzIGZhaWxlZCB3ZSBqdXN0IGNhbGxlZAo+ID4gaTkxNV9z d19mZW5jZV9jb21taXQoKS4gTm93IHdlIHdpbGwgYWxzbyBjYWxsCj4gPiBkcm1fYXRvbWljX2hl bHBlcl9jbGVhbnVwX3BsYW5lcygpLiBJcyB0aGF0IGdvaW5nIHRvIGJlIGEgcHJvYmxlbT8KPiBU aGlzIGlzIGludGVudGlvbmFsLCBpbnRlbF9hdG9taWNfcHJlcGFyZV9jb21taXQgY2FsbHMgcHJl cGFyZV9wbGFuZXMsCj4gaWYgdGhhdCBzdWNjZWVkcyB3ZSdsbCBuZWVkIHRvIGNhbGwgY2xlYW51 cF9wbGFuZXMgdG9vLgoKRG9oLiBSaWdodC4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAKPiBPcmRlcmluZyBvZiBzZXR1cF9j b21taXQgYW5kIHByZXBhcmVfcGxhbmVzIGRvZXNuJ3QgbWF0dGVyLgo+ID4+ICsJaWYgKCFyZXQp Cj4gPj4gKwkJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7 Cj4gPj4gKwo+ID4+ICAJaWYgKHJldCkgewo+ID4+ICAJCWk5MTVfc3dfZmVuY2VfY29tbWl0KCZp bnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5KTsKPiA+PiAgCj4gPj4gLS0gCj4gPj4gMi4xNC4xCj4g CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK