From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915/cnl: Add Gen10 LRC size
Date: Fri, 22 Sep 2017 06:29:14 -0700 [thread overview]
Message-ID: <20170922132914.g2hdfkf6t44eubut@intel.com> (raw)
In-Reply-To: <1506035989-14295-1-git-send-email-oscar.mateo@intel.com>
On Thu, Sep 21, 2017 at 11:19:49PM +0000, Oscar Mateo wrote:
> The total size of the context has decreased with the removal of the
> URB_ATOMIC section. BSpec indicates 16750 DWORDs (17 pages), plus
> one page for PPHWSP, and I'm throwing an extra page for precaution.
I could never find this info on bspec... could you please point that to
me?
Anyways this value matches with other HW engineers had told me a while
ago, and we now have CNL on CI, so:
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 3d135c3..a3115f3 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -39,6 +39,7 @@
>
> #define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)
> #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
> +#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)
>
> #define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
>
> @@ -150,6 +151,7 @@ struct engine_info {
> default:
> MISSING_CASE(INTEL_GEN(dev_priv));
> case 10:
> + return GEN10_LR_CONTEXT_RENDER_SIZE;
> case 9:
> return GEN9_LR_CONTEXT_RENDER_SIZE;
> case 8:
> --
> 1.9.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-22 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 23:19 [PATCH] drm/i915/cnl: Add Gen10 LRC size Oscar Mateo
2017-09-22 10:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-22 12:39 ` ✓ Fi.CI.IGT: " Patchwork
2017-09-22 13:29 ` Rodrigo Vivi [this message]
2017-09-22 14:21 ` [PATCH] " Rodrigo Vivi
2017-09-29 10:24 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922132914.g2hdfkf6t44eubut@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox