From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: add the BXT and CNL DPLL registers to pipe_config_compare
Date: Mon, 25 Sep 2017 16:16:24 -0700 [thread overview]
Message-ID: <20170925231624.uo4656ntciq3e6nu@intel.com> (raw)
In-Reply-To: <20170922205343.16006-2-paulo.r.zanoni@intel.com>
Shouldn't we filter them out per platform?
Anyways it is good for me
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
On Fri, Sep 22, 2017 at 08:53:42PM +0000, Paulo Zanoni wrote:
> Looks like we were missing them.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 026fa54..64a4105 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11336,6 +11336,18 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
> PIPE_CONF_CHECK_X(dpll_hw_state.ctrl1);
> PIPE_CONF_CHECK_X(dpll_hw_state.cfgcr1);
> PIPE_CONF_CHECK_X(dpll_hw_state.cfgcr2);
> + PIPE_CONF_CHECK_X(dpll_hw_state.cfgcr0);
> + PIPE_CONF_CHECK_X(dpll_hw_state.ebb0);
> + PIPE_CONF_CHECK_X(dpll_hw_state.ebb4);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll0);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll1);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll2);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll3);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll6);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll8);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll9);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pll10);
> + PIPE_CONF_CHECK_X(dpll_hw_state.pcsdw12);
>
> PIPE_CONF_CHECK_X(dsi_pll.ctrl);
> PIPE_CONF_CHECK_X(dsi_pll.div);
> --
> 2.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-25 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 20:53 [PATCH 0/2] Add missing BXT/CNL DPLL debugging/checking code Paulo Zanoni
2017-09-22 20:53 ` [PATCH 1/2] drm/i915: add the BXT and CNL DPLL registers to pipe_config_compare Paulo Zanoni
2017-09-25 23:16 ` Rodrigo Vivi [this message]
2017-09-25 23:47 ` Paulo Zanoni
2017-09-22 20:53 ` [PATCH 2/2] drm/i915: add missing DPLL fields to i915_shared_dplls_info Paulo Zanoni
2017-09-25 23:21 ` Rodrigo Vivi
2017-09-22 21:23 ` ✗ Fi.CI.BAT: failure for Add missing BXT/CNL DPLL debugging/checking code Patchwork
2017-09-23 8:05 ` ✓ Fi.CI.BAT: success " Patchwork
2017-09-23 9:19 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925231624.uo4656ntciq3e6nu@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox