From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Avoid using dev_priv->info.gen directly. Date: Tue, 26 Sep 2017 14:47:09 -0700 Message-ID: <20170926214709.2fvs4fosv4g5d2xn@intel.com> References: <20170926211346.12009-1-rodrigo.vivi@intel.com> <1506460903.2634.12.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFBC46E2D9 for ; Tue, 26 Sep 2017 21:47:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1506460903.2634.12.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Hans de Goede , Daniel Vetter , Lyude List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMjYsIDIwMTcgYXQgMDk6MjE6NDNQTSArMDAwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEVtIFRlciwgMjAxNy0wOS0yNiDDoHMgMTQ6MTMgLTA3MDAsIFJvZHJpZ28gVml2aSBl c2NyZXZldToKPiA+IExldCdzIHN0b3AgdGhpcyB1c2FnZSBiZWZvcmUgaXQgc3ByZWFkcyBzbyBt dWNoLgo+ID4gCj4gPiAxLiBUaGlzIGNoZWNrIGlzIG5vdCBwYXJ0IG9mIHVzdWFsIHNlYXJjaGVz IGhhcHBlbmluZyB3aGVuIGFkZGluZwo+ID4gbmV3IHBsYXRmb3JtLgo+ID4gMi4gVGhlcmUgaXMg YWxyZWFkeSBhIGR1cGxpY2F0aW9uIGhlcmUgd2l0aCBJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2Vu Cj4gPiBhbmQgSU5URUxfR0VOKGRldl9wcml2KS4KPiA+IAo+ID4gU28gbGV0J3MgcGxlYXNlIGF2 b2lkIHlldCBhbm90aGVyIHdheS4KPiA+IAo+ID4gRml4ZXM6IGIyMmNhOTk1YmExYyAoImRybS9p OTE1OiBwcmVwYXJlIHBpcGUgZm9yIFlDQkNSNDIwIG91dHB1dCIpCj4gPiBGaXhlczogMjcwODI0 OTNlOWM2ICgiZHJtL2k5MTUvc2tsOiBVcGRhdGUgRERCIHZhbHVlcyBhdG9taWNhbGx5IHdpdGgK PiA+IHdtcy9wbGFuZSBhdHRycyIpCj4gCj4gTm90IHN1cmUgaWYgdGhlIEZpeGVzIHRhZ3MgYXJl IGFwcHJvcHJpYXRlIHNpbmNlIHRoaXMgaXMgbm90IGEgYnVnIGZpeC4KCkkgd29uZGVyZWQgdGhh dC4uLiBidXQgc2luY2UgImRpbSBmaXhlcyIgcHJvdmlkZWQgbWUgdGhhdCB0YWcgYWxvbmcgd2l0 aCB0aGUKbGlzdCBvZiBwZW9wbGUgSSBzaG91bGQgY2MgSSBkZWNpZGVkIHRvIGluY2x1ZGUgaGVy ZS4gSSB0aG91Z2h0IGl0CndvdWxkbid0IGh1cnQgYW5kIGFsc28gbWF5YmUgZ29vZCB0byBwcm9w YWdhdGUgdGhhdCB0byBldmVyeXdoZXJlIHBvc3NpYmxlIHNvCndlIGRvbid0IHJlY2lldmUgbW9y ZSBjb2RlIGJhc2VkIG9uIHRoYXQgdXNhZ2UuCgpCdXQgSSB3b24ndCBtZXJnZSB0b2RheSB0byBn aXZlIHRpbWUgdG8gZ2V0IEphbmkncyB2aWV3IG9uIHRoYXQuCgo+IAo+IFJldmlld2VkLWJ5OiBQ YXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiAKPiA+IENjOiBMeXVkZSA8 Y3BhdWxAcmVkaGF0LmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50 ZWwuY29tPgo+ID4gQ2M6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWtyaXNobmEuc3JpcGFk YUBpbnRlbC5jb20+Cj4gPiBDYzogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4K PiA+IENjOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+ID4gQ2M6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBD YzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPiBDYzogVmlsbGUg U3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogSW1yZSBEZWFr IDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gQ2M6IFNoYXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsu c2hhcm1hQGludGVsLmNvbT4KPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXgu aW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlA aW50ZWwuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDYgKysrLS0tCj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gPiBpbmRleCA0ODdiNDNiYTMxMzkuLmZiYTc2ZjFiYjZkZCAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtOTMxMCwxMSArOTMxMCwxMSBAQCBzdGF0 aWMgYm9vbCBoYXN3ZWxsX2dldF9waXBlX2NvbmZpZyhzdHJ1Y3QKPiA+IGludGVsX2NydGMgKmNy dGMsCj4gPiDCoAlwaXBlX2NvbmZpZy0+Z2FtbWFfbW9kZSA9Cj4gPiDCoAkJSTkxNV9SRUFEKEdB TU1BX01PREUoY3J0Yy0+cGlwZSkpICYKPiA+IEdBTU1BX01PREVfTU9ERV9NQVNLOwo+ID4gwqAK PiA+IC0JaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgZGV2X3ByaXYtPmluZm8uZ2VuID49 IDkpIHsKPiA+ICsJaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9w cml2KSA+PSA5KSB7Cj4gPiDCoAkJdTMyIHRtcCA9IEk5MTVfUkVBRChQSVBFTUlTQyhjcnRjLT5w aXBlKSk7Cj4gPiDCoAkJYm9vbCBjbHJzcGFjZV95dXYgPSB0bXAgJgo+ID4gUElQRU1JU0NfT1VU UFVUX0NPTE9SU1BBQ0VfWVVWOwo+ID4gwqAKPiA+IC0JCWlmIChJU19HRU1JTklMQUtFKGRldl9w cml2KSB8fCBkZXZfcHJpdi0+aW5mby5nZW4gPj0KPiA+IDEwKSB7Cj4gPiArCQlpZiAoSVNfR0VN SU5JTEFLRShkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KQo+ID4gPj0gMTApIHsKPiA+ IMKgCQkJYm9vbCBibGVuZF9tb2RlXzQyMCA9IHRtcCAmCj4gPiDCoAkJCQkJwqDCoMKgwqDCoMKg UElQRU1JU0NfWVVWNDIwX01PREVfRgo+ID4gVUxMX0JMRU5EOwo+ID4gwqAKPiA+IEBAIC0xNDIx Nyw3ICsxNDIxNyw3IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVjdAo+ID4g ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZmRp X2xpbmtfdHJhaW4gPQo+ID4gaHN3X2ZkaV9saW5rX3RyYWluOwo+ID4gwqAJfQo+ID4gwqAKPiA+ IC0JaWYgKGRldl9wcml2LT5pbmZvLmdlbiA+PSA5KQo+ID4gKwlpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSA5KQo+ID4gwqAJCWRldl9wcml2LT5kaXNwbGF5LnVwZGF0ZV9jcnRjcyA9IHNrbF91 cGRhdGVfY3J0Y3M7Cj4gPiDCoAllbHNlCj4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkudXBkYXRl X2NydGNzID0gaW50ZWxfdXBkYXRlX2NydGNzOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK