intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 03/21] drm/i915/gemfs: enable THP
Date: Fri, 29 Sep 2017 17:10:14 +0100	[thread overview]
Message-ID: <20170929161032.24394-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20170929161032.24394-1-matthew.auld@intel.com>

Enable transparent-huge-pages through gemfs by mounting with
huge=within_size.

v2: sprinkle within_size comment

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gemfs.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/drivers/gpu/drm/i915/i915_gemfs.c
index 168d0bd98f60..b1b4d13d8f97 100644
--- a/drivers/gpu/drm/i915/i915_gemfs.c
+++ b/drivers/gpu/drm/i915/i915_gemfs.c
@@ -24,6 +24,7 @@
 
 #include <linux/fs.h>
 #include <linux/mount.h>
+#include <linux/pagemap.h>
 
 #include "i915_drv.h"
 #include "i915_gemfs.h"
@@ -41,6 +42,26 @@ int i915_gemfs_init(struct drm_i915_private *i915)
 	if (IS_ERR(gemfs))
 		return PTR_ERR(gemfs);
 
+	/*
+	 * Enable huge-pages for objects that are at least HPAGE_PMD_SIZE, most
+	 * likely 2M. Note that within_size may overallocate huge-pages, if say
+	 * we allocate an object of size 2M + 4K, but under memory pressure
+	 * should split any huge-pages which can be shrunk.
+	 */
+
+	if (has_transparent_hugepage()) {
+		struct super_block *sb = gemfs->mnt_sb;
+		char options[] = "huge=within_size";
+		int flags = 0;
+		int err;
+
+		err = sb->s_op->remount_fs(sb, &flags, options);
+		if (err) {
+			kern_unmount(gemfs);
+			return err;
+		}
+	}
+
 	i915->mm.gemfs = gemfs;
 
 	return 0;
-- 
2.13.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-09-29 16:10 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 16:10 [PATCH 00/21] huge gtt pages Matthew Auld
2017-09-29 16:10 ` [PATCH 01/21] mm/shmem: introduce shmem_file_setup_with_mnt Matthew Auld
2017-09-29 16:10 ` [PATCH 02/21] drm/i915: introduce simple gemfs Matthew Auld
2017-10-02 11:55   ` Joonas Lahtinen
2017-09-29 16:10 ` Matthew Auld [this message]
2017-09-29 16:18   ` [PATCH 03/21] drm/i915/gemfs: enable THP Chris Wilson
2017-10-02 12:05   ` Joonas Lahtinen
2017-09-29 16:10 ` [PATCH 04/21] drm/i915: introduce page_sizes field to dev_info Matthew Auld
2017-09-29 16:10 ` [PATCH 05/21] drm/i915: push set_pages down to the callers Matthew Auld
2017-09-29 16:10 ` [PATCH 06/21] drm/i915: introduce page_size members Matthew Auld
2017-09-29 21:31   ` Chris Wilson
2017-10-03 16:32     ` Chris Wilson
2017-09-29 16:10 ` [PATCH 07/21] drm/i915: introduce vm set_pages/clear_pages Matthew Auld
2017-10-02 12:10   ` Joonas Lahtinen
2017-09-29 16:10 ` [PATCH 08/21] drm/i915: align the vma start to the largest gtt page size Matthew Auld
2017-10-02 12:16   ` Joonas Lahtinen
2017-09-29 16:10 ` [PATCH 09/21] drm/i915: align 64K objects to 2M Matthew Auld
2017-10-02 12:18   ` Joonas Lahtinen
2017-09-29 16:10 ` [PATCH 10/21] drm/i915: enable IPS bit for 64K pages Matthew Auld
2017-10-02 12:21   ` Joonas Lahtinen
2017-09-29 16:10 ` [PATCH 11/21] drm/i915: disable GTT cache for 2M pages Matthew Auld
2017-10-02 12:31   ` Joonas Lahtinen
2017-10-02 13:52     ` Matthew Auld
2017-10-03 12:32       ` Joonas Lahtinen
2017-10-09 12:07     ` Ville Syrjälä
2017-10-09 13:04       ` Matthew Auld
2017-09-29 16:10 ` [PATCH 12/21] drm/i915: support 2M pages for the 48b PPGTT Matthew Auld
2017-09-29 16:10 ` [PATCH 13/21] drm/i915: add support for 64K scratch page Matthew Auld
2017-09-29 16:10 ` [PATCH 14/21] drm/i915: support 64K pages for the 48b PPGTT Matthew Auld
2017-09-29 16:10 ` [PATCH 15/21] drm/i915: accurate page size tracking for the ppgtt Matthew Auld
2017-09-29 16:10 ` [PATCH 16/21] drm/i915/debugfs: include some gtt page size metrics Matthew Auld
2017-09-29 16:10 ` [PATCH 17/21] drm/i915/selftests: huge page tests Matthew Auld
2017-09-29 16:22   ` Chris Wilson
2017-10-02 22:11   ` kbuild test robot
2017-10-03  9:49   ` Chris Wilson
2017-09-29 16:10 ` [PATCH 18/21] drm/i915/selftests: mix huge pages Matthew Auld
2017-09-29 16:10 ` [PATCH 19/21] drm/i915: disable platform support for vGPU huge gtt pages Matthew Auld
2017-09-29 16:10 ` [PATCH 20/21] drm/i915: enable platform support for 64K pages Matthew Auld
2017-09-29 16:10 ` [PATCH 21/21] drm/i915: enable platform support for 2M pages Matthew Auld
2017-09-29 16:59 ` ✓ Fi.CI.BAT: success for huge gtt pages (rev10) Patchwork
2017-09-29 18:32 ` ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-10-06 14:50 [PATCH 00/21] huge gtt pages Matthew Auld
2017-10-06 14:50 ` [PATCH 03/21] drm/i915/gemfs: enable THP Matthew Auld
2017-10-05 15:18 [PATCH 00/21] huge gtt pages Matthew Auld
2017-10-05 15:18 ` [PATCH 03/21] drm/i915/gemfs: enable THP Matthew Auld
2017-09-22 17:32 [PATCH 00/21] huge gtt pages Matthew Auld
2017-09-22 17:32 ` [PATCH 03/21] drm/i915/gemfs: enable THP Matthew Auld
2017-07-25 19:21 [PATCH 00/21] huge gtt pages Matthew Auld
2017-07-25 19:21 ` [PATCH 03/21] drm/i915/gemfs: enable THP Matthew Auld
2017-07-03 14:14 [PATCH 00/21] huge gtt pages Matthew Auld
2017-07-03 14:14 ` [PATCH 03/21] drm/i915/gemfs: enable THP Matthew Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929161032.24394-4-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).