From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/3] drm/dp: WARN about invalid/unknown link rates and bw codes Date: Mon, 9 Oct 2017 12:32:07 +0200 Message-ID: <20171009103207.GA14644@ulmo> References: <20171009092959.29021-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0055463581==" Return-path: In-Reply-To: <20171009092959.29021-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher List-Id: intel-gfx@lists.freedesktop.org --===============0055463581== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 09, 2017 at 12:29:57PM +0300, Jani Nikula wrote: > Falling back to the lowest value is likely the only thing we can do, but > doing it silently seems like a bad thing to do. Catch it early and make > loud noises. >=20 > Cc: Alex Deucher > Cc: Thierry Reding > Cc: Rob Clark > Cc: Sean Paul > Cc: Manasi Navare > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_helper.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_hel= per.c > index 08af8d6b844b..dca21b5a03ec 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -137,8 +137,10 @@ EXPORT_SYMBOL(drm_dp_link_train_channel_eq_delay); > u8 drm_dp_link_rate_to_bw_code(int link_rate) > { > switch (link_rate) { > - case 162000: > default: > + WARN(1, "unknown DP link rate %d, using %x\n", link_rate, > + DP_LINK_BW_1_62); > + case 162000: > return DP_LINK_BW_1_62; > case 270000: > return DP_LINK_BW_2_7; > @@ -151,8 +153,9 @@ EXPORT_SYMBOL(drm_dp_link_rate_to_bw_code); > int drm_dp_bw_code_to_link_rate(u8 link_bw) > { > switch (link_bw) { > - case DP_LINK_BW_1_62: > default: > + WARN(1, "unknown DP link bw code %x, using 162000\n", link_bw); Nit: "DP link BW" because it is an abbreviation. Otherwise looks good: Reviewed-by: Thierry Reding --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlnbUCQACgkQ3SOs138+ s6GDxA//QnC607bABzDcbyjflItBY8k5gjuPd8ux7wCdHHUSVr1MRxD0skMuICSq kfYAdJj8MWxPSvINOGnWTO8RuoYV4rWt0TtHQAm1rwXLu8YOsquP6MjWITwgDudM f8XU6ENGg9cVWCoIr0/tHgbmMQG2ASO85RLrcAKUJjlpqkDzeWYJjWA/pH1sHc1o ZHOXjFgrvARUpLVBwawcI0aSJCmsdPbKinCjzNPIU+IIV3Vqi5fLCFCI19Y/Bd1C Jp/TscPTaVKmTI5K7ByLXzI0JzF0mSlZWujdkovG6fzA82Gm42wqxantNabZyJF8 7a2XGZUXanO6/5IcUoYr6DeWK1v9zsVyH7sr217ts22FQf3f6TRDzgZXPsJ/xOXo 9P8Lt9SgFaknsKI8u4bvBaLk9NnQUZ2HLlAM/FOnH81e9lMohXQwye/LVY6/Qlr+ TrpOiAIyoXtyF9Vu3FhDbiXmcjs/cn6KfXcj3856L1jUn3Jt4oSQcSKFKF0EmqaZ rLeQowRGDujY8qmn2topVuXiebHBSDJlQ3Kx+J119+gxPUtGawgiQOL0Yonv3Ukz Txxs/c5zgYHk6AxcpkupgBy54HOeMuVez2JKXoaJ2+Kae9lGYKghzNugCBdPstz0 dFMNb9Dl9ecZ4Gh9zO4hWiYrQK0XeqonYN3Kav/jXWVxcJ2gj2k= =AAZq -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5-- --===============0055463581== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0055463581==--