From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/5] drm/i915: dspaddr_offset doesn't need to be more than local variable Date: Mon, 9 Oct 2017 20:13:38 +0300 Message-ID: <20171009171338.GI10981@intel.com> References: <1505850249-23527-1-git-send-email-juhapekka.heikkila@gmail.com> <1505850249-23527-5-git-send-email-juhapekka.heikkila@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA5DF89C63 for ; Mon, 9 Oct 2017 17:13:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1505850249-23527-5-git-send-email-juhapekka.heikkila@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Juha-Pekka Heikkila Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTksIDIwMTcgYXQgMTA6NDQ6MDhQTSArMDMwMCwgSnVoYS1QZWtrYSBIZWlr a2lsYSB3cm90ZToKPiBNb3ZlIHUzMiBkc3BhZGRyX29mZnNldCBmcm9tIHN0cnVjdCBpbnRlbF9j cnRjIG1lbWJlciBpbnRvIGxvY2FsCj4gdmFyaWFibGUgaW4gaTl4eF91cGRhdGVfcHJpbWFyeV9w bGFuZSgpCgpJIHdvdWxkIHJlb3JkZXIgdGhlIHNlcmllcyBzbyB0aGF0IHRoaXMgaXMgZG9uZSBi ZWZvcmUgeW91IGVsaW1pbmF0ZSB0aGUKU0tMIHByaW1hcnkgcGxhbmUgZnVuY3Rpb25zLiBXb3Vs ZCBtYWtlIGl0IG1vcmUgb2J2aW91cyB0aGF0IHRoZXJlIGFyZQpubyByZWFsIGRpZmZlcmVuY2Vz IGJldHdlZW4gdGhlIFNLTCBwcmltYXJ5IHZzLiBzcHJpdGUgZnVuY3Rpb25zLgoKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBKdWhhLVBla2thIEhlaWtraWxhIDxqdWhhcGVra2EuaGVpa2tpbGFAZ21haWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMiAr KysrKystLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDUg LS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA0OGQ1OTc1Li5k MjE0OTc3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0zMjk4 LDcgKzMyOTgsNiBAQCBzdGF0aWMgdm9pZCBpOXh4X3VwZGF0ZV9wcmltYXJ5X3BsYW5lKHN0cnVj dCBpbnRlbF9wbGFuZSAqcHJpbWFyeSwKPiAgCQkJCSAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9w bGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IHRvX2k5MTUocHJpbWFyeS0+YmFzZS5kZXYpOwo+IC0Jc3RydWN0IGludGVs X2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gIAlj b25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZiOwo+ ICAJZW51bSBwbGFuZSBwbGFuZSA9IHByaW1hcnktPnBsYW5lOwo+ICAJdTMyIGxpbmVhcl9vZmZz ZXQ7Cj4gQEAgLTMzMDgsMTMgKzMzMDcsMTQgQEAgc3RhdGljIHZvaWQgaTl4eF91cGRhdGVfcHJp bWFyeV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnByaW1hcnksCj4gIAlpbnQgeSA9IHBsYW5l X3N0YXRlLT5tYWluLnk7Cj4gIAl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ICAJc3RydWN0IGlu dGVsX2ZiYyAqZmJjID0gJmRldl9wcml2LT5mYmM7Cj4gKwl1MzIgZHNwYWRkcl9vZmZzZXQ7Cj4g IAo+ICAJbGluZWFyX29mZnNldCA9IGludGVsX2ZiX3h5X3RvX2xpbmVhcih4LCB5LCBwbGFuZV9z dGF0ZSwgMCk7Cj4gIAo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNCkKPiAtCQljcnRj LT5kc3BhZGRyX29mZnNldCA9IHBsYW5lX3N0YXRlLT5tYWluLm9mZnNldDsKPiArCQlkc3BhZGRy X29mZnNldCA9IHBsYW5lX3N0YXRlLT5tYWluLm9mZnNldDsKPiAgCWVsc2UKPiAtCQljcnRjLT5k c3BhZGRyX29mZnNldCA9IGxpbmVhcl9vZmZzZXQ7Cj4gKwkJZHNwYWRkcl9vZmZzZXQgPSBsaW5l YXJfb2Zmc2V0Owo+ICAKPiAgCWZiYy0+c3RhdGVfY2FjaGUucGxhbmUuYWRqdXN0ZWRfeCA9IHg7 Cj4gIAlmYmMtPnN0YXRlX2NhY2hlLnBsYW5lLmFkanVzdGVkX3kgPSB5Owo+IEBAIC0zMzQzLDE4 ICszMzQzLDE4IEBAIHN0YXRpYyB2b2lkIGk5eHhfdXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0 IGludGVsX3BsYW5lICpwcmltYXJ5LAo+ICAJaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElT X0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUFNVUkYocGxhbmUp LAo+ICAJCQkgICAgICBpbnRlbF9wbGFuZV9nZ3R0X29mZnNldChwbGFuZV9zdGF0ZSkgKwo+IC0J CQkgICAgICBjcnRjLT5kc3BhZGRyX29mZnNldCk7Cj4gKwkJCSAgICAgIGRzcGFkZHJfb2Zmc2V0 KTsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUE9GRlNFVChwbGFuZSksICh5IDw8IDE2KSB8IHgpOwo+ ICAJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDQpIHsKPiAgCQlJOTE1X1dSSVRF X0ZXKERTUFNVUkYocGxhbmUpLAo+ICAJCQkgICAgICBpbnRlbF9wbGFuZV9nZ3R0X29mZnNldChw bGFuZV9zdGF0ZSkgKwo+IC0JCQkgICAgICBjcnRjLT5kc3BhZGRyX29mZnNldCk7Cj4gKwkJCSAg ICAgIGRzcGFkZHJfb2Zmc2V0KTsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUFRJTEVPRkYocGxhbmUp LCAoeSA8PCAxNikgfCB4KTsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUExJTk9GRihwbGFuZSksIGxp bmVhcl9vZmZzZXQpOwo+ICAJfSBlbHNlIHsKPiAgCQlJOTE1X1dSSVRFX0ZXKERTUEFERFIocGxh bmUpLAo+ICAJCQkgICAgICBpbnRlbF9wbGFuZV9nZ3R0X29mZnNldChwbGFuZV9zdGF0ZSkgKwo+ IC0JCQkgICAgICBjcnRjLT5kc3BhZGRyX29mZnNldCk7Cj4gKwkJCSAgICAgIGRzcGFkZHJfb2Zm c2V0KTsKPiAgCX0KPiAgCVBPU1RJTkdfUkVBRF9GVyhyZWcpOwo+ICAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+IGluZGV4IDU2ZmI0OTMuLmE5MmMyZTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+IEBAIC04MDMsMTEgKzgwMyw2IEBAIHN0cnVjdCBpbnRlbF9jcnRjIHsKPiAg CXVuc2lnbmVkIGxvbmcgbG9uZyBlbmFibGVkX3Bvd2VyX2RvbWFpbnM7Cj4gIAlzdHJ1Y3QgaW50 ZWxfb3ZlcmxheSAqb3ZlcmxheTsKPiAgCj4gLQkvKiBEaXNwbGF5IHN1cmZhY2UgYmFzZSBhZGRy ZXNzIGFkanVzdGVtZW50IGZvciBwYWdlZmxpcHMuIE5vdGUgdGhhdCBvbgo+IC0JICogZ2VuNCsg dGhpcyBvbmx5IGFkanVzdHMgdXAgdG8gYSB0aWxlLCBvZmZzZXRzIHdpdGhpbiBhIHRpbGUgYXJl Cj4gLQkgKiBoYW5kbGVkIGluIHRoZSBodyBpdHNlbGYgKHdpdGggdGhlIFRJTEVPRkYgcmVnaXN0 ZXIpLiAqLwo+IC0JdTMyIGRzcGFkZHJfb2Zmc2V0Owo+IC0KPiAgCXN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjb25maWc7Cj4gIAo+ICAJLyogZ2xvYmFsIHJlc2V0IGNvdW50IHdoZW4gdGhlIGxh c3QgZmxpcCB3YXMgc3VibWl0dGVkICovCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=