* [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep
@ 2017-10-10 8:46 Daniel Vetter
2017-10-10 8:57 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-10-10 8:46 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter
All our mmio writes take forever with lockdep due to the constant
lock acquire&dropping we do. Ville has some patches to only acquire
the mmio spinlocks once instead for every single mmio, but those
aren't ready yet.
As an interim solution just extend our budget slightly when lockdep is
enabled, to avoid the rare and sporadic noise in CI.
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103169
References: https://bugs.freedesktop.org/show_bug.cgi?id=103124
References: https://bugs.freedesktop.org/show_bug.cgi?id=102403
References: https://bugs.freedesktop.org/show_bug.cgi?id=103020
References: https://bugs.freedesktop.org/show_bug.cgi?id=103019
References: https://bugs.freedesktop.org/show_bug.cgi?id=102723
References: https://bugs.freedesktop.org/show_bug.cgi?id=102544
References: https://bugs.freedesktop.org/show_bug.cgi?id=103180
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index b0d6e3e28d07..65f1bffe295d 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -66,7 +66,11 @@ int intel_usecs_to_scanlines(const struct drm_display_mode *adjusted_mode,
1000 * adjusted_mode->crtc_htotal);
}
+#if IS_ENABLED(CONFIG_PROVE_LOCKING)
+#define VBLANK_EVASION_TIME_US 250
+#else
#define VBLANK_EVASION_TIME_US 100
+#endif
/**
* intel_pipe_update_start() - start update of a set of display registers
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep
2017-10-10 8:46 [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep Daniel Vetter
@ 2017-10-10 8:57 ` Ville Syrjälä
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 10:05 ` ✓ Fi.CI.IGT: success for drm/i915: Increase atomic update vblank evasion time with lockdep Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2017-10-10 8:57 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development
On Tue, Oct 10, 2017 at 10:46:57AM +0200, Daniel Vetter wrote:
> All our mmio writes take forever with lockdep due to the constant
> lock acquire&dropping we do. Ville has some patches to only acquire
> the mmio spinlocks once instead for every single mmio, but those
> aren't ready yet.
>
> As an interim solution just extend our budget slightly when lockdep is
> enabled, to avoid the rare and sporadic noise in CI.
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103169
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103124
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102403
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103020
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103019
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102723
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102544
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103180
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index b0d6e3e28d07..65f1bffe295d 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -66,7 +66,11 @@ int intel_usecs_to_scanlines(const struct drm_display_mode *adjusted_mode,
> 1000 * adjusted_mode->crtc_htotal);
> }
>
> +#if IS_ENABLED(CONFIG_PROVE_LOCKING)
> +#define VBLANK_EVASION_TIME_US 250
> +#else
> #define VBLANK_EVASION_TIME_US 100
> +#endif
>
> /**
> * intel_pipe_update_start() - start update of a set of display registers
> --
> 2.14.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Increase atomic update vblank evasion time with lockdep
2017-10-10 8:46 [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep Daniel Vetter
2017-10-10 8:57 ` Ville Syrjälä
@ 2017-10-10 9:07 ` Patchwork
2017-10-10 9:18 ` [PATCH] " Daniel Vetter
` (2 more replies)
2017-10-10 10:05 ` ✓ Fi.CI.IGT: success for drm/i915: Increase atomic update vblank evasion time with lockdep Patchwork
2 siblings, 3 replies; 7+ messages in thread
From: Patchwork @ 2017-10-10 9:07 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase atomic update vblank evasion time with lockdep
URL : https://patchwork.freedesktop.org/series/31630/
State : success
== Summary ==
Series 31630v1 drm/i915: Increase atomic update vblank evasion time with lockdep
https://patchwork.freedesktop.org/api/1.0/series/31630/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-kbl-r)
Test pm_rpm:
Subgroup basic-pci-d3-state:
dmesg-warn -> PASS (fi-cfl-s)
Test drv_module_reload:
Subgroup basic-reload:
dmesg-warn -> PASS (fi-cfl-s)
Subgroup basic-reload-inject:
incomplete -> PASS (fi-cfl-s) fdo#103022
fdo#103022 https://bugs.freedesktop.org/show_bug.cgi?id=103022
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:450s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:468s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:393s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:566s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:283s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:526s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:518s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:536s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:517s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:564s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:614s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:595s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:437s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:418s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:459s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:505s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:507s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:581s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:486s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:592s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:665s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:651s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:530s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:518s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:468s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:580s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:430s
6a08510077ad5bdbac044038138f217e413cdca2 drm-tip: 2017y-10m-10d-07h-48m-31s UTC integration manifest
230036ee9896 drm/i915: Increase atomic update vblank evasion time with lockdep
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5964/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-10 9:18 ` Daniel Vetter
2017-10-10 9:41 ` ✓ Fi.CI.BAT: success for drm/i915: Increase atomic update vblank evasion time with lockdep (rev2) Patchwork
2017-10-10 10:56 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-10-10 9:18 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter
All our mmio writes take forever with lockdep due to the constant
lock acquire&dropping we do. Ville has some patches to only acquire
the mmio spinlocks once instead for every single mmio, but those
aren't ready yet.
As an interim solution just extend our budget slightly when lockdep is
enabled, to avoid the rare and sporadic noise in CI.
v2: I forgot to add the FIXME comment ...
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103169
References: https://bugs.freedesktop.org/show_bug.cgi?id=103124
References: https://bugs.freedesktop.org/show_bug.cgi?id=102403
References: https://bugs.freedesktop.org/show_bug.cgi?id=103020
References: https://bugs.freedesktop.org/show_bug.cgi?id=103019
References: https://bugs.freedesktop.org/show_bug.cgi?id=102723
References: https://bugs.freedesktop.org/show_bug.cgi?id=102544
References: https://bugs.freedesktop.org/show_bug.cgi?id=103180
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index b0d6e3e28d07..f29369622d2c 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -66,7 +66,13 @@ int intel_usecs_to_scanlines(const struct drm_display_mode *adjusted_mode,
1000 * adjusted_mode->crtc_htotal);
}
+/* FIXME: We should instead only take spinlocks once for the entire update
+ * instead of once per mmio. */
+#if IS_ENABLED(CONFIG_PROVE_LOCKING)
+#define VBLANK_EVASION_TIME_US 250
+#else
#define VBLANK_EVASION_TIME_US 100
+#endif
/**
* intel_pipe_update_start() - start update of a set of display registers
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Increase atomic update vblank evasion time with lockdep (rev2)
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 9:18 ` [PATCH] " Daniel Vetter
@ 2017-10-10 9:41 ` Patchwork
2017-10-10 10:56 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-10 9:41 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase atomic update vblank evasion time with lockdep (rev2)
URL : https://patchwork.freedesktop.org/series/31630/
State : success
== Summary ==
Series 31630v2 drm/i915: Increase atomic update vblank evasion time with lockdep
https://patchwork.freedesktop.org/api/1.0/series/31630/revisions/2/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-kbl-r)
Test pm_rpm:
Subgroup basic-pci-d3-state:
dmesg-warn -> PASS (fi-cfl-s)
Test drv_module_reload:
Subgroup basic-reload:
dmesg-warn -> PASS (fi-cfl-s)
Subgroup basic-reload-inject:
incomplete -> PASS (fi-cfl-s) fdo#103022
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103022 https://bugs.freedesktop.org/show_bug.cgi?id=103022
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:470s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:392s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:563s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:284s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:525s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:523s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:536s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:519s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:561s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:608s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:426s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:601s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:417s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:453s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:502s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:475s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:514s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:577s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:487s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:588s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:665s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:466s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:660s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:529s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:565s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:478s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:581s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:426s
6a08510077ad5bdbac044038138f217e413cdca2 drm-tip: 2017y-10m-10d-07h-48m-31s UTC integration manifest
ef503b2d26b9 drm/i915: Increase atomic update vblank evasion time with lockdep
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5965/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Increase atomic update vblank evasion time with lockdep
2017-10-10 8:46 [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep Daniel Vetter
2017-10-10 8:57 ` Ville Syrjälä
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-10 10:05 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-10 10:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase atomic update vblank evasion time with lockdep
URL : https://patchwork.freedesktop.org/series/31630/
State : success
== Summary ==
shard-hsw total:2552 pass:1412 dwarn:24 dfail:0 fail:13 skip:1103 time:9576s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5964/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Increase atomic update vblank evasion time with lockdep (rev2)
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 9:18 ` [PATCH] " Daniel Vetter
2017-10-10 9:41 ` ✓ Fi.CI.BAT: success for drm/i915: Increase atomic update vblank evasion time with lockdep (rev2) Patchwork
@ 2017-10-10 10:56 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-10 10:56 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase atomic update vblank evasion time with lockdep (rev2)
URL : https://patchwork.freedesktop.org/series/31630/
State : failure
== Summary ==
Test kms_flip:
Subgroup modeset-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw)
Test gem_flink_race:
Subgroup flink_close:
pass -> FAIL (shard-hsw) fdo#102655
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
shard-hsw total:2552 pass:1410 dwarn:24 dfail:0 fail:15 skip:1103 time:9585s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5965/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-10 10:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 8:46 [PATCH] drm/i915: Increase atomic update vblank evasion time with lockdep Daniel Vetter
2017-10-10 8:57 ` Ville Syrjälä
2017-10-10 9:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 9:18 ` [PATCH] " Daniel Vetter
2017-10-10 9:41 ` ✓ Fi.CI.BAT: success for drm/i915: Increase atomic update vblank evasion time with lockdep (rev2) Patchwork
2017-10-10 10:56 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-10 10:05 ` ✓ Fi.CI.IGT: success for drm/i915: Increase atomic update vblank evasion time with lockdep Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox