From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Favor for_each_pipe() macro
Date: Tue, 10 Oct 2017 12:17:13 +0300 [thread overview]
Message-ID: <20171010091713.GM10981@intel.com> (raw)
In-Reply-To: <1505375586-23015-5-git-send-email-mika.kahola@intel.com>
On Thu, Sep 14, 2017 at 10:53:05AM +0300, Mika Kahola wrote:
> Favor for_each_pipe() macro when looping through pipes.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
> index 24d781f..7efe3b7 100644
> --- a/drivers/gpu/drm/i915/intel_pipe_crc.c
> +++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
> @@ -208,7 +208,7 @@ static int display_crc_ctl_show(struct seq_file *m, void *data)
> struct drm_i915_private *dev_priv = m->private;
> int i;
Could also do the 'enum pipe pipe' change here. Looks like it shouldn't
cause too much noise in the patch.
>
> - for (i = 0; i < I915_MAX_PIPES; i++)
> + for_each_pipe(dev_priv, i)
> seq_printf(m, "%c %s\n", pipe_name(i),
> pipe_crc_source_name(dev_priv->pipe_crc[i].source));
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-10 9:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 7:53 [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES Mika Kahola
2017-09-14 7:53 ` [PATCH 1/5] drm/i915: Don't relay on I915_MAX_PIPES Mika Kahola
2017-09-14 7:53 ` [PATCH 2/5] drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation Mika Kahola
2017-10-10 9:15 ` Ville Syrjälä
2017-09-14 7:53 ` [PATCH 3/5] drm/i915: Fold IRQ pipe masks Mika Kahola
2017-09-14 7:53 ` [PATCH 4/5] drm/i915: Favor for_each_pipe() macro Mika Kahola
2017-10-10 9:17 ` Ville Syrjälä [this message]
2017-09-14 7:53 ` [PATCH 5/5] drm/i915: Cleanup South Error Interrupts Mika Kahola
2017-09-14 8:10 ` ✓ Fi.CI.BAT: success for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES Patchwork
2017-09-14 9:12 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-15 17:58 ` Rodrigo Vivi
2017-09-18 12:06 ` Mika Kahola
2017-09-21 10:26 ` Mika Kahola
2017-09-18 15:12 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-09-19 16:05 ` Patchwork
2017-09-27 11:02 ` ✓ Fi.CI.BAT: success " Patchwork
2017-10-05 8:29 ` Patchwork
2017-10-10 8:34 ` Patchwork
2017-10-10 9:19 ` [PATCH 0/5] " Ville Syrjälä
2017-10-10 9:24 ` Mika Kahola
2017-10-10 9:20 ` Kenneth Graunke
2017-10-10 9:59 ` Mika Kahola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010091713.GM10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox