Re: [PATCH i-g-t 4/9] intel-gpu-overlay: Fix interrupts PMU readout

Chris Wilson
2017-10-10T12:23:49Z

Quoting Tvrtko Ursulin (2017-10-10 10:30:03)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> overlay/gem-interrupts.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/overlay/gem-interrupts.c b/overlay/gem-interrupts.c
> index a84aef0398a7..3eda24f4d7eb 100644
> --- a/overlay/gem-interrupts.c
> +++ b/overlay/gem-interrupts.c
> @@ -136,8 +136,12 @@ int gem_interrupts_update(struct gem_interrupts *irqs)
> else
> val = ret;
> } else {
> - if (read(irqs->fd, &val, sizeof(val)) < 0)
> + uint64_t data[2];
> +
> + if (read(irqs->fd, &data, sizeof(data)) < 0)

s/&data/data/

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris