* [PATCH] drm/i915: Use enum pipe for PCH transcoders
@ 2017-10-10 12:55 Ville Syrjala
2017-10-10 13:28 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ville Syrjala @ 2017-10-10 12:55 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
One more place where we've failed to switch to enum pipe when talking
about PCH transcoders.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 45d6e57fbe89..57d886cece16 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14758,10 +14758,10 @@ static struct intel_connector *intel_encoder_find_connector(struct intel_encoder
}
static bool has_pch_trancoder(struct drm_i915_private *dev_priv,
- enum transcoder pch_transcoder)
+ enum pipe pch_transcoder)
{
return HAS_PCH_IBX(dev_priv) || HAS_PCH_CPT(dev_priv) ||
- (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == TRANSCODER_A);
+ (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == PIPE_A);
}
static void intel_sanitize_crtc(struct intel_crtc *crtc,
@@ -14844,7 +14844,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc,
* PCH transcoders B and C would prevent enabling the south
* error interrupt (see cpt_can_enable_serr_int()).
*/
- if (has_pch_trancoder(dev_priv, (enum transcoder)crtc->pipe))
+ if (has_pch_trancoder(dev_priv, crtc->pipe))
crtc->pch_fifo_underrun_disabled = true;
}
}
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Use enum pipe for PCH transcoders
2017-10-10 12:55 [PATCH] drm/i915: Use enum pipe for PCH transcoders Ville Syrjala
@ 2017-10-10 13:28 ` Patchwork
2017-10-10 14:00 ` [PATCH] " Daniel Vetter
2017-10-10 17:38 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-10 13:28 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use enum pipe for PCH transcoders
URL : https://patchwork.freedesktop.org/series/31654/
State : success
== Summary ==
Series 31654v1 drm/i915: Use enum pipe for PCH transcoders
https://patchwork.freedesktop.org/api/1.0/series/31654/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-cfl-s) fdo#103026
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#103026 https://bugs.freedesktop.org/show_bug.cgi?id=103026
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:454s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:469s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:387s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:562s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:282s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:522s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:518s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:532s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:516s
fi-cfl-s total:289 pass:257 dwarn:0 dfail:0 fail:0 skip:32 time:574s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:620s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:435s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:595s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:439s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:422s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:459s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:501s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:475s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:507s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:580s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:493s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:593s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:653s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:470s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:656s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:527s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:509s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:477s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:582s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:429s
6bcaf2275e52e258c737bc355e73072640be5ac3 drm-tip: 2017y-10m-10d-10h-57m-51s UTC integration manifest
d4785a65c2c6 drm/i915: Use enum pipe for PCH transcoders
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5973/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Use enum pipe for PCH transcoders
2017-10-10 12:55 [PATCH] drm/i915: Use enum pipe for PCH transcoders Ville Syrjala
2017-10-10 13:28 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-10 14:00 ` Daniel Vetter
2017-10-10 15:43 ` Ville Syrjälä
2017-10-10 17:38 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2017-10-10 14:00 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Tue, Oct 10, 2017 at 03:55:56PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> One more place where we've failed to switch to enum pipe when talking
> about PCH transcoders.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 45d6e57fbe89..57d886cece16 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14758,10 +14758,10 @@ static struct intel_connector *intel_encoder_find_connector(struct intel_encoder
> }
>
> static bool has_pch_trancoder(struct drm_i915_private *dev_priv,
> - enum transcoder pch_transcoder)
> + enum pipe pch_transcoder)
> {
> return HAS_PCH_IBX(dev_priv) || HAS_PCH_CPT(dev_priv) ||
> - (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == TRANSCODER_A);
> + (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == PIPE_A);
> }
>
> static void intel_sanitize_crtc(struct intel_crtc *crtc,
> @@ -14844,7 +14844,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc,
> * PCH transcoders B and C would prevent enabling the south
> * error interrupt (see cpt_can_enable_serr_int()).
> */
> - if (has_pch_trancoder(dev_priv, (enum transcoder)crtc->pipe))
> + if (has_pch_trancoder(dev_priv, crtc->pipe))
> crtc->pch_fifo_underrun_disabled = true;
> }
> }
> --
> 2.13.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Use enum pipe for PCH transcoders
2017-10-10 14:00 ` [PATCH] " Daniel Vetter
@ 2017-10-10 15:43 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2017-10-10 15:43 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On Tue, Oct 10, 2017 at 04:00:42PM +0200, Daniel Vetter wrote:
> On Tue, Oct 10, 2017 at 03:55:56PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > One more place where we've failed to switch to enum pipe when talking
> > about PCH transcoders.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed to dinq. Thanks for the review.
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 45d6e57fbe89..57d886cece16 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -14758,10 +14758,10 @@ static struct intel_connector *intel_encoder_find_connector(struct intel_encoder
> > }
> >
> > static bool has_pch_trancoder(struct drm_i915_private *dev_priv,
> > - enum transcoder pch_transcoder)
> > + enum pipe pch_transcoder)
> > {
> > return HAS_PCH_IBX(dev_priv) || HAS_PCH_CPT(dev_priv) ||
> > - (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == TRANSCODER_A);
> > + (HAS_PCH_LPT_H(dev_priv) && pch_transcoder == PIPE_A);
> > }
> >
> > static void intel_sanitize_crtc(struct intel_crtc *crtc,
> > @@ -14844,7 +14844,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc,
> > * PCH transcoders B and C would prevent enabling the south
> > * error interrupt (see cpt_can_enable_serr_int()).
> > */
> > - if (has_pch_trancoder(dev_priv, (enum transcoder)crtc->pipe))
> > + if (has_pch_trancoder(dev_priv, crtc->pipe))
> > crtc->pch_fifo_underrun_disabled = true;
> > }
> > }
> > --
> > 2.13.6
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915: Use enum pipe for PCH transcoders
2017-10-10 12:55 [PATCH] drm/i915: Use enum pipe for PCH transcoders Ville Syrjala
2017-10-10 13:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 14:00 ` [PATCH] " Daniel Vetter
@ 2017-10-10 17:38 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-10 17:38 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use enum pipe for PCH transcoders
URL : https://patchwork.freedesktop.org/series/31654/
State : warning
== Summary ==
Test kms_fbc_crc:
Subgroup page_flip_and_mmap_gtt:
pass -> SKIP (shard-hsw)
shard-hsw total:2552 pass:1430 dwarn:5 dfail:0 fail:13 skip:1104 time:9645s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5973/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-10 17:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 12:55 [PATCH] drm/i915: Use enum pipe for PCH transcoders Ville Syrjala
2017-10-10 13:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 14:00 ` [PATCH] " Daniel Vetter
2017-10-10 15:43 ` Ville Syrjälä
2017-10-10 17:38 ` ✗ Fi.CI.IGT: warning for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox