Re: [PATCH 0/9] drm/i915: Plane assert/readout cleanups etc.

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 12, 2017 at 01:35:20PM +0200, Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 07:04:46PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > This series aims to clean up some of the plane state readout and
> > sanitation, and clean up the enum plane mess a bit by renaming it
> > to enum old_plane_id.
> > 
> > The one actual bugfix here is the plane<->crtc sanitation
> > change. Previously we tried to shut down the entire pipe when
> > the plane mapping wasn't what we want, now we just shut down the
> > plane, which is easier.
> > 
> > Most of the other stuff is just polish, but I also decided to
> > throw the gen2/3 and chv primary plane windowing support on on top
> > just because it's been bugging me for years, and I was already
> > in the neighbourhood.
> > 
> > Series available here:
> > git://github.com/vsyrjala/linux.git plane_sanitation_2
> > 
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Alex Villacís Lasso <alexvillacislasso@hotmail.com>
> > 
> > Ville Syrjälä (9):
> >   drm/i915: Add .get_hw_state() method for planes
> >   drm/i915: Redo plane sanitation during readout
> >   drm/i915: s/enum plane/enum old_plane_id/
> >   drm/i915: Use enum old_plane_id for the .get_fifo_size() hooks
> >   drm/i915: Cleanup enum pipe/enum plane_id/enum old_plane_id in initial
> >     fb readout
> >   drm/i915: Nuke ironlake_get_initial_plane_config()
> >   drm/i915: Switch fbc over to for_each_new_intel_plane_in_state()
> >   drm/i915: Nuke crtc->plane
> >   drm/i915: Add windowing for primary planes on gen2/3 and chv
> > 
> >  drivers/gpu/drm/i915/i915_drv.h      |  16 +-
> >  drivers/gpu/drm/i915/intel_display.c | 500 +++++++++++++++--------------------
> >  drivers/gpu/drm/i915/intel_drv.h     |   8 +-
> >  drivers/gpu/drm/i915/intel_fbc.c     |  27 +-
> >  drivers/gpu/drm/i915/intel_pm.c      |  36 +--
> >  drivers/gpu/drm/i915/intel_sprite.c  |  43 +++
> >  6 files changed, 299 insertions(+), 331 deletions(-)
> 
> I take it that this is the same as the plane_sanitation branch that I
> tested on yesterday,

Close enough ;)

> and it fixes both issues I had seen,

One was the plane assert. What was the other one?

> so for the
> whole series:
> 
> Tested-by: Thierry Reding <thierry.reding@gmail.com>

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx