public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
@ 2017-10-12 17:52 PrasannaKumar Muralidharan
  2017-10-12 17:52 ` [PATCH 2/2] Test case for drm_vblank_cleanup refcount validation patch PrasannaKumar Muralidharan
  2017-10-12 18:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 Patchwork
  0 siblings, 2 replies; 4+ messages in thread
From: PrasannaKumar Muralidharan @ 2017-10-12 17:52 UTC (permalink / raw)
  To: intel-gfx, daniel.vetter, ville.syrjala; +Cc: PrasannaKumar Muralidharan

Warn when refcount > 0 in drm_vblank_cleanup.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
---
Changes since RFC:
Fix compile error

 drivers/gpu/drm/drm_vblank.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 70f2b95..361aeeb 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -405,6 +405,8 @@ void drm_vblank_cleanup(struct drm_device *dev)
 	for (pipe = 0; pipe < dev->num_crtcs; pipe++) {
 		struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
 
+		WARN_ON((atomic_read(&vblank->refcount) > 0));
+
 		WARN_ON(READ_ONCE(vblank->enabled) &&
 			drm_core_check_feature(dev, DRIVER_MODESET));
 
-- 
2.10.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] Test case for drm_vblank_cleanup refcount validation patch
  2017-10-12 17:52 [PATCH 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
@ 2017-10-12 17:52 ` PrasannaKumar Muralidharan
  2017-10-12 18:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 Patchwork
  1 sibling, 0 replies; 4+ messages in thread
From: PrasannaKumar Muralidharan @ 2017-10-12 17:52 UTC (permalink / raw)
  To: intel-gfx, daniel.vetter, ville.syrjala; +Cc: PrasannaKumar Muralidharan

In i915 driver unload drm_vblank_get is added to test whether
drm_vblank_cleanup refcount validation patch is working.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
---
Changes since RFC:
Fix compile error

 drivers/gpu/drm/i915/i915_drv.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 9f45cfe..d317da3 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1373,6 +1373,13 @@ void i915_driver_unload(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct pci_dev *pdev = dev_priv->drm.pdev;
 
+	enum pipe pipe;
+	for_each_pipe(dev_priv, pipe) {
+		struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv,
+								  pipe);
+		drm_crtc_vblank_put(&crtc->base);
+	}
+
 	i915_driver_unregister(dev_priv);
 
 	if (i915_gem_suspend(dev_priv))
-- 
2.10.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
  2017-10-12 17:52 [PATCH 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
  2017-10-12 17:52 ` [PATCH 2/2] Test case for drm_vblank_cleanup refcount validation patch PrasannaKumar Muralidharan
@ 2017-10-12 18:16 ` Patchwork
  2017-10-12 18:18   ` Daniel Vetter
  1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2017-10-12 18:16 UTC (permalink / raw)
  To: PrasannaKumar Muralidharan; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
URL   : https://patchwork.freedesktop.org/series/31841/
State : warning

== Summary ==

Series 31841v1 series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
https://patchwork.freedesktop.org/api/1.0/series/31841/revisions/1/mbox/

Test gem_exec_reloc:
        Subgroup basic-cpu-gtt-active:
                fail       -> PASS       (fi-gdg-551) fdo#102582
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (fi-cfl-s) fdo#103186
Test drv_module_reload:
        Subgroup basic-reload:
                pass       -> DMESG-WARN (fi-blb-e6850)
                pass       -> DMESG-WARN (fi-pnv-d510)
                pass       -> DMESG-WARN (fi-bwr-2160)
                pass       -> DMESG-WARN (fi-elk-e7500)
                pass       -> DMESG-WARN (fi-ilk-650)
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
                pass       -> DMESG-WARN (fi-bsw-n3050)
                pass       -> DMESG-WARN (fi-skl-6260u)
                pass       -> DMESG-WARN (fi-skl-6700hq)
                pass       -> DMESG-WARN (fi-skl-6700k)
                pass       -> DMESG-WARN (fi-skl-6770hq)
                pass       -> DMESG-WARN (fi-skl-gvtdvm)
                pass       -> DMESG-WARN (fi-bxt-dsi)
                pass       -> DMESG-WARN (fi-bxt-j4205)
                pass       -> DMESG-WARN (fi-kbl-7500u)
                pass       -> DMESG-WARN (fi-kbl-r)
                pass       -> DMESG-WARN (fi-glk-1)
        Subgroup basic-no-display:
                pass       -> DMESG-WARN (fi-gdg-551)
                pass       -> DMESG-WARN (fi-blb-e6850)
                pass       -> DMESG-WARN (fi-pnv-d510)
                pass       -> DMESG-WARN (fi-bwr-2160)
                pass       -> DMESG-WARN (fi-elk-e7500)
                pass       -> DMESG-WARN (fi-ilk-650)
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
                pass       -> DMESG-WARN (fi-bsw-n3050)
                pass       -> DMESG-WARN (fi-skl-6260u)
                pass       -> DMESG-WARN (fi-skl-6700hq)
                pass       -> DMESG-WARN (fi-skl-6700k)
                pass       -> DMESG-WARN (fi-skl-6770hq)
                pass       -> DMESG-WARN (fi-skl-gvtdvm)
                pass       -> DMESG-WARN (fi-bxt-dsi)
                pass       -> DMESG-WARN (fi-bxt-j4205)
                pass       -> DMESG-WARN (fi-kbl-7500u)
                pass       -> DMESG-WARN (fi-kbl-r)
                pass       -> DMESG-WARN (fi-glk-1)
        Subgroup basic-reload-inject:
                pass       -> DMESG-WARN (fi-gdg-551)
                pass       -> DMESG-WARN (fi-blb-e6850)
                pass       -> DMESG-WARN (fi-pnv-d510)
                pass       -> DMESG-WARN (fi-bwr-2160)
                pass       -> DMESG-WARN (fi-elk-e7500)
                pass       -> DMESG-WARN (fi-ilk-650)
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
                pass       -> DMESG-WARN (fi-bsw-n3050)
                pass       -> DMESG-WARN (fi-skl-6260u)
                pass       -> DMESG-WARN (fi-skl-6700hq)
                pass       -> DMESG-WARN (fi-skl-6700k)
                pass       -> DMESG-WARN (fi-skl-6770hq)
                pass       -> DMESG-WARN (fi-skl-gvtdvm)
                pass       -> DMESG-WARN (fi-bxt-dsi)
                pass       -> DMESG-WARN (fi-bxt-j4205)
                pass       -> DMESG-WARN (fi-kbl-7500u)
                pass       -> DMESG-WARN (fi-kbl-r)
                pass       -> DMESG-WARN (fi-glk-1)

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#103186 https://bugs.freedesktop.org/show_bug.cgi?id=103186

fi-bdw-5557u     total:289  pass:265  dwarn:3   dfail:0   fail:0   skip:21  time:468s
fi-bdw-gvtdvm    total:289  pass:262  dwarn:3   dfail:0   fail:0   skip:24  time:472s
fi-blb-e6850     total:289  pass:220  dwarn:4   dfail:0   fail:0   skip:65  time:394s
fi-bsw-n3050     total:289  pass:240  dwarn:3   dfail:0   fail:0   skip:46  time:576s
fi-bwr-2160      total:289  pass:180  dwarn:3   dfail:0   fail:0   skip:106 time:289s
fi-bxt-dsi       total:289  pass:256  dwarn:3   dfail:0   fail:0   skip:30  time:529s
WARNING: Long output truncated

e8024950de9e2f104a51384a16dae9a08388d43f drm-tip: 2017y-10m-12d-15h-17m-52s UTC integration manifest
571ebfc360af Test case for drm_vblank_cleanup refcount validation patch
bdec0baf0411 drm: drm_vblank_cleanup: WARN when refcount > 0

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6012/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
  2017-10-12 18:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 Patchwork
@ 2017-10-12 18:18   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2017-10-12 18:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: PrasannaKumar Muralidharan

On Thu, Oct 12, 2017 at 06:16:09PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
> URL   : https://patchwork.freedesktop.org/series/31841/
> State : warning
> 
> == Summary ==
> 
> Series 31841v1 series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
> https://patchwork.freedesktop.org/api/1.0/series/31841/revisions/1/mbox/
> 
> Test gem_exec_reloc:
>         Subgroup basic-cpu-gtt-active:
>                 fail       -> PASS       (fi-gdg-551) fdo#102582
> Test gem_exec_suspend:
>         Subgroup basic-s3:
>                 dmesg-warn -> PASS       (fi-cfl-s) fdo#103186
> Test drv_module_reload:
>         Subgroup basic-reload:
>                 pass       -> DMESG-WARN (fi-blb-e6850)
>                 pass       -> DMESG-WARN (fi-pnv-d510)
>                 pass       -> DMESG-WARN (fi-bwr-2160)
>                 pass       -> DMESG-WARN (fi-elk-e7500)
>                 pass       -> DMESG-WARN (fi-ilk-650)
>                 pass       -> DMESG-WARN (fi-snb-2520m)
>                 pass       -> DMESG-WARN (fi-snb-2600)
>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>                 pass       -> DMESG-WARN (fi-ivb-3770)
>                 pass       -> DMESG-WARN (fi-byt-j1900)
>                 pass       -> DMESG-WARN (fi-byt-n2820)
>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bsw-n3050)
>                 pass       -> DMESG-WARN (fi-skl-6260u)
>                 pass       -> DMESG-WARN (fi-skl-6700hq)
>                 pass       -> DMESG-WARN (fi-skl-6700k)
>                 pass       -> DMESG-WARN (fi-skl-6770hq)
>                 pass       -> DMESG-WARN (fi-skl-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bxt-dsi)
>                 pass       -> DMESG-WARN (fi-bxt-j4205)
>                 pass       -> DMESG-WARN (fi-kbl-7500u)
>                 pass       -> DMESG-WARN (fi-kbl-r)
>                 pass       -> DMESG-WARN (fi-glk-1)
>         Subgroup basic-no-display:
>                 pass       -> DMESG-WARN (fi-gdg-551)
>                 pass       -> DMESG-WARN (fi-blb-e6850)
>                 pass       -> DMESG-WARN (fi-pnv-d510)
>                 pass       -> DMESG-WARN (fi-bwr-2160)
>                 pass       -> DMESG-WARN (fi-elk-e7500)
>                 pass       -> DMESG-WARN (fi-ilk-650)
>                 pass       -> DMESG-WARN (fi-snb-2520m)
>                 pass       -> DMESG-WARN (fi-snb-2600)
>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>                 pass       -> DMESG-WARN (fi-ivb-3770)
>                 pass       -> DMESG-WARN (fi-byt-j1900)
>                 pass       -> DMESG-WARN (fi-byt-n2820)
>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bsw-n3050)
>                 pass       -> DMESG-WARN (fi-skl-6260u)
>                 pass       -> DMESG-WARN (fi-skl-6700hq)
>                 pass       -> DMESG-WARN (fi-skl-6700k)
>                 pass       -> DMESG-WARN (fi-skl-6770hq)
>                 pass       -> DMESG-WARN (fi-skl-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bxt-dsi)
>                 pass       -> DMESG-WARN (fi-bxt-j4205)
>                 pass       -> DMESG-WARN (fi-kbl-7500u)
>                 pass       -> DMESG-WARN (fi-kbl-r)
>                 pass       -> DMESG-WARN (fi-glk-1)
>         Subgroup basic-reload-inject:
>                 pass       -> DMESG-WARN (fi-gdg-551)
>                 pass       -> DMESG-WARN (fi-blb-e6850)
>                 pass       -> DMESG-WARN (fi-pnv-d510)
>                 pass       -> DMESG-WARN (fi-bwr-2160)
>                 pass       -> DMESG-WARN (fi-elk-e7500)
>                 pass       -> DMESG-WARN (fi-ilk-650)
>                 pass       -> DMESG-WARN (fi-snb-2520m)
>                 pass       -> DMESG-WARN (fi-snb-2600)
>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>                 pass       -> DMESG-WARN (fi-ivb-3770)
>                 pass       -> DMESG-WARN (fi-byt-j1900)
>                 pass       -> DMESG-WARN (fi-byt-n2820)
>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bsw-n3050)
>                 pass       -> DMESG-WARN (fi-skl-6260u)
>                 pass       -> DMESG-WARN (fi-skl-6700hq)
>                 pass       -> DMESG-WARN (fi-skl-6700k)
>                 pass       -> DMESG-WARN (fi-skl-6770hq)
>                 pass       -> DMESG-WARN (fi-skl-gvtdvm)
>                 pass       -> DMESG-WARN (fi-bxt-dsi)
>                 pass       -> DMESG-WARN (fi-bxt-j4205)
>                 pass       -> DMESG-WARN (fi-kbl-7500u)
>                 pass       -> DMESG-WARN (fi-kbl-r)
>                 pass       -> DMESG-WARN (fi-glk-1)

So warning obviously works, but now we also need to test that it doesn't
break anything :-)

Can you pls resubmit the first patch (and that one only ofcourse), to both
dri-devel and intel-gfx? Our CI only checks intel-gfx, hence both.

Thanks, Daniel

> 
> fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
> fdo#103186 https://bugs.freedesktop.org/show_bug.cgi?id=103186
> 
> fi-bdw-5557u     total:289  pass:265  dwarn:3   dfail:0   fail:0   skip:21  time:468s
> fi-bdw-gvtdvm    total:289  pass:262  dwarn:3   dfail:0   fail:0   skip:24  time:472s
> fi-blb-e6850     total:289  pass:220  dwarn:4   dfail:0   fail:0   skip:65  time:394s
> fi-bsw-n3050     total:289  pass:240  dwarn:3   dfail:0   fail:0   skip:46  time:576s
> fi-bwr-2160      total:289  pass:180  dwarn:3   dfail:0   fail:0   skip:106 time:289s
> fi-bxt-dsi       total:289  pass:256  dwarn:3   dfail:0   fail:0   skip:30  time:529s
> WARNING: Long output truncated
> 
> e8024950de9e2f104a51384a16dae9a08388d43f drm-tip: 2017y-10m-12d-15h-17m-52s UTC integration manifest
> 571ebfc360af Test case for drm_vblank_cleanup refcount validation patch
> bdec0baf0411 drm: drm_vblank_cleanup: WARN when refcount > 0
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6012/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-12 18:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 17:52 [PATCH 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
2017-10-12 17:52 ` [PATCH 2/2] Test case for drm_vblank_cleanup refcount validation patch PrasannaKumar Muralidharan
2017-10-12 18:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm: drm_vblank_cleanup: WARN when refcount > 0 Patchwork
2017-10-12 18:18   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox