From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/9] drm/i915: Nuke ironlake_get_initial_plane_config() Date: Fri, 13 Oct 2017 13:36:22 +0300 Message-ID: <20171013103622.GV10981@intel.com> References: <20171011160455.1874-1-ville.syrjala@linux.intel.com> <20171011160455.1874-7-ville.syrjala@linux.intel.com> <20171012191740.m2n6vho4zryvvtwc@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81B656EAB3 for ; Fri, 13 Oct 2017 10:36:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171012191740.m2n6vho4zryvvtwc@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTIsIDIwMTcgYXQgMDk6MTc6NDBQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE9jdCAxMSwgMjAxNyBhdCAwNzowNDo1MlBNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gVGhlIG9ubHkgcmVsZXZhbnQgZGlmZmVyZW5jZSBiZXR3 ZWVuIGk5eHhfZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnKCkgYW5kCj4gPiBpcm9ubGFrZV9nZXRf aW5pdGlhbF9wbGFuZV9jb25maWcoKSBpcyB0aGUgSFNXL0JEVyBUSUxFT0ZGIGhhbmRsaW5nLgo+ ID4gQWRkIHRoYXQgdG8gaTl4eF9nZXRfaW5pdGlhbF9wbGFuZV9jb25maWcoKSBhbmQgbnVrZQo+ ID4gaXJvbmxha2VfZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnKCkuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Cj4gSSdtIHN0aWxsIGtpbmRhIHdhbnRpbmcgc29tZSB3YXkgdG8gdGVzdCB0aGlzIGhlcmUgd2l0 aCBldmVyeSBtb2Rlc2V0LCBidXQKPiBzdGlsbCBjYW4ndCBjb21lIHVwIHdpdGggc29tZXRoaW5n IHNpbXBsZSZuZWF0Lgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgNzkgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNzMgZGVsZXRpb25zKC0pCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDIxMTYwYTA2YWIzNi4u ODJiZTIzNDJkMWM2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+IEBAIC03NDkwLDcgKzc0OTAsMTAgQEAgaTl4eF9nZXRfaW5pdGlhbF9wbGFuZV9jb25maWco c3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAgCWZvdXJjYyA9IGk5eHhfZm9ybWF0X3RvX2Zv dXJjYyhwaXhlbF9mb3JtYXQpOwo+ID4gIAlmYi0+Zm9ybWF0ID0gZHJtX2Zvcm1hdF9pbmZvKGZv dXJjYyk7Cj4gPiAgCj4gPiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDQpIHsKPiA+ICsJ aWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiA+ ICsJCW9mZnNldCA9IEk5MTVfUkVBRChEU1BPRkZTRVQocGxhbmVfaWQpKTsKPiA+ICsJCWJhc2Ug PSBJOTE1X1JFQUQoRFNQU1VSRihwbGFuZV9pZCkpICYgMHhmZmZmZjAwMDsKPiA+ICsJfSBlbHNl IGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDQpIHsKPiA+ICAJCWlmIChwbGFuZV9jb25maWct PnRpbGluZykKPiA+ICAJCQlvZmZzZXQgPSBJOTE1X1JFQUQoRFNQVElMRU9GRihwbGFuZV9pZCkp Owo+ID4gIAkJZWxzZQo+ID4gQEAgLTg1OTIsNzYgKzg1OTUsNiBAQCBzdGF0aWMgdm9pZCBpcm9u bGFrZV9nZXRfcGZpdF9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAgCX0KPiA+ ICB9Cj4gPiAgCj4gPiAtc3RhdGljIHZvaWQKPiA+IC1pcm9ubGFrZV9nZXRfaW5pdGlhbF9wbGFu ZV9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAtCQkJCSAgc3RydWN0IGludGVs X2luaXRpYWxfcGxhbmVfY29uZmlnICpwbGFuZV9jb25maWcpCj4gPiAtewo+ID4gLQlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gPiAtCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+IC0Jc3RydWN0IGludGVsX3BsYW5l ICpwbGFuZSA9IHRvX2ludGVsX3BsYW5lKGNydGMtPmJhc2UucHJpbWFyeSk7Cj4gPiAtCWVudW0g b2xkX3BsYW5lX2lkIHBsYW5lX2lkID0gcGxhbmUtPnBsYW5lOwo+ID4gLQllbnVtIHBpcGUgcGlw ZSA9IGNydGMtPnBpcGU7Cj4gPiAtCXUzMiB2YWwsIGJhc2UsIG9mZnNldDsKPiA+IC0JaW50IGZv dXJjYywgcGl4ZWxfZm9ybWF0Owo+ID4gLQl1bnNpZ25lZCBpbnQgYWxpZ25lZF9oZWlnaHQ7Cj4g PiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ID4gLQlzdHJ1Y3QgaW50ZWxfZnJhbWVi dWZmZXIgKmludGVsX2ZiOwo+ID4gLQo+ID4gLQl2YWwgPSBJOTE1X1JFQUQoRFNQQ05UUihwbGFu ZV9pZCkpOwo+ID4gLQlpZiAoISh2YWwgJiBESVNQTEFZX1BMQU5FX0VOQUJMRSkpCj4gCj4gSG0s IHNob3VsZCB3ZSB1c2UgcGxhbmUtPmdldF9od19zdGF0ZSB0byB0YWtlIG91dCB0aGlzIGNoZWNr PyBBdCBsZWFzdCB0bwo+IHBhcnRpYWxseSBnZXQgY2xvc2UgdG8gdGhlIGh3IHN0YXRlIHJlYWRv dXQgYXBwcm9hY2ggd2UgaGF2ZSBmb3IKPiBjcnRjL2VuY29kZXJzL2Nvbm5lY3RvcnMuCgpJIGd1 ZXNzIHdlIGNvdWxkLiBXZSdsbCBzdGlsbCBuZWVkIHRvIHJlYWQgRFNQQ05UUiBhbnl3YXksIGJ1 dCBJIGRvbid0CnRoaW5rIHJlYWRpbmcgaXQgdHdpY2UgaXMgYSByZWFsIGlzc3VlLiBJJ2xsIHBv c3QgYSBmb2xsb3cgdXAgd2l0aCB0aGlzLgoKPiAKPiBBc2lkZSBmb3JtIHRoZXNlIHR3byBub3Rl cywgcGF0Y2ggaXRzZWxmIGxvb2tzIGdvb2QuCj4gCj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0 ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gPiAtCQlyZXR1cm47Cj4gPiAtCj4gPiAt CWludGVsX2ZiID0ga3phbGxvYyhzaXplb2YoKmludGVsX2ZiKSwgR0ZQX0tFUk5FTCk7Cj4gPiAt CWlmICghaW50ZWxfZmIpIHsKPiA+IC0JCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBhbGxvYyBm YlxuIik7Cj4gPiAtCQlyZXR1cm47Cj4gPiAtCX0KPiA+IC0KPiA+IC0JZmIgPSAmaW50ZWxfZmIt PmJhc2U7Cj4gPiAtCj4gPiAtCWZiLT5kZXYgPSBkZXY7Cj4gPiAtCj4gPiAtCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDQpIHsKPiA+IC0JCWlmICh2YWwgJiBESVNQUExBTkVfVElMRUQpIHsK PiA+IC0JCQlwbGFuZV9jb25maWctPnRpbGluZyA9IEk5MTVfVElMSU5HX1g7Cj4gPiAtCQkJZmIt Pm1vZGlmaWVyID0gSTkxNV9GT1JNQVRfTU9EX1hfVElMRUQ7Cj4gPiAtCQl9Cj4gPiAtCX0KPiA+ IC0KPiA+IC0JcGl4ZWxfZm9ybWF0ID0gdmFsICYgRElTUFBMQU5FX1BJWEZPUk1BVF9NQVNLOwo+ ID4gLQlmb3VyY2MgPSBpOXh4X2Zvcm1hdF90b19mb3VyY2MocGl4ZWxfZm9ybWF0KTsKPiA+IC0J ZmItPmZvcm1hdCA9IGRybV9mb3JtYXRfaW5mbyhmb3VyY2MpOwo+ID4gLQo+ID4gLQliYXNlID0g STkxNV9SRUFEKERTUFNVUkYocGxhbmVfaWQpKSAmIDB4ZmZmZmYwMDA7Cj4gPiAtCWlmIChJU19I QVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gPiAtCQlvZmZz ZXQgPSBJOTE1X1JFQUQoRFNQT0ZGU0VUKHBsYW5lX2lkKSk7Cj4gPiAtCX0gZWxzZSB7Cj4gPiAt CQlpZiAocGxhbmVfY29uZmlnLT50aWxpbmcpCj4gPiAtCQkJb2Zmc2V0ID0gSTkxNV9SRUFEKERT UFRJTEVPRkYocGxhbmVfaWQpKTsKPiA+IC0JCWVsc2UKPiA+IC0JCQlvZmZzZXQgPSBJOTE1X1JF QUQoRFNQTElOT0ZGKHBsYW5lX2lkKSk7Cj4gPiAtCX0KPiA+IC0JcGxhbmVfY29uZmlnLT5iYXNl ID0gYmFzZTsKPiA+IC0KPiA+IC0JdmFsID0gSTkxNV9SRUFEKFBJUEVTUkMocGlwZSkpOwo+ID4g LQlmYi0+d2lkdGggPSAoKHZhbCA+PiAxNikgJiAweGZmZikgKyAxOwo+ID4gLQlmYi0+aGVpZ2h0 ID0gKCh2YWwgPj4gMCkgJiAweGZmZikgKyAxOwo+ID4gLQo+ID4gLQl2YWwgPSBJOTE1X1JFQUQo RFNQU1RSSURFKHBsYW5lX2lkKSk7Cj4gPiAtCWZiLT5waXRjaGVzWzBdID0gdmFsICYgMHhmZmZm ZmZjMDsKPiA+IC0KPiA+IC0JYWxpZ25lZF9oZWlnaHQgPSBpbnRlbF9mYl9hbGlnbl9oZWlnaHQo ZmIsIDAsIGZiLT5oZWlnaHQpOwo+ID4gLQo+ID4gLQlwbGFuZV9jb25maWctPnNpemUgPSBmYi0+ cGl0Y2hlc1swXSAqIGFsaWduZWRfaGVpZ2h0Owo+ID4gLQo+ID4gLQlEUk1fREVCVUdfS01TKCIl cy8lcyB3aXRoIGZiOiBzaXplPSVkeCVkQCVkLCBvZmZzZXQ9JXgsIHBpdGNoICVkLCBzaXplIDB4 JXhcbiIsCj4gPiAtCQkgICAgICBjcnRjLT5iYXNlLm5hbWUsIHBsYW5lLT5iYXNlLm5hbWUsIGZi LT53aWR0aCwgZmItPmhlaWdodCwKPiA+IC0JCSAgICAgIGZiLT5mb3JtYXQtPmNwcFswXSAqIDgs IGJhc2UsIGZiLT5waXRjaGVzWzBdLAo+ID4gLQkJICAgICAgcGxhbmVfY29uZmlnLT5zaXplKTsK PiA+IC0KPiA+IC0JcGxhbmVfY29uZmlnLT5mYiA9IGludGVsX2ZiOwo+ID4gLX0KPiA+IC0KPiA+ ICBzdGF0aWMgYm9vbCBpcm9ubGFrZV9nZXRfcGlwZV9jb25maWcoc3RydWN0IGludGVsX2NydGMg KmNydGMsCj4gPiAgCQkJCSAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmln KQo+ID4gIHsKPiA+IEBAIC0xNDE0MCw3ICsxNDA3Myw3IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNw bGF5X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJfSBlbHNl IGlmIChIQVNfRERJKGRldl9wcml2KSkgewo+ID4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X3Bp cGVfY29uZmlnID0gaGFzd2VsbF9nZXRfcGlwZV9jb25maWc7Cj4gPiAgCQlkZXZfcHJpdi0+ZGlz cGxheS5nZXRfaW5pdGlhbF9wbGFuZV9jb25maWcgPQo+ID4gLQkJCWlyb25sYWtlX2dldF9pbml0 aWFsX3BsYW5lX2NvbmZpZzsKPiA+ICsJCQlpOXh4X2dldF9pbml0aWFsX3BsYW5lX2NvbmZpZzsK PiA+ICAJCWRldl9wcml2LT5kaXNwbGF5LmNydGNfY29tcHV0ZV9jbG9jayA9Cj4gPiAgCQkJaGFz d2VsbF9jcnRjX2NvbXB1dGVfY2xvY2s7Cj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2Vu YWJsZSA9IGhhc3dlbGxfY3J0Y19lbmFibGU7Cj4gPiBAQCAtMTQxNDgsNyArMTQwODEsNyBAQCB2 b2lkIGludGVsX2luaXRfZGlzcGxheV9ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gPiAgCX0gZWxzZSBpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikpIHsKPiA+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9waXBlX2NvbmZpZyA9IGlyb25sYWtlX2dldF9waXBlX2Nv bmZpZzsKPiA+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9pbml0aWFsX3BsYW5lX2NvbmZpZyA9 Cj4gPiAtCQkJaXJvbmxha2VfZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnOwo+ID4gKwkJCWk5eHhf Z2V0X2luaXRpYWxfcGxhbmVfY29uZmlnOwo+ID4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19j b21wdXRlX2Nsb2NrID0KPiA+ICAJCQlpcm9ubGFrZV9jcnRjX2NvbXB1dGVfY2xvY2s7Cj4gPiAg CQlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2VuYWJsZSA9IGlyb25sYWtlX2NydGNfZW5hYmxlOwo+ ID4gLS0gCj4gPiAyLjEzLjYKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNv ZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNo CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK