* [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
@ 2017-10-13 15:47 Chris Wilson
2017-10-13 15:50 ` Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Chris Wilson @ 2017-10-13 15:47 UTC (permalink / raw)
To: intel-gfx
Cc: Chris Wilson, Ville Syrjälä, David Weinehall,
Jani Nikula, stable
The compiler warns:
drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: David Weinehall <david.weinehall@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.12+
---
drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index b307b6fe1ce3..115162549914 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
int *n_entries)
{
if (IS_BROADWELL(dev_priv)) {
- *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
- return hsw_ddi_translations_fdi;
+ *n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
+ return bdw_ddi_translations_fdi;
} else if (IS_HASWELL(dev_priv)) {
*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
return hsw_ddi_translations_fdi;
--
2.15.0.rc0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
@ 2017-10-13 15:50 ` Chris Wilson
2017-10-13 15:53 ` Ville Syrjälä
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2017-10-13 15:50 UTC (permalink / raw)
To: intel-gfx; +Cc: Ville Syrjälä, David Weinehall, Jani Nikula, stable
Quoting Chris Wilson (2017-10-13 16:47:35)
> The compiler warns:
>
> drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
>
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
>
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+
>From irc,
j4ni> rb on ickle's pastebin patch
Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
-Chris
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
2017-10-13 15:50 ` Chris Wilson
@ 2017-10-13 15:53 ` Ville Syrjälä
2017-10-13 17:42 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2017-10-13 15:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: stable, intel-gfx
On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
>
> drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
>
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
>
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
> int *n_entries)
> {
> if (IS_BROADWELL(dev_priv)) {
> - *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> - return hsw_ddi_translations_fdi;
> + *n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> + return bdw_ddi_translations_fdi;
> } else if (IS_HASWELL(dev_priv)) {
> *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> return hsw_ddi_translations_fdi;
> --
> 2.15.0.rc0
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Use bdw_ddi_translations_fdi for Broadwell
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
2017-10-13 15:50 ` Chris Wilson
2017-10-13 15:53 ` Ville Syrjälä
@ 2017-10-13 17:42 ` Patchwork
2017-10-13 20:46 ` Chris Wilson
2017-10-14 1:49 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-16 14:17 ` [PATCH] " David Weinehall
4 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2017-10-13 17:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use bdw_ddi_translations_fdi for Broadwell
URL : https://patchwork.freedesktop.org/series/31939/
State : success
== Summary ==
Series 31939v1 drm/i915: Use bdw_ddi_translations_fdi for Broadwell
https://patchwork.freedesktop.org/api/1.0/series/31939/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:452s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:470s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:388s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:573s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:286s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:519s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:517s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:537s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:525s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:561s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:434s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:272s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:600s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:442s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:456s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:478s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:512s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:485s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:597s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:656s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:470s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:660s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:525s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:510s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:472s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:588s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:434s
005c15a2795854ab64b6ce63dcb099d2eea4a889 drm-tip: 2017y-10m-13d-15h-39m-54s UTC integration manifest
27e726d7920d drm/i915: Use bdw_ddi_translations_fdi for Broadwell
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6028/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✗ Fi.CI.IGT: warning for drm/i915: Use bdw_ddi_translations_fdi for Broadwell
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
` (2 preceding siblings ...)
2017-10-13 17:42 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-14 1:49 ` Patchwork
2017-10-16 14:17 ` [PATCH] " David Weinehall
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-14 1:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use bdw_ddi_translations_fdi for Broadwell
URL : https://patchwork.freedesktop.org/series/31939/
State : warning
== Summary ==
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_flip:
Subgroup flip-vs-rmfb-interruptible:
pass -> DMESG-WARN (shard-hsw) fdo#102614
Test pm_rpm:
Subgroup gem-mmap-gtt:
pass -> SKIP (shard-hsw)
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
shard-hsw total:2553 pass:1438 dwarn:2 dfail:0 fail:9 skip:1104 time:9604s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6028/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
` (3 preceding siblings ...)
2017-10-14 1:49 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-10-16 14:17 ` David Weinehall
4 siblings, 0 replies; 8+ messages in thread
From: David Weinehall @ 2017-10-16 14:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: stable, intel-gfx
On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
>
> drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
>
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
Good catch, and thanks for fixing.
I noticed that the patch has already been reviewed and merged, so I
won't bother with an R-B.
Kind regards, David
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
> int *n_entries)
> {
> if (IS_BROADWELL(dev_priv)) {
> - *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> - return hsw_ddi_translations_fdi;
> + *n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> + return bdw_ddi_translations_fdi;
> } else if (IS_HASWELL(dev_priv)) {
> *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> return hsw_ddi_translations_fdi;
> --
> 2.15.0.rc0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-10-16 14:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
2017-10-13 15:50 ` Chris Wilson
2017-10-13 15:53 ` Ville Syrjälä
2017-10-13 17:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-13 20:46 ` Chris Wilson
2017-10-16 11:55 ` Ville Syrjälä
2017-10-14 1:49 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-16 14:17 ` [PATCH] " David Weinehall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox