From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Add -Wunused-const-variable to our build
Date: Fri, 13 Oct 2017 19:48:02 +0300 [thread overview]
Message-ID: <20171013164802.GF10981@intel.com> (raw)
In-Reply-To: <20171013160830.16065-2-chris@chris-wilson.co.uk>
On Fri, Oct 13, 2017 at 05:08:30PM +0100, Chris Wilson wrote:
> Recently this warning caught a regression that had been lurking for 6
> months, so it seems to be justified!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 0bb6e423ecd7..4351b7b6f09b 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -3,6 +3,7 @@
> # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
>
> subdir-ccflags-y := -Wno-override-init # used frequently for "inheritance"
> +subdir-ccflags-y += -Wunused-const-variable
My gcc 5.4 doesn't even seem to have this one :(
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> subdir-ccflags-y += \
> $(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
> --
> 2.15.0.rc0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-13 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 16:08 [PATCH 1/2] drm/i915: Disable -Woverride-init Chris Wilson
2017-10-13 16:08 ` [PATCH 2/2] drm/i915: Add -Wunused-const-variable to our build Chris Wilson
2017-10-13 16:48 ` Ville Syrjälä [this message]
2017-10-13 16:18 ` [PATCH 1/2] drm/i915: Disable -Woverride-init Michal Wajdeczko
2017-10-13 16:47 ` Ville Syrjälä
2017-10-13 19:34 ` Chris Wilson
2017-10-13 17:45 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013164802.GF10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).