From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/atomic: Check for busy planes/connectors before setting the commit Date: Mon, 16 Oct 2017 16:51:37 +0300 Message-ID: <20171016135137.GL10981@intel.com> References: <20171016132928.6498-1-maarten.lankhorst@linux.intel.com> <20171016132928.6498-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171016132928.6498-2-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTYsIDIwMTcgYXQgMDM6Mjk6MjhQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2Ugc3RpbGwgd2FudCB0byBmYWlsIHdpdGggLUVCVVNZIGlmIGEgcGxhbmUg b3IgY29ubmVjdG9yIGlzIHBhcnQgb2YKPiBhIGNvbW1pdCwgZXZlbiBpZiBpdCB3aWxsIGJlIGFz c2lnbmVkIHRvIGEgbmV3IGNvbW1pdC4KPiAKPiBUaGlzIGNsb3NlcyBhIHNtYWxsIGhvbGUgbGVm dCBvcGVuIHdoZXJlIHdlIHNob3VsZCByZXR1cm4gLUVCVVNZLgo+IEl0J3Mgbm90IHNldmVyZSwg YmVjYXVzZSB3YWl0X2Zvcl9kZXBlbmRlbmNpZXMgYW5kIHN3YXBfc3RhdGUgaGVscGVycwo+IHN0 aWxsIGJsb2NrLiBCdXQgaXQgc2hvdWxkIHJldHVybiAtRUJVU1kgYW5kIG5vdCBzdGFsbC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGlu dXguaW50ZWwuY29tPgo+IEZpeGVzOiAyMWEwMWFiYmUzMmEgKCJkcm0vYXRvbWljOiBGaXggZnJl ZWluZyBjb25uZWN0b3IvcGxhbmUgc3RhdGUgdG9vIGVhcmx5IGJ5IHRyYWNraW5nIGNvbW1pdHMs IHYzLiIpCgpMb29rcyBzYW5lIHRvIG1lClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMgfCAxNyArKysrKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgOCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljX2hlbHBlci5jCj4gaW5kZXggYjY0YzhmNWJjOTQwLi5jMmE3ODg3ZGViMjUgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0xNzc1LDE2ICsxNzc1LDE2IEBAIGlu dCBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlLAo+ICAJfQo+ICAKPiAgCWZvcl9lYWNoX29sZG5ld19jb25uZWN0b3JfaW5fc3RhdGUo c3RhdGUsIGNvbm4sIG9sZF9jb25uX3N0YXRlLCBuZXdfY29ubl9zdGF0ZSwgaSkgewo+IC0JCS8q IGNvbW1pdCB0cmFja2VkIHRocm91Z2ggbmV3X2NydGNfc3RhdGUtPmNvbW1pdCwgbm8gbmVlZCB0 byBkbyBpdCBleHBsaWNpdGx5ICovCj4gLQkJaWYgKG5ld19jb25uX3N0YXRlLT5jcnRjKQo+IC0J CQljb250aW51ZTsKPiAtCj4gIAkJLyogVXNlcnNwYWNlIGlzIG5vdCBhbGxvd2VkIHRvIGdldCBh aGVhZCBvZiB0aGUgcHJldmlvdXMKPiAgCQkgKiBjb21taXQgd2l0aCBub25ibG9ja2luZyBvbmVz LiAqLwo+ICAJCWlmIChub25ibG9jayAmJiBvbGRfY29ubl9zdGF0ZS0+Y29tbWl0ICYmCj4gIAkJ ICAgICF0cnlfd2FpdF9mb3JfY29tcGxldGlvbigmb2xkX2Nvbm5fc3RhdGUtPmNvbW1pdC0+Zmxp cF9kb25lKSkKPiAgCQkJcmV0dXJuIC1FQlVTWTsKPiAgCj4gKwkJLyogY29tbWl0IHRyYWNrZWQg dGhyb3VnaCBuZXdfY3J0Y19zdGF0ZS0+Y29tbWl0LCBubyBuZWVkIHRvIGRvIGl0IGV4cGxpY2l0 bHkgKi8KPiArCQlpZiAobmV3X2Nvbm5fc3RhdGUtPmNydGMpCj4gKwkJCWNvbnRpbnVlOwo+ICsK PiAgCQljb21taXQgPSBjcnRjX29yX2Zha2VfY29tbWl0KHN0YXRlLCBvbGRfY29ubl9zdGF0ZS0+ Y3J0Yyk7Cj4gIAkJaWYgKCFjb21taXQpCj4gIAkJCXJldHVybiAtRU5PTUVNOwo+IEBAIC0xNzkz LDE3ICsxNzkzLDE2IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJfQo+ICAKPiAgCWZvcl9lYWNoX29sZG5ld19w bGFuZV9pbl9zdGF0ZShzdGF0ZSwgcGxhbmUsIG9sZF9wbGFuZV9zdGF0ZSwgbmV3X3BsYW5lX3N0 YXRlLCBpKSB7Cj4gLQkJLyoKPiAtCQkgKiBVbmxpa2UgY29ubmVjdG9ycywgYWx3YXlzIHRyYWNr IHBsYW5lcyBleHBsaWNpdGx5IGZvcgo+IC0JCSAqIGFzeW5jIHBhZ2VmbGlwIHN1cHBvcnQuCj4g LQkJICovCj4gLQo+ICAJCS8qIFVzZXJzcGFjZSBpcyBub3QgYWxsb3dlZCB0byBnZXQgYWhlYWQg b2YgdGhlIHByZXZpb3VzCj4gIAkJICogY29tbWl0IHdpdGggbm9uYmxvY2tpbmcgb25lcy4gKi8K PiAgCQlpZiAobm9uYmxvY2sgJiYgb2xkX3BsYW5lX3N0YXRlLT5jb21taXQgJiYKPiAgCQkgICAg IXRyeV93YWl0X2Zvcl9jb21wbGV0aW9uKCZvbGRfcGxhbmVfc3RhdGUtPmNvbW1pdC0+ZmxpcF9k b25lKSkKPiAgCQkJcmV0dXJuIC1FQlVTWTsKPiAgCj4gKwkJLyoKPiArCQkgKiBVbmxpa2UgY29u bmVjdG9ycywgYWx3YXlzIHRyYWNrIHBsYW5lcyBleHBsaWNpdGx5IGZvcgo+ICsJCSAqIGFzeW5j IHBhZ2VmbGlwIHN1cHBvcnQuCj4gKwkJICovCj4gIAkJY29tbWl0ID0gY3J0Y19vcl9mYWtlX2Nv bW1pdChzdGF0ZSwgb2xkX3BsYW5lX3N0YXRlLT5jcnRjID86IG5ld19wbGFuZV9zdGF0ZS0+Y3J0 Yyk7Cj4gIAkJaWYgKCFjb21taXQpCj4gIAkJCXJldHVybiAtRU5PTUVNOwo+IC0tIAo+IDIuMTQu MQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==